qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/3] q800: update machine emulation
Date: Sat, 14 Dec 2019 10:58:30 +0000	[thread overview]
Message-ID: <c90975ff-7e20-8de3-1faf-60e542ab3413@ilande.co.uk> (raw)
In-Reply-To: <20191212200142.15688-1-laurent@vivier.eu>

On 12/12/2019 20:01, Laurent Vivier wrote:

> On the way to run a MacOS ROM we need a more accurate
> emulation of the Quadra 800.
> 
> This series fixes the ESCC base address that was wrong but
> as the linux kernel uses the one provided by the bootloader
> (in our case QEMU) it was not a problem. This value
> is hardcoded in the ROM, so QEMU must use the good one.
> 
> The two other patches update the description of the machine
> by introducing the djMEMC memory controller and the machine id
> register.
> 
> Laurent Vivier (3):
>   q800: fix ESCC base
>   q800: add djMEMC memory controller
>   q800: add machine id register
> 
>  MAINTAINERS              |   2 +
>  hw/m68k/Kconfig          |   1 +
>  hw/m68k/q800.c           |  85 +++++++++----------
>  hw/misc/Kconfig          |   3 +
>  hw/misc/Makefile.objs    |   1 +
>  hw/misc/djmemc.c         | 176 +++++++++++++++++++++++++++++++++++++++
>  hw/misc/trace-events     |   4 +
>  include/hw/misc/djmemc.h |  34 ++++++++
>  8 files changed, 260 insertions(+), 46 deletions(-)
>  create mode 100644 hw/misc/djmemc.c
>  create mode 100644 include/hw/misc/djmemc.h

I think this is mostly there other than a few minor style and other tweaks, however
I'm wondering that since the q800 seems to have a few esoteric devices if it is worth
creating a separate subdirectory for them all under hw/misc/mac or similar?


ATB,

Mark.


      parent reply	other threads:[~2019-12-14 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 20:01 [PATCH 0/3] q800: update machine emulation Laurent Vivier
2019-12-12 20:01 ` [PATCH 1/3] q800: fix ESCC base Laurent Vivier
2019-12-14 10:51   ` Mark Cave-Ayland
2019-12-12 20:01 ` [PATCH 2/3] q800: add djMEMC memory controller Laurent Vivier
2019-12-12 21:12   ` BALATON Zoltan
2019-12-12 22:07   ` Philippe Mathieu-Daudé
2019-12-14 10:54   ` Mark Cave-Ayland
2019-12-12 20:01 ` [PATCH 3/3] q800: add machine id register Laurent Vivier
2019-12-14 10:55   ` Mark Cave-Ayland
2019-12-14 13:15   ` Philippe Mathieu-Daudé
2019-12-14 10:58 ` Mark Cave-Ayland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c90975ff-7e20-8de3-1faf-60e542ab3413@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).