From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Nolan Leake <nolan@sigbus.net>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Baumann <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH v3] Add basic power management to raspi.
Date: Sat, 26 Jun 2021 19:33:07 +0200 [thread overview]
Message-ID: <998200ac-3fff-7a28-2c33-648d63679658@amsat.org> (raw)
In-Reply-To: <20210625210209.1870217-1-nolan@sigbus.net>
On 6/25/21 11:02 PM, Nolan Leake wrote:
> This is just enough to make reboot and poweroff work. Works for
> linux, u-boot, and the arm trusted firmware. Not tested, but should
> work for plan9, and bare-metal/hobby OSes, since they seem to generally
> do what linux does for reset.
>
> The watchdog timer functionality is not yet implemented.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/64
> Signed-off-by: Nolan Leake <nolan@sigbus.net>
> ---
> hw/arm/bcm2835_peripherals.c | 13 ++-
> hw/misc/bcm2835_powermgt.c | 160 +++++++++++++++++++++++++++
> hw/misc/meson.build | 1 +
> include/hw/arm/bcm2835_peripherals.h | 3 +-
> include/hw/misc/bcm2835_powermgt.h | 29 +++++
> 5 files changed, 204 insertions(+), 2 deletions(-)
> create mode 100644 hw/misc/bcm2835_powermgt.c
> create mode 100644 include/hw/misc/bcm2835_powermgt.h
> create_unimp(s, &s->txp, "bcm2835-txp", TXP_OFFSET, 0x1000);
> create_unimp(s, &s->armtmr, "bcm2835-sp804", ARMCTRL_TIMER0_1_OFFSET, 0x40);
> - create_unimp(s, &s->powermgt, "bcm2835-powermgt", PM_OFFSET, 0x114);
> create_unimp(s, &s->i2s, "bcm2835-i2s", I2S_OFFSET, 0x100);
> create_unimp(s, &s->smi, "bcm2835-smi", SMI_OFFSET, 0x100);
> create_unimp(s, &s->spi[0], "bcm2835-spi0", SPI0_OFFSET, 0x20);
...
> +static void bcm2835_powermgt_init(Object *obj)
> +{
> + BCM2835PowerMgtState *s = BCM2835_POWERMGT(obj);
> +
> + memory_region_init_io(&s->iomem, obj, &bcm2835_powermgt_ops, s,
> + TYPE_BCM2835_POWERMGT, 0x114);
In case Peter asks you to resend your patch because can't apply it,
please use a region size of 0x200 here.
Alternatively you can increase the odds to get your patch merged by
resending it properly (I'm still not sure what broke it) before Peter
review the ARM patches next week.
prev parent reply other threads:[~2021-06-26 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 21:02 [PATCH v3] Add basic power management to raspi Nolan Leake
2021-06-26 10:16 ` Philippe Mathieu-Daudé
2021-06-28 17:38 ` Peter Maydell
2021-06-29 7:46 ` Philippe Mathieu-Daudé
2021-06-29 15:47 ` Nolan
2021-06-26 17:33 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998200ac-3fff-7a28-2c33-648d63679658@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=nolan@sigbus.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).