* [PATCH] tests/tcg/linux-test: Fix random hangs in test_socket
@ 2021-06-01 14:20 Ilya Leoshkevich
2021-07-28 11:37 ` [PATCH PING] " Ilya Leoshkevich
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Leoshkevich @ 2021-06-01 14:20 UTC (permalink / raw)
To: Alex Bennée; +Cc: Christian Borntraeger, qemu-devel, Ilya Leoshkevich
test_socket hangs randomly in connect(), especially when run without
qemu. Apparently the reason is that linux started treating backlog
value of 0 literally instead of rounding it up since v4.4 (commit
ef547f2ac16b).
So set it to 1 instead.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
tests/tcg/multiarch/linux-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index eba07273f7..3b256f6c02 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -263,7 +263,7 @@ static int server_socket(void)
sockaddr.sin_port = htons(0); /* choose random ephemeral port) */
sockaddr.sin_addr.s_addr = 0;
chk_error(bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)));
- chk_error(listen(fd, 0));
+ chk_error(listen(fd, 1));
return fd;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH PING] tests/tcg/linux-test: Fix random hangs in test_socket
2021-06-01 14:20 [PATCH] tests/tcg/linux-test: Fix random hangs in test_socket Ilya Leoshkevich
@ 2021-07-28 11:37 ` Ilya Leoshkevich
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Leoshkevich @ 2021-07-28 11:37 UTC (permalink / raw)
To: Alex Bennée, Laurent Vivier; +Cc: Christian Borntraeger, qemu-devel
On Tue, 2021-06-01 at 16:20 +0200, Ilya Leoshkevich wrote:
> test_socket hangs randomly in connect(), especially when run without
> qemu. Apparently the reason is that linux started treating backlog
> value of 0 literally instead of rounding it up since v4.4 (commit
> ef547f2ac16b).
>
> So set it to 1 instead.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> tests/tcg/multiarch/linux-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/linux-test.c
> b/tests/tcg/multiarch/linux-test.c
> index eba07273f7..3b256f6c02 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -263,7 +263,7 @@ static int server_socket(void)
> sockaddr.sin_port = htons(0); /* choose random ephemeral port)
> */
> sockaddr.sin_addr.s_addr = 0;
> chk_error(bind(fd, (struct sockaddr *)&sockaddr,
> sizeof(sockaddr)));
> - chk_error(listen(fd, 0));
> + chk_error(listen(fd, 1));
> return fd;
>
> }
Hello,
I would like to ping this patch.
Best regards,
Ilya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-28 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:20 [PATCH] tests/tcg/linux-test: Fix random hangs in test_socket Ilya Leoshkevich
2021-07-28 11:37 ` [PATCH PING] " Ilya Leoshkevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).