qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones
@ 2021-09-26 20:19 Philippe Mathieu-Daudé
  2021-09-27 13:53 ` Jag Raman
  2021-09-29 15:05 ` Laurent Vivier
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-26 20:19 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-trivial, Elena Ufimtseva, Jagannathan Raman,
	Philippe Mathieu-Daudé,
	John G Johnson

QEMU doesn't distinct network devices per link layer (Ethernet,
Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
devices.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/remote/proxy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
index 499f540c947..bad164299dd 100644
--- a/hw/remote/proxy.c
+++ b/hw/remote/proxy.c
@@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
         set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
         break;
     case PCI_BASE_CLASS_NETWORK:
+    case PCI_BASE_CLASS_WIRELESS:
         set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
         break;
     case PCI_BASE_CLASS_INPUT:
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones
  2021-09-26 20:19 [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones Philippe Mathieu-Daudé
@ 2021-09-27 13:53 ` Jag Raman
  2021-09-29 15:05 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Jag Raman @ 2021-09-27 13:53 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: qemu-trivial, Elena Ufimtseva, qemu-devel, John Johnson



> On Sep 26, 2021, at 4:19 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> QEMU doesn't distinct network devices per link layer (Ethernet,
> Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
> devices.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>

> ---
> hw/remote/proxy.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
> index 499f540c947..bad164299dd 100644
> --- a/hw/remote/proxy.c
> +++ b/hw/remote/proxy.c
> @@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
>         set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>         break;
>     case PCI_BASE_CLASS_NETWORK:
> +    case PCI_BASE_CLASS_WIRELESS:
>         set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>         break;
>     case PCI_BASE_CLASS_INPUT:
> -- 
> 2.31.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones
  2021-09-26 20:19 [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones Philippe Mathieu-Daudé
  2021-09-27 13:53 ` Jag Raman
@ 2021-09-29 15:05 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-09-29 15:05 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: qemu-trivial, Elena Ufimtseva, Jagannathan Raman, John G Johnson

Le 26/09/2021 à 22:19, Philippe Mathieu-Daudé a écrit :
> QEMU doesn't distinct network devices per link layer (Ethernet,
> Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
> devices.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/remote/proxy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
> index 499f540c947..bad164299dd 100644
> --- a/hw/remote/proxy.c
> +++ b/hw/remote/proxy.c
> @@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
>          set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>          break;
>      case PCI_BASE_CLASS_NETWORK:
> +    case PCI_BASE_CLASS_WIRELESS:
>          set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>          break;
>      case PCI_BASE_CLASS_INPUT:
> 

Applied to my trivial-patches branch.

Thanks,
Laurent


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-29 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 20:19 [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones Philippe Mathieu-Daudé
2021-09-27 13:53 ` Jag Raman
2021-09-29 15:05 ` Laurent Vivier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).