* [PATCH v2 0/2] target mips: Misc fixes and improvements @ 2020-06-30 16:46 Aleksandar Markovic 2020-06-30 16:46 ` [PATCH v2 1/2] target/mips: Remove identical if/else branches Aleksandar Markovic 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic 0 siblings, 2 replies; 14+ messages in thread From: Aleksandar Markovic @ 2020-06-30 16:46 UTC (permalink / raw) To: qemu-devel; +Cc: aleksandar.rikalo, Aleksandar Markovic A collection of pending fixes and improvements. v1->v2: - minor content and commit message changes Aleksandar Markovic (2): target/mips: Remove identical if/else branches MAINTAINERS: Adjust MIPS maintainership MAINTAINERS | 15 ++++++++++----- target/mips/cp0_helper.c | 9 +-------- 2 files changed, 11 insertions(+), 13 deletions(-) -- 2.20.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] target/mips: Remove identical if/else branches 2020-06-30 16:46 [PATCH v2 0/2] target mips: Misc fixes and improvements Aleksandar Markovic @ 2020-06-30 16:46 ` Aleksandar Markovic 2020-06-30 17:22 ` Philippe Mathieu-Daudé 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic 1 sibling, 1 reply; 14+ messages in thread From: Aleksandar Markovic @ 2020-06-30 16:46 UTC (permalink / raw) To: qemu-devel; +Cc: aleksandar.rikalo, Aleksandar Markovic Remove the segment: if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Original contributor can't remember what was his intention. Bug: 1885718 Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- target/mips/cp0_helper.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/mips/cp0_helper.c b/target/mips/cp0_helper.c index bbf12e4a97..de64add038 100644 --- a/target/mips/cp0_helper.c +++ b/target/mips/cp0_helper.c @@ -375,16 +375,9 @@ target_ulong helper_mftc0_entryhi(CPUMIPSState *env) target_ulong helper_mftc0_cause(CPUMIPSState *env) { int other_tc = env->CP0_VPEControl & (0xff << CP0VPECo_TargTC); - int32_t tccause; CPUMIPSState *other = mips_cpu_map_tc(env, &other_tc); - if (other_tc == other->current_tc) { - tccause = other->CP0_Cause; - } else { - tccause = other->CP0_Cause; - } - - return tccause; + return other->CP0_Cause; } target_ulong helper_mftc0_status(CPUMIPSState *env) -- 2.20.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] target/mips: Remove identical if/else branches 2020-06-30 16:46 ` [PATCH v2 1/2] target/mips: Remove identical if/else branches Aleksandar Markovic @ 2020-06-30 17:22 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-06-30 17:22 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel; +Cc: aleksandar.rikalo On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > Remove the segment: > > if (other_tc == other->current_tc) { > tccause = other->CP0_Cause; > } else { > tccause = other->CP0_Cause; > } > > Original contributor can't remember what was his intention. > > Bug: 1885718 The format documented in the wiki is: Fixes: 5a25ce9487 ("mips: Hook in more reg accesses via mttr/mftr") Buglink: https://bugs.launchpad.net/qemu/+bug/1885718 See: https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > target/mips/cp0_helper.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/target/mips/cp0_helper.c b/target/mips/cp0_helper.c > index bbf12e4a97..de64add038 100644 > --- a/target/mips/cp0_helper.c > +++ b/target/mips/cp0_helper.c > @@ -375,16 +375,9 @@ target_ulong helper_mftc0_entryhi(CPUMIPSState *env) > target_ulong helper_mftc0_cause(CPUMIPSState *env) > { > int other_tc = env->CP0_VPEControl & (0xff << CP0VPECo_TargTC); > - int32_t tccause; > CPUMIPSState *other = mips_cpu_map_tc(env, &other_tc); > > - if (other_tc == other->current_tc) { > - tccause = other->CP0_Cause; > - } else { > - tccause = other->CP0_Cause; > - } > - > - return tccause; > + return other->CP0_Cause; > } > > target_ulong helper_mftc0_status(CPUMIPSState *env) > ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 16:46 [PATCH v2 0/2] target mips: Misc fixes and improvements Aleksandar Markovic 2020-06-30 16:46 ` [PATCH v2 1/2] target/mips: Remove identical if/else branches Aleksandar Markovic @ 2020-06-30 16:46 ` Aleksandar Markovic 2020-06-30 17:19 ` Philippe Mathieu-Daudé ` (3 more replies) 1 sibling, 4 replies; 14+ messages in thread From: Aleksandar Markovic @ 2020-06-30 16:46 UTC (permalink / raw) To: qemu-devel Cc: Aurelien Jarno, aleksandar.rikalo, Aleksandar Markovic, Paul Burton Paul Burton and Aurelien Jarno removed for not being present. Huacai Chen and Jiaxun Yang step in as new energy. CC: Paul Burton <paulburton@kernel.org> CC: Aurelien Jarno <aurelien@aurel32.net> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- MAINTAINERS | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5d8acf8d31..7fc16e21c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -213,7 +213,8 @@ F: disas/microblaze.c MIPS TCG CPUs M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> -R: Aurelien Jarno <aurelien@aurel32.net> +M: Huacai Chen <chenhc@lemote.com> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Maintained F: target/mips/ @@ -377,6 +378,7 @@ F: target/arm/kvm.c MIPS KVM CPUs M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> +M: Huacai Chen <chenhc@lemote.com> S: Odd Fixes F: target/mips/kvm.c @@ -1052,6 +1054,7 @@ MIPS Machines ------------- Jazz M: Hervé Poussineau <hpoussin@reactos.org> +M: Huacai Chen <chenhc@lemote.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Maintained F: hw/mips/jazz.c @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c Malta M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> +M: Huacai Chen <chenhc@lemote.com> M: Philippe Mathieu-Daudé <f4bug@amsat.org> -R: Aurelien Jarno <aurelien@aurel32.net> S: Maintained F: hw/isa/piix4.c F: hw/acpi/piix4.c @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py Mipssim M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> +M: Huacai Chen <chenhc@lemote.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Odd Fixes F: hw/mips/mipssim.c @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c R4000 M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> -R: Aurelien Jarno <aurelien@aurel32.net> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Obsolete F: hw/mips/r4k.c @@ -1103,7 +1106,8 @@ S: Maintained F: hw/intc/loongson_liointc.c Boston -M: Paul Burton <pburton@wavecomp.com> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> +M: Huacai Chen <chenhc@lemote.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Maintained F: hw/core/loader-fit.c @@ -2677,7 +2681,8 @@ F: disas/i386.c MIPS TCG target M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> -R: Aurelien Jarno <aurelien@aurel32.net> +M: Huacai Chen <chenhc@lemote.com> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Maintained F: tcg/mips/ -- 2.20.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic @ 2020-06-30 17:19 ` Philippe Mathieu-Daudé 2020-07-01 8:00 ` Philippe Mathieu-Daudé 2020-07-01 15:38 ` Philippe Mathieu-Daudé ` (2 subsequent siblings) 3 siblings, 1 reply; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-06-30 17:19 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: aleksandar.rikalo, Paul Burton, Aurelien Jarno On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > Paul Burton and Aurelien Jarno removed for not being present. > > Huacai Chen and Jiaxun Yang step in as new energy. > > CC: Paul Burton <paulburton@kernel.org> > CC: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > MAINTAINERS | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5d8acf8d31..7fc16e21c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > MIPS TCG CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: target/mips/ > @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > MIPS KVM CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > S: Odd Fixes > F: target/mips/kvm.c > > @@ -1052,6 +1054,7 @@ MIPS Machines > ------------- > Jazz > M: Hervé Poussineau <hpoussin@reactos.org> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/mips/jazz.c > @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > Malta > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > -R: Aurelien Jarno <aurelien@aurel32.net> > S: Maintained > F: hw/isa/piix4.c > F: hw/acpi/piix4.c > @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > Mipssim > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Odd Fixes > F: hw/mips/mipssim.c > @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > R4000 > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Obsolete > F: hw/mips/r4k.c > @@ -1103,7 +1106,8 @@ S: Maintained > F: hw/intc/loongson_liointc.c > > Boston > -M: Paul Burton <pburton@wavecomp.com> > +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> Missing in the patch description that you are taking this machine over. > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/core/loader-fit.c > @@ -2677,7 +2681,8 @@ F: disas/i386.c > > MIPS TCG target > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: tcg/mips/ > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 17:19 ` Philippe Mathieu-Daudé @ 2020-07-01 8:00 ` Philippe Mathieu-Daudé 2020-07-01 8:48 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-07-01 8:00 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: aleksandar.rikalo, Aurelien Jarno, Paul Burton On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > On 6/30/20 6:46 PM, Aleksandar Markovic wrote: >> Paul Burton and Aurelien Jarno removed for not being present. >> >> Huacai Chen and Jiaxun Yang step in as new energy. >> >> CC: Paul Burton <paulburton@kernel.org> >> CC: Aurelien Jarno <aurelien@aurel32.net> >> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> --- >> MAINTAINERS | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 5d8acf8d31..7fc16e21c9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -213,7 +213,8 @@ F: disas/microblaze.c >> >> MIPS TCG CPUs >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> -R: Aurelien Jarno <aurelien@aurel32.net> >> +M: Huacai Chen <chenhc@lemote.com> >> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Maintained >> F: target/mips/ >> @@ -377,6 +378,7 @@ F: target/arm/kvm.c >> >> MIPS KVM CPUs >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> +M: Huacai Chen <chenhc@lemote.com> >> S: Odd Fixes >> F: target/mips/kvm.c >> >> @@ -1052,6 +1054,7 @@ MIPS Machines >> ------------- >> Jazz >> M: Hervé Poussineau <hpoussin@reactos.org> >> +M: Huacai Chen <chenhc@lemote.com> Hmm this is the Jazz hobbyist machine, Huacai are you sure this the correct section you want to be? Anyway Hervé Poussineau has to ack that, Aleksandar, it would be easier if you split this as a separate patch. >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Maintained >> F: hw/mips/jazz.c >> @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c >> >> Malta >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> +M: Huacai Chen <chenhc@lemote.com> >> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >> -R: Aurelien Jarno <aurelien@aurel32.net> Last time Aurelien commented on the Malta machine, was on March 23, 3 months ago, then there hasn't been Malta patches. As a reviewer he is present and provides valuable feedback, why are you kicking him out? See: https://www.mail-archive.com/qemu-devel@nongnu.org/msg691406.html Huacai, has Jiangsu Lemote Tech Co., Ltd real interest to paid employees to maintain the Malta board? >> S: Maintained >> F: hw/isa/piix4.c >> F: hw/acpi/piix4.c >> @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py >> >> Mipssim >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> +M: Huacai Chen <chenhc@lemote.com> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Odd Fixes Now that you have 2 maintainers, you can raise the status to Maintained. >> F: hw/mips/mipssim.c >> @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c >> >> R4000 >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> -R: Aurelien Jarno <aurelien@aurel32.net> I'm sure Aurelien will agree with this part. But let's wait for his feedback. >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Obsolete >> F: hw/mips/r4k.c >> @@ -1103,7 +1106,8 @@ S: Maintained >> F: hw/intc/loongson_liointc.c >> >> Boston >> -M: Paul Burton <pburton@wavecomp.com> >> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > Missing in the patch description that you are taking this > machine over. After some rest I remember Paul said he'd come back on QEMU, so it doesn't look right to kick him out that way. Also in this thread you said you never saw a Boston board: https://www.mail-archive.com/qemu-devel@nongnu.org/msg691778.html Paul might welcome you as a co-maintainer, but I rather keep him for his expertise. > >> +M: Huacai Chen <chenhc@lemote.com> Huacai, similarly does Jiangsu Lemote Tech Co., Ltd have real interest in time to provide developers to maintain the Boston machine? >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Maintained >> F: hw/core/loader-fit.c >> @@ -2677,7 +2681,8 @@ F: disas/i386.c >> >> MIPS TCG target >> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> -R: Aurelien Jarno <aurelien@aurel32.net> >> +M: Huacai Chen <chenhc@lemote.com> $ git log --author='Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l 0 $ git log --grep='Reviewed-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l 0 git log --grep='Acked-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l 0 >> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> $ git log --grep='Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' tcg/mips/ | wc -l 0 $ git log --grep='Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' tcg/mips/ | wc -l 0 I think you are confusing sections, Since Huacai and Jiaxun never showed interest in the TCG target code, how can they become maintainers? >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> $ git log --grep='Reviewed-by: Aleksandar Rikalo' tcg/mips/ | wc -l 0 $ git log --grep='Acked-by: Aleksandar Rikalo' tcg/mips/ | wc -l 0 Apparently Aleksandar Rikalo can be "removed for not being present." OTOH FWIW: $ git log --author='Philippe Mathieu-Daudé' tcg/mips/ | wc -l 25 $ git log --grep='Reviewed-by: Philippe Mathieu-Daudé' tcg/mips/ | wc -l 99 So for this section changes: NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> The rest is conditional of Paul Burton and Aurelien Jarno Ack-by. >> S: Maintained >> F: tcg/mips/ >> > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-07-01 8:00 ` Philippe Mathieu-Daudé @ 2020-07-01 8:48 ` Philippe Mathieu-Daudé 2020-07-01 11:05 ` chen huacai 0 siblings, 1 reply; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-07-01 8:48 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: aleksandar.rikalo, Paul Burton, Aurelien Jarno On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: >>> Paul Burton and Aurelien Jarno removed for not being present. >>> >>> Huacai Chen and Jiaxun Yang step in as new energy. >>> >>> CC: Paul Burton <paulburton@kernel.org> >>> CC: Aurelien Jarno <aurelien@aurel32.net> >>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> --- >>> MAINTAINERS | 15 ++++++++++----- >>> 1 file changed, 10 insertions(+), 5 deletions(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 5d8acf8d31..7fc16e21c9 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -213,7 +213,8 @@ F: disas/microblaze.c >>> >>> MIPS TCG CPUs >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> -R: Aurelien Jarno <aurelien@aurel32.net> >>> +M: Huacai Chen <chenhc@lemote.com> >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Maintained >>> F: target/mips/ >>> @@ -377,6 +378,7 @@ F: target/arm/kvm.c >>> >>> MIPS KVM CPUs >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> +M: Huacai Chen <chenhc@lemote.com> >>> S: Odd Fixes >>> F: target/mips/kvm.c >>> >>> @@ -1052,6 +1054,7 @@ MIPS Machines >>> ------------- >>> Jazz >>> M: Hervé Poussineau <hpoussin@reactos.org> >>> +M: Huacai Chen <chenhc@lemote.com> > > Hmm this is the Jazz hobbyist machine, Huacai are you sure this > the correct section you want to be? > > Anyway Hervé Poussineau has to ack that, Aleksandar, it would > be easier if you split this as a separate patch. > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Maintained >>> F: hw/mips/jazz.c >>> @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c >>> >>> Malta >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> +M: Huacai Chen <chenhc@lemote.com> >>> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > Last time Aurelien commented on the Malta machine, was on March 23, > 3 months ago, then there hasn't been Malta patches. As a reviewer > he is present and provides valuable feedback, why are you kicking > him out? See: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691406.html > > Huacai, has Jiangsu Lemote Tech Co., Ltd real interest to paid > employees to maintain the Malta board? > >>> S: Maintained >>> F: hw/isa/piix4.c >>> F: hw/acpi/piix4.c >>> @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py >>> >>> Mipssim >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> +M: Huacai Chen <chenhc@lemote.com> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Odd Fixes > > Now that you have 2 maintainers, you can raise the status to Maintained. > >>> F: hw/mips/mipssim.c >>> @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c >>> >>> R4000 >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > I'm sure Aurelien will agree with this part. But let's wait > for his feedback. > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Obsolete >>> F: hw/mips/r4k.c >>> @@ -1103,7 +1106,8 @@ S: Maintained >>> F: hw/intc/loongson_liointc.c >>> >>> Boston >>> -M: Paul Burton <pburton@wavecomp.com> >>> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> >> Missing in the patch description that you are taking this >> machine over. > > After some rest I remember Paul said he'd come back on QEMU, > so it doesn't look right to kick him out that way. > > Also in this thread you said you never saw a Boston board: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691778.html > > Paul might welcome you as a co-maintainer, but I rather keep > him for his expertise. Looking in archives, on Oct 20 2019 Paul said "it would be a pain to me if the boston machine bitrotted or anything" and he planned to find time to improve "the CM & MT ASE emulation". This was before Feb 19 2020 when he announced "[his] time with MIPS the company has reached its end": https://lkml.org/lkml/2020/2/19/984 Still this change requires an Ack from him. > >> >>> +M: Huacai Chen <chenhc@lemote.com> > > Huacai, similarly does Jiangsu Lemote Tech Co., Ltd have real > interest in time to provide developers to maintain the Boston > machine? > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Maintained >>> F: hw/core/loader-fit.c >>> @@ -2677,7 +2681,8 @@ F: disas/i386.c >>> >>> MIPS TCG target >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> -R: Aurelien Jarno <aurelien@aurel32.net> >>> +M: Huacai Chen <chenhc@lemote.com> > > $ git log --author='Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > 0 > > $ git log --grep='Reviewed-by: Huacai Chen <chenhc@lemote.com>' > tcg/mips/ | wc -l > 0 > > git log --grep='Acked-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > 0 > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > $ git log --grep='Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > tcg/mips/ | wc -l > 0 > > $ git log --grep='Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > tcg/mips/ | wc -l > 0 > > I think you are confusing sections, Since Huacai and Jiaxun never showed > interest in the TCG target code, how can they become maintainers? > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > $ git log --grep='Reviewed-by: Aleksandar Rikalo' tcg/mips/ | wc -l > 0 > $ git log --grep='Acked-by: Aleksandar Rikalo' tcg/mips/ | wc -l > 0 > > Apparently Aleksandar Rikalo can be "removed for not being present." > > OTOH FWIW: > $ git log --author='Philippe Mathieu-Daudé' tcg/mips/ | wc -l > 25 > $ git log --grep='Reviewed-by: Philippe Mathieu-Daudé' tcg/mips/ | wc -l > 99 > > So for this section changes: > NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > The rest is conditional of Paul Burton and Aurelien Jarno Ack-by. > >>> S: Maintained >>> F: tcg/mips/ >>> >> >> > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-07-01 8:48 ` Philippe Mathieu-Daudé @ 2020-07-01 11:05 ` chen huacai 2020-07-01 13:53 ` Aleksandar Markovic 0 siblings, 1 reply; 14+ messages in thread From: chen huacai @ 2020-07-01 11:05 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Aurelien Jarno, Aleksandar Markovic, Aleksandar Rikalo, qemu-level, Paul Burton Hi, Philippe and Alexandar, On Wed, Jul 1, 2020 at 4:49 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > >>> Paul Burton and Aurelien Jarno removed for not being present. > >>> > >>> Huacai Chen and Jiaxun Yang step in as new energy. > >>> > >>> CC: Paul Burton <paulburton@kernel.org> > >>> CC: Aurelien Jarno <aurelien@aurel32.net> > >>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> --- > >>> MAINTAINERS | 15 ++++++++++----- > >>> 1 file changed, 10 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index 5d8acf8d31..7fc16e21c9 100644 > >>> --- a/MAINTAINERS > >>> +++ b/MAINTAINERS > >>> @@ -213,7 +213,8 @@ F: disas/microblaze.c > >>> > >>> MIPS TCG CPUs > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > >>> +M: Huacai Chen <chenhc@lemote.com> > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > >>> S: Maintained > >>> F: target/mips/ > >>> @@ -377,6 +378,7 @@ F: target/arm/kvm.c > >>> > >>> MIPS KVM CPUs > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> +M: Huacai Chen <chenhc@lemote.com> > >>> S: Odd Fixes > >>> F: target/mips/kvm.c > >>> > >>> @@ -1052,6 +1054,7 @@ MIPS Machines > >>> ------------- > >>> Jazz > >>> M: Hervé Poussineau <hpoussin@reactos.org> > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > Hmm this is the Jazz hobbyist machine, Huacai are you sure this > > the correct section you want to be? > > > > Anyway Hervé Poussineau has to ack that, Aleksandar, it would > > be easier if you split this as a separate patch. > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > >>> S: Maintained > >>> F: hw/mips/jazz.c > >>> @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > >>> > >>> Malta > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> +M: Huacai Chen <chenhc@lemote.com> > >>> M: Philippe Mathieu-Daudé <f4bug@amsat.org> > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > > > Last time Aurelien commented on the Malta machine, was on March 23, > > 3 months ago, then there hasn't been Malta patches. As a reviewer > > he is present and provides valuable feedback, why are you kicking > > him out? See: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691406.html > > > > Huacai, has Jiangsu Lemote Tech Co., Ltd real interest to paid > > employees to maintain the Malta board? I think I can review TCG part and maintain KVM part currently, but can't maintain Jazz/Malta/Mipssim/R4k/Boston (maybe possible in future, but not now). Thanks, Huacai > > > >>> S: Maintained > >>> F: hw/isa/piix4.c > >>> F: hw/acpi/piix4.c > >>> @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > >>> > >>> Mipssim > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> +M: Huacai Chen <chenhc@lemote.com> > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > >>> S: Odd Fixes > > > > Now that you have 2 maintainers, you can raise the status to Maintained. > > > >>> F: hw/mips/mipssim.c > >>> @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > >>> > >>> R4000 > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > > > I'm sure Aurelien will agree with this part. But let's wait > > for his feedback. > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > >>> S: Obsolete > >>> F: hw/mips/r4k.c > >>> @@ -1103,7 +1106,8 @@ S: Maintained > >>> F: hw/intc/loongson_liointc.c > >>> > >>> Boston > >>> -M: Paul Burton <pburton@wavecomp.com> > >>> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >> > >> Missing in the patch description that you are taking this > >> machine over. > > > > After some rest I remember Paul said he'd come back on QEMU, > > so it doesn't look right to kick him out that way. > > > > Also in this thread you said you never saw a Boston board: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691778.html > > > > Paul might welcome you as a co-maintainer, but I rather keep > > him for his expertise. > > Looking in archives, on Oct 20 2019 Paul said "it would be a pain > to me if the boston machine bitrotted or anything" and he planned > to find time to improve "the CM & MT ASE emulation". > > This was before Feb 19 2020 when he announced "[his] time with MIPS > the company has reached its end": https://lkml.org/lkml/2020/2/19/984 > > Still this change requires an Ack from him. > > > > >> > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > Huacai, similarly does Jiangsu Lemote Tech Co., Ltd have real > > interest in time to provide developers to maintain the Boston > > machine? > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > >>> S: Maintained > >>> F: hw/core/loader-fit.c > >>> @@ -2677,7 +2681,8 @@ F: disas/i386.c > >>> > >>> MIPS TCG target > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > $ git log --author='Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > > 0 > > > > $ git log --grep='Reviewed-by: Huacai Chen <chenhc@lemote.com>' > > tcg/mips/ | wc -l > > 0 > > > > git log --grep='Acked-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > > 0 > > > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > > > $ git log --grep='Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > > tcg/mips/ | wc -l > > 0 > > > > $ git log --grep='Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > > tcg/mips/ | wc -l > > 0 > > > > I think you are confusing sections, Since Huacai and Jiaxun never showed > > interest in the TCG target code, how can they become maintainers? > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > > > $ git log --grep='Reviewed-by: Aleksandar Rikalo' tcg/mips/ | wc -l > > 0 > > $ git log --grep='Acked-by: Aleksandar Rikalo' tcg/mips/ | wc -l > > 0 > > > > Apparently Aleksandar Rikalo can be "removed for not being present." > > > > OTOH FWIW: > > $ git log --author='Philippe Mathieu-Daudé' tcg/mips/ | wc -l > > 25 > > $ git log --grep='Reviewed-by: Philippe Mathieu-Daudé' tcg/mips/ | wc -l > > 99 > > > > So for this section changes: > > NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > > > The rest is conditional of Paul Burton and Aurelien Jarno Ack-by. > > > >>> S: Maintained > >>> F: tcg/mips/ > >>> > >> > >> > > > -- Huacai Chen ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-07-01 11:05 ` chen huacai @ 2020-07-01 13:53 ` Aleksandar Markovic 2020-07-01 15:46 ` Paolo Bonzini 0 siblings, 1 reply; 14+ messages in thread From: Aleksandar Markovic @ 2020-07-01 13:53 UTC (permalink / raw) To: chen huacai Cc: Aurelien Jarno, Aleksandar Rikalo, Philippe Mathieu-Daudé, Paul Burton, qemu-level On Wed, Jul 1, 2020 at 1:05 PM chen huacai <zltjiangshi@gmail.com> wrote: > > Hi, Philippe and Alexandar, > > On Wed, Jul 1, 2020 at 4:49 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > > > On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > > > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > > >>> Paul Burton and Aurelien Jarno removed for not being present. > > >>> > > >>> Huacai Chen and Jiaxun Yang step in as new energy. > > >>> > > >>> CC: Paul Burton <paulburton@kernel.org> > > >>> CC: Aurelien Jarno <aurelien@aurel32.net> > > >>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> --- > > >>> MAINTAINERS | 15 ++++++++++----- > > >>> 1 file changed, 10 insertions(+), 5 deletions(-) > > >>> > > >>> diff --git a/MAINTAINERS b/MAINTAINERS > > >>> index 5d8acf8d31..7fc16e21c9 100644 > > >>> --- a/MAINTAINERS > > >>> +++ b/MAINTAINERS > > >>> @@ -213,7 +213,8 @@ F: disas/microblaze.c > > >>> > > >>> MIPS TCG CPUs > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > >>> S: Maintained > > >>> F: target/mips/ > > >>> @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > >>> > > >>> MIPS KVM CPUs > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > >>> S: Odd Fixes > > >>> F: target/mips/kvm.c > > >>> > > >>> @@ -1052,6 +1054,7 @@ MIPS Machines > > >>> ------------- > > >>> Jazz > > >>> M: Hervé Poussineau <hpoussin@reactos.org> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > > > Hmm this is the Jazz hobbyist machine, Huacai are you sure this > > > the correct section you want to be? > > > > > > Anyway Hervé Poussineau has to ack that, Aleksandar, it would > > > be easier if you split this as a separate patch. > > > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > >>> S: Maintained > > >>> F: hw/mips/jazz.c > > >>> @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > >>> > > >>> Malta > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > >>> M: Philippe Mathieu-Daudé <f4bug@amsat.org> > > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > > > > > Last time Aurelien commented on the Malta machine, was on March 23, > > > 3 months ago, then there hasn't been Malta patches. As a reviewer > > > he is present and provides valuable feedback, why are you kicking > > > him out? See: > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691406.html > > > > > > Huacai, has Jiangsu Lemote Tech Co., Ltd real interest to paid > > > employees to maintain the Malta board? > I think I can review TCG part and maintain KVM part currently, but > can't maintain Jazz/Malta/Mipssim/R4k/Boston (maybe possible in > future, but not now). > Sure, Huacai, I will respect your wish. I truly like your cautious approach. Although, honestly speaking, your credentials for being a maintainer are - at least - three order of magnitude higher than for some other maintainer. But, people, here we have a responsible, serious man - Huacai Chen! Bravo for caution, bravo for being modest, and bravo for being not greedy! My deep admiration! We want and we need such people in QEMU for MIPS! There is a place for you here! Aleksandar > Thanks, > Huacai > > > > > >>> S: Maintained > > >>> F: hw/isa/piix4.c > > >>> F: hw/acpi/piix4.c > > >>> @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > >>> > > >>> Mipssim > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > >>> S: Odd Fixes > > > > > > Now that you have 2 maintainers, you can raise the status to Maintained. > > > > > >>> F: hw/mips/mipssim.c > > >>> @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > >>> > > >>> R4000 > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > > > > > I'm sure Aurelien will agree with this part. But let's wait > > > for his feedback. > > > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > >>> S: Obsolete > > >>> F: hw/mips/r4k.c > > >>> @@ -1103,7 +1106,8 @@ S: Maintained > > >>> F: hw/intc/loongson_liointc.c > > >>> > > >>> Boston > > >>> -M: Paul Burton <pburton@wavecomp.com> > > >>> +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >> > > >> Missing in the patch description that you are taking this > > >> machine over. > > > > > > After some rest I remember Paul said he'd come back on QEMU, > > > so it doesn't look right to kick him out that way. > > > > > > Also in this thread you said you never saw a Boston board: > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691778.html > > > > > > Paul might welcome you as a co-maintainer, but I rather keep > > > him for his expertise. > > > > Looking in archives, on Oct 20 2019 Paul said "it would be a pain > > to me if the boston machine bitrotted or anything" and he planned > > to find time to improve "the CM & MT ASE emulation". > > > > This was before Feb 19 2020 when he announced "[his] time with MIPS > > the company has reached its end": https://lkml.org/lkml/2020/2/19/984 > > > > Still this change requires an Ack from him. > > > > > > > >> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > > > Huacai, similarly does Jiangsu Lemote Tech Co., Ltd have real > > > interest in time to provide developers to maintain the Boston > > > machine? > > > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > >>> S: Maintained > > >>> F: hw/core/loader-fit.c > > >>> @@ -2677,7 +2681,8 @@ F: disas/i386.c > > >>> > > >>> MIPS TCG target > > >>> M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > >>> -R: Aurelien Jarno <aurelien@aurel32.net> > > >>> +M: Huacai Chen <chenhc@lemote.com> > > > > > > $ git log --author='Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > > > 0 > > > > > > $ git log --grep='Reviewed-by: Huacai Chen <chenhc@lemote.com>' > > > tcg/mips/ | wc -l > > > 0 > > > > > > git log --grep='Acked-by: Huacai Chen <chenhc@lemote.com>' tcg/mips/ | wc -l > > > 0 > > > > > >>> +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > > > > > $ git log --grep='Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > > > tcg/mips/ | wc -l > > > 0 > > > > > > $ git log --grep='Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>' > > > tcg/mips/ | wc -l > > > 0 > > > > > > I think you are confusing sections, Since Huacai and Jiaxun never showed > > > interest in the TCG target code, how can they become maintainers? > > > > > >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > > > > > $ git log --grep='Reviewed-by: Aleksandar Rikalo' tcg/mips/ | wc -l > > > 0 > > > $ git log --grep='Acked-by: Aleksandar Rikalo' tcg/mips/ | wc -l > > > 0 > > > > > > Apparently Aleksandar Rikalo can be "removed for not being present." > > > > > > OTOH FWIW: > > > $ git log --author='Philippe Mathieu-Daudé' tcg/mips/ | wc -l > > > 25 > > > $ git log --grep='Reviewed-by: Philippe Mathieu-Daudé' tcg/mips/ | wc -l > > > 99 > > > > > > So for this section changes: > > > NAcked-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > > > > > The rest is conditional of Paul Burton and Aurelien Jarno Ack-by. > > > > > >>> S: Maintained > > >>> F: tcg/mips/ > > >>> > > >> > > >> > > > > > > > > -- > Huacai Chen ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-07-01 13:53 ` Aleksandar Markovic @ 2020-07-01 15:46 ` Paolo Bonzini 0 siblings, 0 replies; 14+ messages in thread From: Paolo Bonzini @ 2020-07-01 15:46 UTC (permalink / raw) To: Aleksandar Markovic, chen huacai Cc: Aleksandar Rikalo, Paul Burton, Philippe Mathieu-Daudé, Aurelien Jarno, qemu-level On 01/07/20 15:53, Aleksandar Markovic wrote: > Although, honestly speaking, your > credentials for being a maintainer are - at least - three order of > magnitude higher than for some other maintainer. Aleksandar, this is not an acceptable way to refer to other people contributing to QEMU. To date, the QEMU community has not explicitly set rules around acceptable behavior nor has it adopted a Code of Conduct, mostly because we never had to deal with serious harassment. However, the basic standards for getting along with others still apply, and they were not respected in this case. Respectfully, Paolo ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic 2020-06-30 17:19 ` Philippe Mathieu-Daudé @ 2020-07-01 15:38 ` Philippe Mathieu-Daudé 2020-07-01 15:39 ` Philippe Mathieu-Daudé 2020-07-01 20:11 ` Aurelien Jarno 3 siblings, 0 replies; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-07-01 15:38 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: aleksandar.rikalo, Paul Burton, Aurelien Jarno On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > Paul Burton and Aurelien Jarno removed for not being present. > > Huacai Chen and Jiaxun Yang step in as new energy. > > CC: Paul Burton <paulburton@kernel.org> > CC: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > MAINTAINERS | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5d8acf8d31..7fc16e21c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > MIPS TCG CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: target/mips/ > @@ -377,6 +378,7 @@ F: target/arm/kvm.c [...] > > MIPS TCG target > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: tcg/mips/ > Jiaxun Yang is very active with Loongson on the kernel side, and is also very motivated. Looking at commit 84878f4c00 ("Fix loongson multimedia condition instructions") he has enough knowledge to be listed as TCG maintainer, not a reviewer. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic 2020-06-30 17:19 ` Philippe Mathieu-Daudé 2020-07-01 15:38 ` Philippe Mathieu-Daudé @ 2020-07-01 15:39 ` Philippe Mathieu-Daudé 2020-07-01 20:11 ` Aurelien Jarno 3 siblings, 0 replies; 14+ messages in thread From: Philippe Mathieu-Daudé @ 2020-07-01 15:39 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: Huacai Chen, aleksandar.rikalo, Paul Burton, Aurelien Jarno Cc'ing Huacai Chen and Jiaxun Yang, as you forgot to include them. On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > Paul Burton and Aurelien Jarno removed for not being present. > > Huacai Chen and Jiaxun Yang step in as new energy. > > CC: Paul Burton <paulburton@kernel.org> > CC: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > MAINTAINERS | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5d8acf8d31..7fc16e21c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > MIPS TCG CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: target/mips/ > @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > MIPS KVM CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > S: Odd Fixes > F: target/mips/kvm.c > > @@ -1052,6 +1054,7 @@ MIPS Machines > ------------- > Jazz > M: Hervé Poussineau <hpoussin@reactos.org> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/mips/jazz.c > @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > Malta > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > -R: Aurelien Jarno <aurelien@aurel32.net> > S: Maintained > F: hw/isa/piix4.c > F: hw/acpi/piix4.c > @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > Mipssim > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Odd Fixes > F: hw/mips/mipssim.c > @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > R4000 > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Obsolete > F: hw/mips/r4k.c > @@ -1103,7 +1106,8 @@ S: Maintained > F: hw/intc/loongson_liointc.c > > Boston > -M: Paul Burton <pburton@wavecomp.com> > +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/core/loader-fit.c > @@ -2677,7 +2681,8 @@ F: disas/i386.c > > MIPS TCG target > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: tcg/mips/ > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic ` (2 preceding siblings ...) 2020-07-01 15:39 ` Philippe Mathieu-Daudé @ 2020-07-01 20:11 ` Aurelien Jarno 2020-07-01 21:37 ` Aleksandar Markovic 3 siblings, 1 reply; 14+ messages in thread From: Aurelien Jarno @ 2020-07-01 20:11 UTC (permalink / raw) To: Aleksandar Markovic; +Cc: aleksandar.rikalo, qemu-devel, Paul Burton Hi Aleksandar, I know you have sent a v3 of this patch in the meantime, but I would still like to comment on it. First of all I confirm, that I do not have time to contribute to QEMU anymore and that I said I would like to resign from QEMU maintainership. We discussed that in person in Lyon back in October. I am happy to see that people are interested to take the maintainership. It happens that I known Huacai Chen from the time he was upstreaming the Loongson 3 support to the kernel, I have been testing and reviewing his patches. I also know Jiaxun Yang from the #debian-mips IRC channel. I know that they are both very competent and have a good knowledge of the open source world. I therefore agree that they are good additions to maintain and/or review the MIPS part of QEMU. All that said, they have been contributing only relatively recently to QEMU, and only to some areas. While I do support adding them to those areas, I wonder for example why adding them to the MIPS TCG target or to the Jazz board. That's probably something that should be done in a second step if they have an interest in doing so. I am fully aware that you posted a v3, that fixes exactly that after you got pointed out. However, I am still concerned by the way things happened. Regards, Aurelien On 2020-06-30 18:46, Aleksandar Markovic wrote: > Paul Burton and Aurelien Jarno removed for not being present. > > Huacai Chen and Jiaxun Yang step in as new energy. > > CC: Paul Burton <paulburton@kernel.org> > CC: Aurelien Jarno <aurelien@aurel32.net> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > MAINTAINERS | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5d8acf8d31..7fc16e21c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > MIPS TCG CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: target/mips/ > @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > MIPS KVM CPUs > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > S: Odd Fixes > F: target/mips/kvm.c > > @@ -1052,6 +1054,7 @@ MIPS Machines > ------------- > Jazz > M: Hervé Poussineau <hpoussin@reactos.org> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/mips/jazz.c > @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > Malta > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > -R: Aurelien Jarno <aurelien@aurel32.net> > S: Maintained > F: hw/isa/piix4.c > F: hw/acpi/piix4.c > @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > Mipssim > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Odd Fixes > F: hw/mips/mipssim.c > @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > R4000 > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Obsolete > F: hw/mips/r4k.c > @@ -1103,7 +1106,8 @@ S: Maintained > F: hw/intc/loongson_liointc.c > > Boston > -M: Paul Burton <pburton@wavecomp.com> > +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +M: Huacai Chen <chenhc@lemote.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: hw/core/loader-fit.c > @@ -2677,7 +2681,8 @@ F: disas/i386.c > > MIPS TCG target > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > -R: Aurelien Jarno <aurelien@aurel32.net> > +M: Huacai Chen <chenhc@lemote.com> > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Maintained > F: tcg/mips/ > -- > 2.20.1 > > > -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership 2020-07-01 20:11 ` Aurelien Jarno @ 2020-07-01 21:37 ` Aleksandar Markovic 0 siblings, 0 replies; 14+ messages in thread From: Aleksandar Markovic @ 2020-07-01 21:37 UTC (permalink / raw) To: Aurelien Jarno; +Cc: aleksandar.rikalo, qemu-devel, Paul Burton [-- Attachment #1: Type: text/plain, Size: 5900 bytes --] On Wednesday, July 1, 2020, Aurelien Jarno <aurelien@aurel32.net> wrote: > Hi Aleksandar, > > I know you have sent a v3 of this patch in the meantime, but I would > still like to comment on it. > > First of all I confirm, that I do not have time to contribute to QEMU > anymore and that I said I would like to resign from QEMU maintainership. > We discussed that in person in Lyon back in October. I am happy to see > that people are interested to take the maintainership. > > It happens that I known Huacai Chen from the time he was upstreaming the > Loongson 3 support to the kernel, I have been testing and reviewing his > patches. I also know Jiaxun Yang from the #debian-mips IRC channel. I > know that they are both very competent and have a good knowledge of the > open source world. I therefore agree that they are good additions to > maintain and/or review the MIPS part of QEMU. > > All that said, they have been contributing only relatively recently to > QEMU, and only to some areas. While I do support adding them to those > areas, I wonder for example why adding them to the MIPS TCG target or > to the Jazz board. That's probably something that should be done in a > second step if they have an interest in doing so. > > I am fully aware that you posted a v3, that fixes exactly that after you > got pointed out. However, I am still concerned by the way things > happened. > > Sure, I understand your point. I am glad you respond in a reasonable, civilized, way, about a reasonable topic, and I find talking to you a very pleasant experience - even if we disagree, it doesn't make a difference at all. The point of the segments you described is: You have to throw somebody in unkown water, on purpose, in order to teach him how to swim in the best way, and get out of him the best, his best. That is all what I meant. No ulterior motive whatsoever. Somebody like it, somebody does not. Huacai doesn't, and I respect it, as shown in v3. If you were here, all will be easier - we could talk, consult each other, advice each other. I would enjoy working with you. I have also strong feeling we would find common interest outside technical world, probably in various intelectual realms. Perhaps this is not known to you, but french thinkers are much appreciated and understood here in Serbia. We are frankofilles. But you choose not to be here. And what can I do? I can't force you to be somewhere you don't want to be. I felt the loss of you not being here throughout all my online presence. Mixed feelings, ha? Truly yours, Aleksandar > Regards, > Aurelien > > > On 2020-06-30 18:46, Aleksandar Markovic wrote: > > Paul Burton and Aurelien Jarno removed for not being present. > > > > Huacai Chen and Jiaxun Yang step in as new energy. > > > > CC: Paul Burton <paulburton@kernel.org> > > CC: Aurelien Jarno <aurelien@aurel32.net> > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > --- > > MAINTAINERS | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5d8acf8d31..7fc16e21c9 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > > > MIPS TCG CPUs > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > -R: Aurelien Jarno <aurelien@aurel32.net> > > +M: Huacai Chen <chenhc@lemote.com> > > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Maintained > > F: target/mips/ > > @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > > > MIPS KVM CPUs > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > +M: Huacai Chen <chenhc@lemote.com> > > S: Odd Fixes > > F: target/mips/kvm.c > > > > @@ -1052,6 +1054,7 @@ MIPS Machines > > ------------- > > Jazz > > M: Hervé Poussineau <hpoussin@reactos.org> > > +M: Huacai Chen <chenhc@lemote.com> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Maintained > > F: hw/mips/jazz.c > > @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > > > Malta > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > +M: Huacai Chen <chenhc@lemote.com> > > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > > -R: Aurelien Jarno <aurelien@aurel32.net> > > S: Maintained > > F: hw/isa/piix4.c > > F: hw/acpi/piix4.c > > @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > > > Mipssim > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > +M: Huacai Chen <chenhc@lemote.com> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Odd Fixes > > F: hw/mips/mipssim.c > > @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > > > R4000 > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > -R: Aurelien Jarno <aurelien@aurel32.net> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Obsolete > > F: hw/mips/r4k.c > > @@ -1103,7 +1106,8 @@ S: Maintained > > F: hw/intc/loongson_liointc.c > > > > Boston > > -M: Paul Burton <pburton@wavecomp.com> > > +M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > +M: Huacai Chen <chenhc@lemote.com> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Maintained > > F: hw/core/loader-fit.c > > @@ -2677,7 +2681,8 @@ F: disas/i386.c > > > > MIPS TCG target > > M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > > -R: Aurelien Jarno <aurelien@aurel32.net> > > +M: Huacai Chen <chenhc@lemote.com> > > +R: Jiaxun Yang <jiaxun.yang@flygoat.com> > > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > > S: Maintained > > F: tcg/mips/ > > -- > > 2.20.1 > > > > > > > > -- > Aurelien Jarno GPG: 4096R/1DDD8C9B > aurelien@aurel32.net http://www.aurel32.net > [-- Attachment #2: Type: text/html, Size: 8911 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-07-01 21:39 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-30 16:46 [PATCH v2 0/2] target mips: Misc fixes and improvements Aleksandar Markovic 2020-06-30 16:46 ` [PATCH v2 1/2] target/mips: Remove identical if/else branches Aleksandar Markovic 2020-06-30 17:22 ` Philippe Mathieu-Daudé 2020-06-30 16:46 ` [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership Aleksandar Markovic 2020-06-30 17:19 ` Philippe Mathieu-Daudé 2020-07-01 8:00 ` Philippe Mathieu-Daudé 2020-07-01 8:48 ` Philippe Mathieu-Daudé 2020-07-01 11:05 ` chen huacai 2020-07-01 13:53 ` Aleksandar Markovic 2020-07-01 15:46 ` Paolo Bonzini 2020-07-01 15:38 ` Philippe Mathieu-Daudé 2020-07-01 15:39 ` Philippe Mathieu-Daudé 2020-07-01 20:11 ` Aurelien Jarno 2020-07-01 21:37 ` Aleksandar Markovic
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).