How about using a bot to guard the pull request can be apply? like rust compiler does.

How about using a bot to guard the pull request can be apply? like rust compiler does.

[罗勇刚(Yonggang Luo)]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

Peter can @bots try to apply pull request, if pull request apply and all ci
tests passed, then the bot automatically merge the pull request and push to
the mirrors.
We even doesn't need gitlab or other things, only need the bot to monitor
the instruction from Peter.

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

[-- Attachment #2: Type: text/html, Size: 503 bytes --]

Re: How about using a bot to guard the pull request can be apply? like rust compiler does.

[Paolo Bonzini]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

We will certainly have a lot more flexibility in handling application of
patches as soon as we get closer to a gating CI.

We should first make sure that Gitlab CI (directly or through custom
runners, Travis, or cirrus-build) can cover all the scenarios and tests
that Peter has in his CI. The main missing ones are NetBSD and OpenBSD
builds, and various additional tests for warnings during builds, though
there may be more. Once we do that, imagination is the limit. :-)

Paolo

Il lun 26 ott 2020, 21:15 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> ha
scritto:

> Peter can @bots try to apply pull request, if pull request apply and all
> ci tests passed, then the bot automatically merge the pull request and push
> to the mirrors.
> We even doesn't need gitlab or other things, only need the bot to monitor
> the instruction from Peter.
>
> --
>          此致
> 礼
> 罗勇刚
> Yours
>     sincerely,
> Yonggang Luo
>

[-- Attachment #2: Type: text/html, Size: 1413 bytes --]

Re: How about using a bot to guard the pull request can be apply? like rust compiler does.

[Peter Maydell]

On Mon, 26 Oct 2020 at 20:14, 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> wrote:
>
> Peter can @bots try to apply pull request, if pull request apply and all ci tests passed, then the bot automatically merge the pull request and push to the mirrors.

This is somewhere on my list of nice-to-have-in-future
improvements to our process. You'd need to have a human
in the loop because there are things we want to review
which the CI does not catch (mostly "does this look
sensible", "is this a request from a new submitter whose
work needs a second lookthrough") but that could be done
with some similar thing to the r=whoever comments some
other projects use. Then you could have "as long as 1
(or 2 during releases) senior maintainer acks the pullreq
it goes in" rules.

But right at the moment that's half a dozen steps in the
future and we need to get the basic CI stuff working
before we start looking at changing the workflow for
submaintainers.

thanks
-- PMM