* [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
@ 2021-05-17 7:08 Philippe Mathieu-Daudé
2021-05-17 12:09 ` Bin Meng
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-17 7:08 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-riscv, qemu-trivial, Bin Meng, Richard Henderson,
Dr . David Alan Gilbert, Philippe Mathieu-Daudé,
Alistair Francis, Palmer Dabbelt
The RISCV CPU is migratable since commit f7697f0e629
("target/riscv: Add basic vmstate description of CPU"),
so remove an obsolete comment which is now incorrect.
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/riscv/cpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3191fd00822..d459e8427e2 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
cc->disas_set_info = riscv_cpu_disas_set_info;
#ifndef CONFIG_USER_ONLY
cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
- /* For now, mark unmigratable: */
cc->vmsd = &vmstate_riscv_cpu;
cc->write_elf64_note = riscv_cpu_write_elf64_note;
cc->write_elf32_note = riscv_cpu_write_elf32_note;
--
2.26.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
2021-05-17 7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
@ 2021-05-17 12:09 ` Bin Meng
2021-05-17 17:38 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2021-05-17 12:09 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: open list:RISC-V, QEMU Trivial, Bin Meng, Richard Henderson,
qemu-devel@nongnu.org Developers, Dr . David Alan Gilbert,
Alistair Francis, Palmer Dabbelt
On Mon, May 17, 2021 at 3:08 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/riscv/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
2021-05-17 7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
2021-05-17 12:09 ` Bin Meng
@ 2021-05-17 17:38 ` Richard Henderson
2021-05-17 22:38 ` Alistair Francis
2021-05-18 6:11 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-05-17 17:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-riscv, qemu-trivial, Bin Meng, Dr . David Alan Gilbert,
Alistair Francis, Palmer Dabbelt
On 5/17/21 2:08 AM, Philippe Mathieu-Daudé wrote:
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/riscv/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
2021-05-17 7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
2021-05-17 12:09 ` Bin Meng
2021-05-17 17:38 ` Richard Henderson
@ 2021-05-17 22:38 ` Alistair Francis
2021-05-18 6:11 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2021-05-17 22:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: open list:RISC-V, QEMU Trivial, Bin Meng, Richard Henderson,
qemu-devel@nongnu.org Developers, Dr . David Alan Gilbert,
Alistair Francis, Palmer Dabbelt
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
> cc->disas_set_info = riscv_cpu_disas_set_info;
> #ifndef CONFIG_USER_ONLY
> cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> - /* For now, mark unmigratable: */
> cc->vmsd = &vmstate_riscv_cpu;
> cc->write_elf64_note = riscv_cpu_write_elf64_note;
> cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
2021-05-17 7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2021-05-17 22:38 ` Alistair Francis
@ 2021-05-18 6:11 ` Alistair Francis
3 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2021-05-18 6:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: open list:RISC-V, QEMU Trivial, Bin Meng, Richard Henderson,
qemu-devel@nongnu.org Developers, Dr . David Alan Gilbert,
Alistair Francis, Palmer Dabbelt
On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> target/riscv/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
> cc->disas_set_info = riscv_cpu_disas_set_info;
> #ifndef CONFIG_USER_ONLY
> cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> - /* For now, mark unmigratable: */
> cc->vmsd = &vmstate_riscv_cpu;
> cc->write_elf64_note = riscv_cpu_write_elf64_note;
> cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-18 6:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
2021-05-17 12:09 ` Bin Meng
2021-05-17 17:38 ` Richard Henderson
2021-05-17 22:38 ` Alistair Francis
2021-05-18 6:11 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).