* [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()
@ 2021-02-28 22:48 Philippe Mathieu-Daudé
2021-03-01 17:10 ` Hao Wu
2021-03-05 11:33 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-28 22:48 UTC (permalink / raw)
To: qemu-devel
Cc: Tyrone Ting, qemu-arm, Havard Skinnemoen, Philippe Mathieu-Daudé
The STATUS register will be reset to IDLE in
cnpcm7xx_smbus_enter_reset(), no need to preset
it in instance_init().
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/i2c/npcm7xx_smbus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
index 6b2f9e1aaad..e7e0ba66fe7 100644
--- a/hw/i2c/npcm7xx_smbus.c
+++ b/hw/i2c/npcm7xx_smbus.c
@@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj)
sysbus_init_mmio(sbd, &s->iomem);
s->bus = i2c_init_bus(DEVICE(s), "i2c-bus");
- s->status = NPCM7XX_SMBUS_STATUS_IDLE;
}
static const VMStateDescription vmstate_npcm7xx_smbus = {
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()
2021-02-28 22:48 [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init() Philippe Mathieu-Daudé
@ 2021-03-01 17:10 ` Hao Wu
2021-03-05 11:33 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Hao Wu @ 2021-03-01 17:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Developers, Tyrone Ting, qemu-arm, Havard Skinnemoen
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Sun, Feb 28, 2021 at 2:50 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> The STATUS register will be reset to IDLE in
> cnpcm7xx_smbus_enter_reset(), no need to preset
> it in instance_init().
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
Reviewed-by: Hao Wu <wuhaotsh@google.com>
> ---
> hw/i2c/npcm7xx_smbus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
> index 6b2f9e1aaad..e7e0ba66fe7 100644
> --- a/hw/i2c/npcm7xx_smbus.c
> +++ b/hw/i2c/npcm7xx_smbus.c
> @@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj)
> sysbus_init_mmio(sbd, &s->iomem);
>
> s->bus = i2c_init_bus(DEVICE(s), "i2c-bus");
> - s->status = NPCM7XX_SMBUS_STATUS_IDLE;
> }
>
> static const VMStateDescription vmstate_npcm7xx_smbus = {
> --
> 2.26.2
>
>
>
[-- Attachment #2: Type: text/html, Size: 1511 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()
2021-02-28 22:48 [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init() Philippe Mathieu-Daudé
2021-03-01 17:10 ` Hao Wu
@ 2021-03-05 11:33 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2021-03-05 11:33 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Tyrone Ting, qemu-arm, QEMU Developers, Havard Skinnemoen
On Sun, 28 Feb 2021 at 22:50, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The STATUS register will be reset to IDLE in
> cnpcm7xx_smbus_enter_reset(), no need to preset
> it in instance_init().
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/i2c/npcm7xx_smbus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
> index 6b2f9e1aaad..e7e0ba66fe7 100644
> --- a/hw/i2c/npcm7xx_smbus.c
> +++ b/hw/i2c/npcm7xx_smbus.c
> @@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj)
> sysbus_init_mmio(sbd, &s->iomem);
>
> s->bus = i2c_init_bus(DEVICE(s), "i2c-bus");
> - s->status = NPCM7XX_SMBUS_STATUS_IDLE;
> }
>
> static const VMStateDescription vmstate_npcm7xx_smbus =
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-05 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 22:48 [PATCH] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init() Philippe Mathieu-Daudé
2021-03-01 17:10 ` Hao Wu
2021-03-05 11:33 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).