* [Qemu-devel] [PULL v2 00/13] TCG patch queue
@ 2016-02-09 0:01 Richard Henderson
2016-02-09 0:01 ` [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges Richard Henderson
2016-02-09 10:43 ` [Qemu-devel] [PULL v2 00/13] TCG patch queue Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Richard Henderson @ 2016-02-09 0:01 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
This adjusts the previous pull request with a new patch (6/13) to
work around a clang bug that affects -Werror. I'm not resending
any of the other patches in this pull request.
r~
The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +0000)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-tcg-20160209
for you to fetch changes up to 40ae5c62ebaaf7d9d3b93b88c2d32bf6342f7889:
tcg: Introduce temp_load (2016-02-09 10:45:34 +1100)
----------------------------------------------------------------
Queued TCG patches
----------------------------------------------------------------
Richard Henderson (13):
tcg: Respect highwater in tcg_out_tb_finalize
tcg: Remove lingering references to gen_opc_buf
tcg: Change tcg_global_mem_new_* to take a TCGv_ptr
tcg: Change ts->mem_reg to ts->mem_base
tcg: Tidy temporary allocation
tcg: Work around clang bug wrt enum ranges
tcg: More use of TCGReg where appropriate
tcg: Remove tcg_get_arg_str_i32/64
tcg: Change reg_to_temp to TCGTemp pointer
tcg: Change temp_dead argument to TCGTemp
tcg: Change temp_sync argument to TCGTemp
tcg: Change temp_save argument to TCGTemp
tcg: Introduce temp_load
target-alpha/translate.c | 8 +-
target-arm/translate-a64.c | 6 +-
target-arm/translate.c | 21 +-
target-cris/translate.c | 24 +-
target-cris/translate_v10.c | 82 +++---
target-i386/translate.c | 13 +-
target-lm32/translate.c | 24 +-
target-m68k/translate.c | 30 ++-
target-microblaze/translate.c | 18 +-
target-mips/translate.c | 25 +-
target-moxie/translate.c | 8 +-
target-openrisc/translate.c | 26 +-
target-ppc/translate.c | 44 ++--
target-s390x/translate.c | 18 +-
target-sh4/translate.c | 48 ++--
target-sparc/translate.c | 60 ++---
target-tilegx/translate.c | 4 +-
target-tricore/translate.c | 22 +-
target-unicore32/translate.c | 5 +-
target-xtensa/translate.c | 10 +-
tcg/ia64/tcg-target.c | 11 +-
tcg/tcg-be-ldst.h | 11 +-
tcg/tcg-be-null.h | 3 +-
tcg/tcg.c | 562 +++++++++++++++++++-----------------------
tcg/tcg.h | 49 ++--
25 files changed, 564 insertions(+), 568 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges
2016-02-09 0:01 [Qemu-devel] [PULL v2 00/13] TCG patch queue Richard Henderson
@ 2016-02-09 0:01 ` Richard Henderson
2016-02-09 17:48 ` Peter Maydell
2016-02-09 10:43 ` [Qemu-devel] [PULL v2 00/13] TCG patch queue Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2016-02-09 0:01 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell
A subsequent patch patch will change the type of REG from int
to enum TCGReg, which provokes the following bug in clang:
https://llvm.org/bugs/show_bug.cgi?id=16154
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
tcg/tcg.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 9a836c9..70c0cff 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -2059,9 +2059,9 @@ static void tcg_reg_alloc_op(TCGContext *s,
} else {
if (def->flags & TCG_OPF_CALL_CLOBBER) {
/* XXX: permit generic clobber register list ? */
- for(reg = 0; reg < TCG_TARGET_NB_REGS; reg++) {
- if (tcg_regset_test_reg(tcg_target_call_clobber_regs, reg)) {
- tcg_reg_free(s, reg);
+ for (i = 0; i < TCG_TARGET_NB_REGS; i++) {
+ if (tcg_regset_test_reg(tcg_target_call_clobber_regs, i)) {
+ tcg_reg_free(s, i);
}
}
}
@@ -2227,9 +2227,9 @@ static void tcg_reg_alloc_call(TCGContext *s, int nb_oargs, int nb_iargs,
}
/* clobber call registers */
- for(reg = 0; reg < TCG_TARGET_NB_REGS; reg++) {
- if (tcg_regset_test_reg(tcg_target_call_clobber_regs, reg)) {
- tcg_reg_free(s, reg);
+ for (i = 0; i < TCG_TARGET_NB_REGS; i++) {
+ if (tcg_regset_test_reg(tcg_target_call_clobber_regs, i)) {
+ tcg_reg_free(s, i);
}
}
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/13] TCG patch queue
2016-02-09 0:01 [Qemu-devel] [PULL v2 00/13] TCG patch queue Richard Henderson
2016-02-09 0:01 ` [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges Richard Henderson
@ 2016-02-09 10:43 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-02-09 10:43 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On 9 February 2016 at 00:01, Richard Henderson <rth@twiddle.net> wrote:
> This adjusts the previous pull request with a new patch (6/13) to
> work around a clang bug that affects -Werror. I'm not resending
> any of the other patches in this pull request.
>
>
> r~
>
>
> The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>
> ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +0000)
>
> are available in the git repository at:
>
> git://github.com/rth7680/qemu.git tags/pull-tcg-20160209
>
> for you to fetch changes up to 40ae5c62ebaaf7d9d3b93b88c2d32bf6342f7889:
>
> tcg: Introduce temp_load (2016-02-09 10:45:34 +1100)
>
> ----------------------------------------------------------------
> Queued TCG patches
>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges
2016-02-09 0:01 ` [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges Richard Henderson
@ 2016-02-09 17:48 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-02-09 17:48 UTC (permalink / raw)
To: Richard Henderson; +Cc: QEMU Developers
On 9 February 2016 at 00:01, Richard Henderson <rth@twiddle.net> wrote:
> A subsequent patch patch will change the type of REG from int
> to enum TCGReg, which provokes the following bug in clang:
>
> https://llvm.org/bugs/show_bug.cgi?id=16154
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> tcg/tcg.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
It turns out there's another one of these at line 1610
in check_regs(), which I didn't notice in my pre-build
tests because that function is only used ifndef NDEBUG,
and my clang builds both happen to be non-debug builds.
It shows up in travis build logs though:
https://travis-ci.org/qemu/qemu/jobs/108065058
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-09 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 0:01 [Qemu-devel] [PULL v2 00/13] TCG patch queue Richard Henderson
2016-02-09 0:01 ` [Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges Richard Henderson
2016-02-09 17:48 ` Peter Maydell
2016-02-09 10:43 ` [Qemu-devel] [PULL v2 00/13] TCG patch queue Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).