From: Peter Maydell <peter.maydell@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: "Alessandro Di Federico" <ale@rev.ng>,
"Richard Henderson" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Niccolò Izzo" <izzoniccolo@gmail.com>,
"nizzo@rev.ng" <nizzo@rev.ng>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>
Subject: Re: QEMU for Qualcomm Hexagon - KVM Forum talk and code available
Date: Tue, 17 Dec 2019 18:21:15 +0000 [thread overview]
Message-ID: <CAFEAcA-TpZfqbWjGX-tD0Osapt_K4yuTBg6+B=ZxU4MuVr7omg@mail.gmail.com> (raw)
In-Reply-To: <BYAPR02MB488640DD7CC887E5FCC0F167DE500@BYAPR02MB4886.namprd02.prod.outlook.com>
On Tue, 17 Dec 2019 at 18:16, Taylor Simpson <tsimpson@quicinc.com> wrote:
> Question 1:
> I see this error from checkpatch.pl
> ERROR: Macros with complex values should be enclosed in parenthesis
> However, there are times when the code will not compile with parenthesis. For example, we have a file that defined all the instruction attributes. Each line has
> DEF_ATTRIB(LOAD, "Loads from memory", "", "")
> So, we create an enum of all the possible attributes as follows
> enum {
> #define DEF_ATTRIB(NAME, ...) A_##NAME,
> #include "attribs_def.h"
> #undef DEF_ATTRIB
> };
checkpatch is often right, but also often wrong,
especially for C macros which are in the general case
impossible to parse. If the error makes no sense, you can
ignore it.
> Question 2:
> What is the best source of guidance on breaking down support for a new target into a patch series?
Look at how previous ports did it. Also I thought we'd
had a subthread on how best to split things up, but maybe I'm
misremembering.
> I see avr being reviewed currently. I have mostly new files: 12 in linux-user/hexagon, and ~50 in target/hexagon. I also need to add test cases and a container for the toolchain. Is it OK to break things down mostly at file boundaries?
No, file boundaries are generally a bad choice of breakdown.
You want to split at conceptual boundaries, ie one chunk
of functionality that can be comprehended in one go without
having to refer forward to other patches.
thanks
-- PMM
next prev parent reply other threads:[~2019-12-17 18:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 16:26 QEMU for Qualcomm Hexagon - KVM Forum talk and code available Taylor Simpson
2019-11-01 18:29 ` Philippe Mathieu-Daudé
2019-11-04 2:35 ` Taylor Simpson
2019-11-05 0:05 ` Aleksandar Markovic
2019-11-05 16:32 ` Taylor Simpson
2019-11-12 22:52 ` Taylor Simpson
2019-11-13 10:31 ` Alex Bennée
2019-11-13 19:31 ` Taylor Simpson
2019-11-13 21:10 ` Richard Henderson
2019-11-15 0:54 ` Taylor Simpson
2019-12-17 18:14 ` Taylor Simpson
2019-12-17 18:19 ` Thomas Huth
2019-12-17 18:21 ` Peter Maydell [this message]
2019-12-17 18:41 ` Philippe Mathieu-Daudé
2019-12-17 18:44 ` Philippe Mathieu-Daudé
2019-12-18 23:50 ` Richard Henderson
2019-11-13 21:27 ` Peter Maydell
2019-11-19 9:12 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-TpZfqbWjGX-tD0Osapt_K4yuTBg6+B=ZxU4MuVr7omg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=ale@rev.ng \
--cc=aleksandar.m.mail@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=izzoniccolo@gmail.com \
--cc=nizzo@rev.ng \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).