Re: [Qemu-devel] [PATCH] modules-test: fix const cast

[Peter Maydell <peter.maydell@linaro.org>]

On Tue, 27 Aug 2019 at 14:39, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > On 23/08/19 14:07, Peter Maydell wrote:
> > > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> > > >> not built as module" to qemu.git directly?
> > > > Is the other one also needed as a build fix ?
> > >
> > > Yes, otherwise the test fails (it didn't fail in the meson tree).
> >
> > Both this fix and the ui-spice-app one are now in master, but
> > the 'enable-modules' Travis build still seems to be consistently
> > failing -- could somebody take a look, please?
> >
>
> I am looking at, it seems to be related to default machine
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64
> QTEST_QEMU_IMG=qemu-img tests/modules-test -m=quick -k --tap <
> /dev/null | ./scripts/tap-driver.pl --test-name="modules-test"
>
> qemu-system-aarch64: -machine accel=qtest: No machine specified, and
> there is no default
>
> Use -machine help to list supported machines

Yeah, you need a machine type. If you need to run code on the
QEMU instance you need to know what machine type you're expecting;
if you aren't and you're just doing qtest stuff then -machine none
may be appropriate.

thanks
-- PMM