From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] modules-test: fix const cast
Date: Fri, 23 Aug 2019 13:07:37 +0100 [thread overview]
Message-ID: <CAFEAcA81qUSMqpMTCrs9-vgj7Wmji2dCDkYrQ91wxmhTiP83Xw@mail.gmail.com> (raw)
In-Reply-To: <dd473e9b-716d-cd9f-47bd-433d2b17687d@redhat.com>
On Fri, 23 Aug 2019 at 13:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 23/08/19 11:11, Peter Maydell wrote:
> > On Fri, 23 Aug 2019 at 10:06, Thomas Huth <thuth@redhat.com> wrote:
> >>
> >> On 8/22/19 7:42 PM, Paolo Bonzini wrote:
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>> ---
> >>> tests/modules-test.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/tests/modules-test.c b/tests/modules-test.c
> >>> index 3aef0e5..a8118e9 100644
> >>> --- a/tests/modules-test.c
> >>> +++ b/tests/modules-test.c
> >>> @@ -4,7 +4,7 @@
> >>> static void test_modules_load(const void *data)
> >>> {
> >>> QTestState *qts;
> >>> - const char **args = data;
> >>> + const char **args = (const char **)data;
> >>>
> >>> qts = qtest_init(NULL);
> >>> qtest_module_load(qts, args[0], args[1]);
> >>
> >> Why did nobody notice this before? ... some additional words in the
> >> patch description would be fine.
> >
> > It got into the tree because I don't have an --enable-modules
> > config in my set of things I run before merging. It's in
> > the Travis build set, but that only runs after the fact.
>
> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> not built as module" to qemu.git directly?
Is the other one also needed as a build fix ?
I was planning to apply this one directly, yes, but I was
waiting to see if you and Thomas wanted to agree any change
to the commit message.
thanks
-- PMM
next prev parent reply other threads:[~2019-08-23 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
2019-08-23 9:06 ` Thomas Huth
2019-08-23 9:11 ` Peter Maydell
2019-08-23 12:04 ` Paolo Bonzini
2019-08-23 12:07 ` Peter Maydell [this message]
2019-08-23 12:10 ` Paolo Bonzini
2019-08-23 12:11 ` Thomas Huth
2019-08-27 12:00 ` Peter Maydell
2019-08-27 13:38 ` Marc-André Lureau
2019-08-27 14:26 ` Peter Maydell
2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA81qUSMqpMTCrs9-vgj7Wmji2dCDkYrQ91wxmhTiP83Xw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).