* [PATCH] iotests: Remove 130 from the "auto" group
@ 2019-10-18 16:10 Thomas Huth
2019-10-18 16:51 ` Bruce Rogers
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Thomas Huth @ 2019-10-18 16:10 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel
Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?"
error with 130 already twice. Looks like this test is a little bit
shaky, and currently nobody has a real clue what could be causing this
issue, so for the time being, let's disable it from the "auto" group so
that it does not gate the pull requests.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index 7dac79a783..6aa4b8d098 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -151,7 +151,7 @@
127 rw backing quick
128 rw quick
129 rw quick
-130 rw auto quick
+130 rw quick
131 rw quick
132 rw quick
133 auto quick
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] iotests: Remove 130 from the "auto" group
2019-10-18 16:10 [PATCH] iotests: Remove 130 from the "auto" group Thomas Huth
@ 2019-10-18 16:51 ` Bruce Rogers
2019-10-21 13:37 ` Thomas Huth
2019-10-18 21:10 ` John Snow
2019-10-29 14:05 ` Max Reitz
2 siblings, 1 reply; 6+ messages in thread
From: Bruce Rogers @ 2019-10-18 16:51 UTC (permalink / raw)
To: mreitz, thuth, qemu-block; +Cc: kwolf, peter.maydell, qemu-devel
On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote:
> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
> 'write' lock - Is another process using the image
> [TEST_DIR/t.IMGFMT]?"
> error with 130 already twice. Looks like this test is a little bit
> shaky, and currently nobody has a real clue what could be causing
> this
> issue, so for the time being, let's disable it from the "auto" group
> so
> that it does not gate the pull requests.
>
For some time I've also needed to work around issues running 130. I
either disabled it, or I found a few properly placed sleeps got it to
reliably pass. Last week I finally got around to investigating it a bit
more and discovered that the failure was related to my using --enable-
membarrier in my configure.
I didn't investigate whether the block io tests' _cleanup_qemu using
kill -KILL was being relied on in some way by some tests, or if that is
simply a way to speed the testing along, or what, but I've gotten test
130 to reliably pass by changing the test to quit properly via the
monitor, and by adding a wait=1 so that _cleanup_qemu doesn't simply
kill qemu.
I believe 153 and 161 also suffer in a similar way.
I haven't gotten around to fully understanding how qemu's using the
kernel sys_membarrier is adversly affected by killing qemu in this way,
but it seems there's an issue with that.
Hopefully someone who is more familiar with qemu's use of membarrier's
can add more details here.
Bruce
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iotests: Remove 130 from the "auto" group
2019-10-18 16:10 [PATCH] iotests: Remove 130 from the "auto" group Thomas Huth
2019-10-18 16:51 ` Bruce Rogers
@ 2019-10-18 21:10 ` John Snow
2019-10-29 14:05 ` Max Reitz
2 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2019-10-18 21:10 UTC (permalink / raw)
To: Thomas Huth, Max Reitz, qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel
On 10/18/19 12:10 PM, Thomas Huth wrote:
> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
> 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?"
> error with 130 already twice. Looks like this test is a little bit
> shaky, and currently nobody has a real clue what could be causing this
> issue, so for the time being, let's disable it from the "auto" group so
> that it does not gate the pull requests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 7dac79a783..6aa4b8d098 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -151,7 +151,7 @@
> 127 rw backing quick
> 128 rw quick
> 129 rw quick
> -130 rw auto quick
> +130 rw quick
> 131 rw quick
> 132 rw quick
> 133 auto quick
>
--
—js
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iotests: Remove 130 from the "auto" group
2019-10-18 16:51 ` Bruce Rogers
@ 2019-10-21 13:37 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2019-10-21 13:37 UTC (permalink / raw)
To: Bruce Rogers, mreitz, qemu-block; +Cc: kwolf, peter.maydell, qemu-devel
On 18/10/2019 18.51, Bruce Rogers wrote:
> On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote:
>> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
>> 'write' lock - Is another process using the image
>> [TEST_DIR/t.IMGFMT]?"
>> error with 130 already twice. Looks like this test is a little bit
>> shaky, and currently nobody has a real clue what could be causing
>> this
>> issue, so for the time being, let's disable it from the "auto" group
>> so
>> that it does not gate the pull requests.
>>
>
> For some time I've also needed to work around issues running 130. I
> either disabled it, or I found a few properly placed sleeps got it to
> reliably pass. Last week I finally got around to investigating it a bit
> more and discovered that the failure was related to my using --enable-
> membarrier in my configure.
>
> I didn't investigate whether the block io tests' _cleanup_qemu using
> kill -KILL was being relied on in some way by some tests, or if that is
> simply a way to speed the testing along, or what, but I've gotten test
> 130 to reliably pass by changing the test to quit properly via the
> monitor, and by adding a wait=1 so that _cleanup_qemu doesn't simply
> kill qemu.
>
> I believe 153 and 161 also suffer in a similar way.
Ok, thanks for the heads-up! 153 is not in the "auto" group, but 161 is,
so we definitely keep that in mind if we see failure here...
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iotests: Remove 130 from the "auto" group
2019-10-18 16:10 [PATCH] iotests: Remove 130 from the "auto" group Thomas Huth
2019-10-18 16:51 ` Bruce Rogers
2019-10-18 21:10 ` John Snow
@ 2019-10-29 14:05 ` Max Reitz
2019-10-31 12:29 ` Peter Maydell
2 siblings, 1 reply; 6+ messages in thread
From: Max Reitz @ 2019-10-29 14:05 UTC (permalink / raw)
To: Thomas Huth, qemu-block; +Cc: Kevin Wolf, Peter Maydell, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]
On 18.10.19 18:10, Thomas Huth wrote:
> Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
> 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?"
> error with 130 already twice. Looks like this test is a little bit
> shaky, and currently nobody has a real clue what could be causing this
> issue, so for the time being, let's disable it from the "auto" group so
> that it does not gate the pull requests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] iotests: Remove 130 from the "auto" group
2019-10-29 14:05 ` Max Reitz
@ 2019-10-31 12:29 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2019-10-31 12:29 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, Thomas Huth, QEMU Developers, Qemu-block
On Tue, 29 Oct 2019 at 14:05, Max Reitz <mreitz@redhat.com> wrote:
>
> On 18.10.19 18:10, Thomas Huth wrote:
> > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared
> > 'write' lock - Is another process using the image [TEST_DIR/t.IMGFMT]?"
> > error with 130 already twice. Looks like this test is a little bit
> > shaky, and currently nobody has a real clue what could be causing this
> > issue, so for the time being, let's disable it from the "auto" group so
> > that it does not gate the pull requests.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > tests/qemu-iotests/group | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks, applied to my block branch:
>
> https://github.com/XanClic/qemu/commits/block
I ran into this intermittent-on-s390 again this morning, so
I've applied it to master in an attempt to improve the
reliabliity of my merge testing. (The other current culprit
for intermittent failures seems to be the various BSD
builds for non-iotest reasons.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-31 12:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 16:10 [PATCH] iotests: Remove 130 from the "auto" group Thomas Huth
2019-10-18 16:51 ` Bruce Rogers
2019-10-21 13:37 ` Thomas Huth
2019-10-18 21:10 ` John Snow
2019-10-29 14:05 ` Max Reitz
2019-10-31 12:29 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).