From: Peter Maydell <peter.maydell@linaro.org>
To: Aurelio Remonda <aurelio.remonda@tallertechnologies.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Memory on stellaris board
Date: Fri, 5 Feb 2016 16:23:41 +0000 [thread overview]
Message-ID: <CAFEAcA8ZJjDnFCYMG0aidhAb4obfbBTYy5oJ60e0pQqfBCoG=w@mail.gmail.com> (raw)
In-Reply-To: <CANLssssdY6UFZozNtajrjuZpH4vWRMSCp4BDNuSXjGVfATsY4w@mail.gmail.com>
On 5 February 2016 at 16:09, Aurelio Remonda
<aurelio.remonda@tallertechnologies.com> wrote:
> Hello, im working on this feature right now.
> i have a working patch but maybe I can make some changes to make it look better:
> for example in some point i check ram_size like this:
> if (ram_size == 0x8000000)
> Maybe if i make ram_addr_t default_ram_size global (is a local
> variable of set_memory_options function)
> i can use it instead of hardcoded 0x8000000.
No, don't do that.
Why do you care about whether the ram size is the default or not?
thanks
-- PMM
next prev parent reply other threads:[~2016-02-05 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 13:00 [Qemu-devel] Memory on stellaris board Aurelio Remonda
2016-02-03 13:34 ` Peter Maydell
2016-02-03 13:45 ` Aurelio Remonda
2016-02-05 16:09 ` Aurelio Remonda
2016-02-05 16:23 ` Peter Maydell [this message]
2016-02-05 16:55 ` Aurelio Remonda
2016-02-05 17:00 ` Peter Maydell
2016-02-11 12:46 ` Aurelio Remonda
2016-02-11 13:01 ` Peter Maydell
2016-03-07 19:58 ` Aurelio Remonda
2016-03-07 23:37 ` Peter Maydell
2016-03-09 20:56 ` Aurelio Remonda
2016-03-09 23:24 ` Peter Maydell
2016-03-10 0:23 ` Aurelio Remonda
2016-03-10 1:54 ` Peter Maydell
2016-03-11 14:12 ` Aurelio Remonda
2016-03-11 22:31 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA8ZJjDnFCYMG0aidhAb4obfbBTYy5oJ60e0pQqfBCoG=w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aurelio.remonda@tallertechnologies.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).