From: Peter Maydell <peter.maydell@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Beata Michalska <beata.michalska@linaro.org>
Subject: Re: [PATCH 2/3] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init
Date: Tue, 21 Jul 2020 11:02:30 +0100 [thread overview]
Message-ID: <CAFEAcA93VMoQxPSvk7YNkkbXhrFufuFN8R9Sqjj6C97Xz2buvA@mail.gmail.com> (raw)
In-Reply-To: <20200711101033.47371-3-drjones@redhat.com>
On Sat, 11 Jul 2020 at 11:10, Andrew Jones <drjones@redhat.com> wrote:
>
> Move the KVM PMU setup part of fdt_add_pmu_nodes() to
> virt_cpu_post_init(), which is a more appropriate location. Now
> fdt_add_pmu_nodes() is also named more appropriately, because it
> no longer does anything but fdt node creation.
>
> No functional change intended.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> hw/arm/virt.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index cb2fa99b1ef5..63ef530933e5 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -521,30 +521,15 @@ static void fdt_add_gic_node(VirtMachineState *vms)
>
> static void fdt_add_pmu_nodes(const VirtMachineState *vms)
> {
> - CPUState *cpu;
> - ARMCPU *armcpu;
> + ARMCPU *armcpu = ARM_CPU(first_cpu);
> uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI;
>
> - CPU_FOREACH(cpu) {
> - armcpu = ARM_CPU(cpu);
> - if (!arm_feature(&armcpu->env, ARM_FEATURE_PMU)) {
> - return;
> - }
So previously we would say "if the CPU doesn't actually have
a PMU, don't put the PMU nodes in the FDT", but in the new logic
it looks like we put the PMU nodes in the FDT unconditionally ?
> - if (kvm_enabled()) {
> - if (kvm_irqchip_in_kernel()) {
> - kvm_arm_pmu_set_irq(cpu, PPI(VIRTUAL_PMU_IRQ));
> - }
> - kvm_arm_pmu_init(cpu);
> - }
> - }
> -
> if (vms->gic_version == VIRT_GIC_VERSION_2) {
> irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START,
> GIC_FDT_IRQ_PPI_CPU_WIDTH,
> (1 << vms->smp_cpus) - 1);
> }
>
> - armcpu = ARM_CPU(qemu_get_cpu(0));
> qemu_fdt_add_subnode(vms->fdt, "/pmu");
> if (arm_feature(&armcpu->env, ARM_FEATURE_V8)) {
> const char compat[] = "arm,armv8-pmuv3";
> @@ -1678,11 +1663,23 @@ static void finalize_gic_version(VirtMachineState *vms)
> */
> static void virt_cpu_post_init(VirtMachineState *vms)
> {
> - bool aarch64;
> + bool aarch64, pmu;
> + CPUState *cpu;
>
> aarch64 = object_property_get_bool(OBJECT(first_cpu), "aarch64", NULL);
> + pmu = object_property_get_bool(OBJECT(first_cpu), "pmu", NULL);
>
> - if (!kvm_enabled()) {
> + if (kvm_enabled()) {
> + CPU_FOREACH(cpu) {
> + if (pmu) {
> + assert(arm_feature(&ARM_CPU(cpu)->env, ARM_FEATURE_PMU));
> + if (kvm_irqchip_in_kernel()) {
> + kvm_arm_pmu_set_irq(cpu, PPI(VIRTUAL_PMU_IRQ));
> + }
> + kvm_arm_pmu_init(cpu);
> + }
> + }
> + } else {
> if (aarch64 && vms->highmem) {
> int requested_pa_size = 64 - clz64(vms->highest_gpa);
> int pamax = arm_pamax(ARM_CPU(first_cpu));
thanks
-- PMM
next prev parent reply other threads:[~2020-07-21 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 10:10 [PATCH 0/3] hw/arm/virt: Introduce kvm-steal-time Andrew Jones
2020-07-11 10:10 ` [PATCH 1/3] hw/arm/virt: Move post cpu realize check into its own function Andrew Jones
2020-07-21 10:03 ` Peter Maydell
2020-07-11 10:10 ` [PATCH 2/3] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init Andrew Jones
2020-07-21 10:02 ` Peter Maydell [this message]
2020-07-29 13:51 ` Andrew Jones
2020-07-11 10:10 ` [PATCH 3/3] hw/arm/virt: Implement kvm-steal-time Andrew Jones
2020-07-21 10:46 ` Peter Maydell
2020-07-29 14:40 ` Andrew Jones
2020-08-03 15:18 ` Andrew Jones
2020-07-31 14:54 ` Peter Maydell
2020-08-01 12:00 ` Andrew Jones
2020-08-03 15:16 ` Andrew Jones
2020-07-20 10:16 ` [PATCH 0/3] hw/arm/virt: Introduce kvm-steal-time Peter Maydell
2020-07-27 8:33 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA93VMoQxPSvk7YNkkbXhrFufuFN8R9Sqjj6C97Xz2buvA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=beata.michalska@linaro.org \
--cc=drjones@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).