* [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
@ 2021-01-28 13:56 Stefan Weil
2021-01-28 14:13 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Weil @ 2021-01-28 13:56 UTC (permalink / raw)
To: Alex Bennée; +Cc: Stefan Weil, Philippe Mathieu-Daudé, qemu-devel
/bin/true is missing on macOS, but simply "true" is available as a shell builtin.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
A similar change might be needed for tests/qemu-iotests.
Regards,
Stefan
tests/tcg/Makefile.qemu | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/tcg/Makefile.qemu b/tests/tcg/Makefile.qemu
index c096c611a2..a56564660c 100644
--- a/tests/tcg/Makefile.qemu
+++ b/tests/tcg/Makefile.qemu
@@ -90,11 +90,11 @@ run-guest-tests: guest-tests
else
guest-tests:
- $(call quiet-command, /bin/true, "BUILD", \
+ $(call quiet-command, true, "BUILD", \
"$(TARGET) guest-tests SKIPPED")
run-guest-tests:
- $(call quiet-command, /bin/true, "RUN", \
+ $(call quiet-command, true, "RUN", \
"tests for $(TARGET) SKIPPED")
endif
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
2021-01-28 13:56 [PATCH] tests/tcg: Replace /bin/true by true (required on macOS) Stefan Weil
@ 2021-01-28 14:13 ` Philippe Mathieu-Daudé
2021-01-28 14:26 ` Peter Maydell
2021-01-29 15:45 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-28 14:13 UTC (permalink / raw)
To: Stefan Weil, Alex Bennée; +Cc: qemu-devel
On 1/28/21 2:56 PM, Stefan Weil wrote:
> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> A similar change might be needed for tests/qemu-iotests.
>
> Regards,
> Stefan
>
> tests/tcg/Makefile.qemu | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
2021-01-28 13:56 [PATCH] tests/tcg: Replace /bin/true by true (required on macOS) Stefan Weil
2021-01-28 14:13 ` Philippe Mathieu-Daudé
@ 2021-01-28 14:26 ` Peter Maydell
2021-01-29 15:45 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2021-01-28 14:26 UTC (permalink / raw)
To: Stefan Weil
Cc: Alex Bennée, Philippe Mathieu-Daudé, QEMU Developers
On Thu, 28 Jan 2021 at 13:59, Stefan Weil <sw@weilnetz.de> wrote:
>
> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
It's also in /usr/bin/true if you happen to need a real
executable rather than a builtin. Either way we shouldn't
be hardcoding the path here.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/tcg: Replace /bin/true by true (required on macOS)
2021-01-28 13:56 [PATCH] tests/tcg: Replace /bin/true by true (required on macOS) Stefan Weil
2021-01-28 14:13 ` Philippe Mathieu-Daudé
2021-01-28 14:26 ` Peter Maydell
@ 2021-01-29 15:45 ` Alex Bennée
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2021-01-29 15:45 UTC (permalink / raw)
To: Stefan Weil; +Cc: Philippe Mathieu-Daudé, qemu-devel
Stefan Weil <sw@weilnetz.de> writes:
> /bin/true is missing on macOS, but simply "true" is available as a shell builtin.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-29 15:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 13:56 [PATCH] tests/tcg: Replace /bin/true by true (required on macOS) Stefan Weil
2021-01-28 14:13 ` Philippe Mathieu-Daudé
2021-01-28 14:26 ` Peter Maydell
2021-01-29 15:45 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).