From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: aurelien@aurel32.net, aleksandar.rikalo@rt-rk.com,
QEMU Developers <qemu-devel@nongnu.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions
Date: Wed, 25 Mar 2020 12:44:16 +0200 [thread overview]
Message-ID: <CAHiYmc7R_Y7s5DaVHf=0rkxf7N2qTSLXdTdL_vy6mH+hVdwLqA@mail.gmail.com> (raw)
In-Reply-To: <aa622b1d-e28a-c3f1-d18a-73e8a67c8ccf@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
16:59 Uto, 24.03.2020. Richard Henderson <richard.henderson@linaro.org> је
написао/ла:
>
> On 3/24/20 5:22 AM, Jiaxun Yang wrote:
> > Loongson multimedia condition instructions were previously implemented
as
> > write 0 to rd due to lack of documentation. So I just confirmed with
Loongson
> > about their encoding and implemented them correctly.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Acked-by: Huacai Chen <chenhc@lemote.com>
> > ---
> > v1: Use deposit opreations according to Richard's suggestion.
> > ---
> > target/mips/translate.c | 35 +++++++++++++++++++++++++++++++----
> > 1 file changed, 31 insertions(+), 4 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
I just have a couple of mon-essential suggestions wrt coding style, but
since all that is really of very insignificant nauture, I wouldn't even
mention them.
Reviewed-by: Aleksandar Markovic <aleksandar.qemi.devel@gmail.com>
May I ask you, Richard, to select this patch for your next TCG-for-5.0
queue, so that I don't go through a MIPS queue process for just a single
patch?
Thanks to all involved people!
Aleksandar
>
> r~
[-- Attachment #2: Type: text/html, Size: 1769 bytes --]
next prev parent reply other threads:[~2020-03-25 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 12:22 [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions Jiaxun Yang
2020-03-24 14:59 ` Richard Henderson
2020-03-25 10:44 ` Aleksandar Markovic [this message]
2020-03-25 10:47 ` Aleksandar Markovic
2020-03-25 11:13 ` Aleksandar Markovic
2020-03-26 1:30 ` Richard Henderson
2020-03-27 12:46 ` Aleksandar Markovic
2020-03-24 16:56 ` Aleksandar Markovic
2020-03-24 17:08 ` Jiaxun Yang
2020-03-24 17:26 ` Aleksandar Markovic
2020-03-30 15:39 ` Philippe Mathieu-Daudé
2020-03-30 16:18 ` Jiaxun Yang
2020-03-30 16:22 ` Philippe Mathieu-Daudé
2020-03-30 16:30 ` Jiaxun Yang
2020-03-30 19:01 ` Aleksandar Markovic
2020-04-01 14:36 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHiYmc7R_Y7s5DaVHf=0rkxf7N2qTSLXdTdL_vy6mH+hVdwLqA@mail.gmail.com' \
--to=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).