From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 00/14] ui: build spice and opengl as module.
Date: Tue, 20 Oct 2020 13:59:15 +0400 [thread overview]
Message-ID: <CAJ+F1CJXt-RLCh5uezLVah4-Mmg1V5Uxx5UaP84Jm4FV1DwGGQ@mail.gmail.com> (raw)
In-Reply-To: <20201019075224.14803-1-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]
Hi
On Mon, Oct 19, 2020 at 12:06 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> - Add QemuSpiceOps, reorganize spice stubs.
> - Add support for module dependencies.
> - Build spice-core modular, and make the existing spice
> modules (audio, chardev, qxl) depend on spice-core.
> - Build egl-headless display and opengl helpers modular
> (pretty easy thanks to module dependencies).
>
> Gerd Hoffmann (14):
> spice: add module helpers
> spice: add QemuSpiceOps, move migrate_info
> spice: move qemu_spice_init() to QemuSpiceOps.
> spice: move display_init() to QemuSpiceOps.
> spice: move add_interface() to QemuSpiceOps.
> spice: move auth functions to QemuSpiceOps.
> spice: move display_add_client() to QemuSpiceOps.
> spice: wire up monitor in QemuSpiceOps.
> spice: load module when enabled on the cmdline
> modules: dependencies infrastructure
> modules: add spice dependencies
> spice: flip modules switch
> opengl: build egl-headless display modular
> opengl: build opengl helper code modular
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
thanks!
> include/ui/qemu-spice-module.h | 44 ++++++++++++++++++
> include/ui/qemu-spice.h | 42 +----------------
> audio/spiceaudio.c | 4 +-
> chardev/spice.c | 2 +-
> monitor/misc.c | 2 +-
> monitor/qmp-cmds.c | 6 +--
> softmmu/vl.c | 10 ++--
> ui/spice-core.c | 31 +++++++++----
> ui/spice-input.c | 6 +--
> ui/spice-module.c | 85 ++++++++++++++++++++++++++++++++++
> util/module.c | 44 ++++++++++++++++--
> ui/meson.build | 28 +++++++++--
> 12 files changed, 232 insertions(+), 72 deletions(-)
> create mode 100644 include/ui/qemu-spice-module.h
> create mode 100644 ui/spice-module.c
>
> --
> 2.27.0
>
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2794 bytes --]
next prev parent reply other threads:[~2020-10-20 10:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 7:52 [PATCH 00/14] ui: build spice and opengl as module Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 01/14] spice: add module helpers Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 02/14] spice: add QemuSpiceOps, move migrate_info Gerd Hoffmann
2020-10-19 10:17 ` Dr. David Alan Gilbert
2020-10-19 7:52 ` [PATCH 03/14] spice: move qemu_spice_init() to QemuSpiceOps Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 04/14] spice: move display_init() " Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 05/14] spice: move add_interface() " Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 06/14] spice: move auth functions " Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 07/14] spice: move display_add_client() " Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 08/14] spice: wire up monitor in QemuSpiceOps Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 09/14] spice: load module when enabled on the cmdline Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 10/14] modules: dependencies infrastructure Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 11/14] modules: add spice dependencies Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 12/14] spice: flip modules switch Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 13/14] opengl: build egl-headless display modular Gerd Hoffmann
2020-10-19 7:52 ` [PATCH 14/14] opengl: build opengl helper code modular Gerd Hoffmann
2020-10-20 9:59 ` Marc-André Lureau [this message]
2020-10-26 16:27 ` [PATCH 00/14] ui: build spice and opengl as module Bruce Rogers
2020-10-27 5:58 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+F1CJXt-RLCh5uezLVah4-Mmg1V5Uxx5UaP84Jm4FV1DwGGQ@mail.gmail.com \
--to=marcandre.lureau@gmail.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).