qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Doug Evans <dje@google.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/2] Add ipv6 hostfwd support
Date: Fri, 22 Jan 2021 00:40:06 +0400	[thread overview]
Message-ID: <CAJ+F1CKrzGunuhDRfNfei4PaaVuHDUYyTS2QNJ8+-wFvOSEU4w@mail.gmail.com> (raw)
In-Reply-To: <CADPb22R9c+e1i-3CYWOc=U9Yr+F=86=T3sZ2p3jBNrn9m2kwGg@mail.gmail.com>

Hi Doug

On Fri, Jan 22, 2021 at 12:29 AM Doug Evans <dje@google.com> wrote:
>
> On Thu, Jan 21, 2021 at 1:41 AM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:
>>
>> Hi Doug,
>>
>> On Thu, Jan 21, 2021 at 12:24 PM dje--- via <qemu-devel@nongnu.org> wrote:
>> >
>> > Hi. This patchset takes the original patch from Maxim,
>> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html
>> > and updates it.
>> >
>> > The first patch is the slirp additions, the second patch adds the u/i.
>>
>> libslirp is maintained on gitlab. Can you open a merge request?
>> https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests
>>
>> thanks
>
>
>
> Hi. Sure, no problem.
> I wasn't sure what the procedure is but figured it would come out during the review.
> How does review of libslirp patches work?

We do the reviews on the gitlab MR (of the individual patches).

> I gather Samuel is a libslirp maintainer so I'm guessing it just needs to be approved here (after appropriate review) and then afterwards I should file the merge request?

Any of the libslirp maintainer can merge after reviews (including me).

Then anybody can propose a patch to update libslirp in qemu, get
reviews/comments, and Samuel can send the pull request. Sometimes
someone else sends it.

Note that libslirp is packaged in a number of distributions these days
(https://repology.org/project/libslirp/versions), and that qemu may
link to it depending on how it is built.


      reply	other threads:[~2021-01-21 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  8:23 [PATCH 0/2] Add ipv6 hostfwd support dje--- via
2021-01-21  8:23 ` [PATCH 1/2] slirp: " dje--- via
2021-01-21  8:23 ` [PATCH 2/2] net: Add ipv6_hostfwd option dje--- via
2021-01-21 22:30   ` Eric Blake
2021-01-21  9:41 ` [PATCH 0/2] Add ipv6 hostfwd support Marc-André Lureau
2021-01-21 20:28   ` dje--- via
2021-01-21 20:40     ` Marc-André Lureau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+F1CKrzGunuhDRfNfei4PaaVuHDUYyTS2QNJ8+-wFvOSEU4w@mail.gmail.com \
    --to=marcandre.lureau@gmail.com \
    --cc=dje@google.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).