From: Eric Blake <eblake@redhat.com>
To: Doug Evans <dje@google.com>, qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH 2/2] net: Add ipv6_hostfwd option
Date: Thu, 21 Jan 2021 16:30:11 -0600 [thread overview]
Message-ID: <bb027c55-c54c-cc10-23d2-637fbef9632f@redhat.com> (raw)
In-Reply-To: <20210121082314.458600-3-dje@google.com>
On 1/21/21 2:23 AM, dje--- via wrote:
> Signed-off-by: Doug Evans <dje@google.com>
> ---
Rather light on the commit message description. The one-line summary
does a good job of saying "what" the commit does, but the rest of the
commit body should say "why" the commit is worthwhile, rather than being
silent.
> hmp-commands.hx | 29 ++++-
> include/net/slirp.h | 2 +
> net/slirp.c | 311 +++++++++++++++++++++++++++++++++++---------
> qapi/net.json | 1 +
> slirp | 2 +-
> 5 files changed, 279 insertions(+), 66 deletions(-)
>
> +++ b/qapi/net.json
> @@ -189,6 +189,7 @@
> '*smb': 'str',
> '*smbserver': 'str',
> '*hostfwd': ['String'],
> + '*ipv6-hostfwd': ['String'],
Missing documentation, including a 'since 6.0' tag on the new member.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-21 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 8:23 [PATCH 0/2] Add ipv6 hostfwd support dje--- via
2021-01-21 8:23 ` [PATCH 1/2] slirp: " dje--- via
2021-01-21 8:23 ` [PATCH 2/2] net: Add ipv6_hostfwd option dje--- via
2021-01-21 22:30 ` Eric Blake [this message]
2021-01-21 9:41 ` [PATCH 0/2] Add ipv6 hostfwd support Marc-André Lureau
2021-01-21 20:28 ` dje--- via
2021-01-21 20:40 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb027c55-c54c-cc10-23d2-637fbef9632f@redhat.com \
--to=eblake@redhat.com \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).