[RFC 0/1] acceptance tests: bump Avocado version to 88.1

[RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Willian Rampazzo]

CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401

Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
object has no attribute 'encode'".

The release notes are available at
https://avocado-framework.readthedocs.io/en/latest/releases/88_0.html.

Signed-off-by: Willian Rampazzo <willianr@redhat.com>

Willian Rampazzo (1):
  acceptance tests: bump Avocado version to 88.1

 tests/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.31.1

[RFC 1/1] acceptance tests: bump Avocado version to 88.1

[Willian Rampazzo]

Besides some internal changes, new features, and bug fixes, on the QEMU side,
this version fixes the following message seen when running the acceptance
tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
object has no attribute 'encode'".

The release notes are available at
https://avocado-framework.readthedocs.io/en/latest/releases/88_0.html.

Signed-off-by: Willian Rampazzo <willianr@redhat.com>
---
 tests/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/requirements.txt b/tests/requirements.txt
index 91f3a343b9..a21b59b443 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -1,5 +1,5 @@
 # Add Python module requirements, one per line, to be installed
 # in the tests/venv Python virtual environment. For more info,
 # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
-avocado-framework==85.0
+avocado-framework==88.1
 pycdlib==1.11.0
-- 
2.31.1

Re: [RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Willian Rampazzo]

It was not supposed to be an RFC, resending as PATCH.

On Thu, May 20, 2021 at 5:51 PM Willian Rampazzo <willianr@redhat.com> wrote:
>
> CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
>
> Besides some internal changes, new features, and bug fixes, on the QEMU side,
> this version fixes the following message seen when running the acceptance
> tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
> object has no attribute 'encode'".
>
> The release notes are available at
> https://avocado-framework.readthedocs.io/en/latest/releases/88_0.html.
>
> Signed-off-by: Willian Rampazzo <willianr@redhat.com>
>
> Willian Rampazzo (1):
>   acceptance tests: bump Avocado version to 88.1
>
>  tests/requirements.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.31.1
>
>
>

Re: [RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Cleber Rosa]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

On Thu, May 20, 2021 at 05:47:46PM -0300, Willian Rampazzo wrote:
> CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
>

While not related to change in Avocado version (I've verified the same
behavior with 85.0), we need to investigate (further) one of the jobs
getting stuck here:

   https://gitlab.com/willianrampazzo/qemu/-/jobs/1281481564#L79

Would you care to take that task?

Thanks,
- Cleber.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [RFC 1/1] acceptance tests: bump Avocado version to 88.1

[Cleber Rosa]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

On Thu, May 20, 2021 at 05:47:47PM -0300, Willian Rampazzo wrote:
> Besides some internal changes, new features, and bug fixes, on the QEMU side,
> this version fixes the following message seen when running the acceptance
> tests: "Error running method "pre_tests" of plugin "fetchasset": 'bytes'
> object has no attribute 'encode'".
> 
> The release notes are available at
> https://avocado-framework.readthedocs.io/en/latest/releases/88_0.html.
> 
> Signed-off-by: Willian Rampazzo <willianr@redhat.com>
> ---
>  tests/requirements.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/requirements.txt b/tests/requirements.txt
> index 91f3a343b9..a21b59b443 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -1,5 +1,5 @@
>  # Add Python module requirements, one per line, to be installed
>  # in the tests/venv Python virtual environment. For more info,
>  # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
> -avocado-framework==85.0
> +avocado-framework==88.1
>  pycdlib==1.11.0
> -- 
> 2.31.1
> 

I'll be including that bump (and discarding the previous one) on my
upcoming PR.

Acked-by: Cleber Rosa <crosa@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Philippe Mathieu-Daudé]

On 5/24/21 7:50 PM, Cleber Rosa wrote:
> On Thu, May 20, 2021 at 05:47:46PM -0300, Willian Rampazzo wrote:
>> CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
>>
> 
> While not related to change in Avocado version (I've verified the same
> behavior with 85.0), we need to investigate (further) one of the jobs
> getting stuck here:
> 
>    https://gitlab.com/willianrampazzo/qemu/-/jobs/1281481564#L79

Problem between QEMU/Avocado.

QEMU sets Avocado tags to restrict the set of jobs ran and uses
the @skip decorators to ignore jobs under some conditions, i.e.:

tests/acceptance/boot_linux.py:141:    @skipIf(os.getenv('GITLAB_CI'),
'Running on GitLab')
tests/acceptance/boot_linux_console.py:235:
@skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted code')
tests/acceptance/boot_linux_console.py:593:
@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
tests/acceptance/boot_linux_console.py:795:
@skipUnless(os.getenv('AVOCADO_ALLOW_LARGE_STORAGE'), 'storage limited')

Avocado fetches artifacts *before* evaluating decorators / tags, so
we are currently trying to fetch artifacts known to break CI due to
their size.

Willian has been looking at it and it is not clear which project
should be modified. He might explain better ;)

Re: [RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Willian Rampazzo]

On Mon, May 24, 2021 at 2:55 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> On Thu, May 20, 2021 at 05:47:46PM -0300, Willian Rampazzo wrote:
> > CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
> >
>
> While not related to change in Avocado version (I've verified the same
> behavior with 85.0), we need to investigate (further) one of the jobs
> getting stuck here:
>
>    https://gitlab.com/willianrampazzo/qemu/-/jobs/1281481564#L79
>
> Would you care to take that task?

Sure, I can do that!

>
> Thanks,
> - Cleber.

Re: [RFC 0/1] acceptance tests: bump Avocado version to 88.1

[Willian Rampazzo]

On Mon, May 24, 2021 at 2:55 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> On Thu, May 20, 2021 at 05:47:46PM -0300, Willian Rampazzo wrote:
> > CI pipeline: https://gitlab.com/willianrampazzo/qemu/-/pipelines/306904401
> >
>
> While not related to change in Avocado version (I've verified the same
> behavior with 85.0), we need to investigate (further) one of the jobs
> getting stuck here:
>
>    https://gitlab.com/willianrampazzo/qemu/-/jobs/1281481564#L79
>
> Would you care to take that task?

FYI: https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg07958.html

>
> Thanks,
> - Cleber.