From: Alistair Francis <alistair23@gmail.com>
To: Frank Chang <frank.chang@sifive.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Bin Meng <bin.meng@windriver.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Chih-Min Chao <chihmin.chao@sifive.com>,
Alistair Francis <alistair.francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v4 2/2] target/riscv: change the api for RVF/RVD fmin/fmax
Date: Thu, 21 Oct 2021 09:24:55 +1000 [thread overview]
Message-ID: <CAKmqyKNwyuqFNrJJCun4_1tAOW6Jyq2tfSFDabBoVg6TW7PMAg@mail.gmail.com> (raw)
In-Reply-To: <20211016085428.3001501-3-frank.chang@sifive.com>
On Sat, Oct 16, 2021 at 6:55 PM <frank.chang@sifive.com> wrote:
>
> From: Chih-Min Chao <chihmin.chao@sifive.com>
>
> The sNaN propagation behavior has been changed since
> cd20cee7 in https://github.com/riscv/riscv-isa-manual.
It would be a good idea to justify why we are using the priv spec for
the version check.
>
> Signed-off-by: Chih-Min Chao <chihmin.chao@sifive.com>
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/fpu_helper.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/target/riscv/fpu_helper.c b/target/riscv/fpu_helper.c
> index 8700516a14c..d62f4709002 100644
> --- a/target/riscv/fpu_helper.c
> +++ b/target/riscv/fpu_helper.c
> @@ -174,14 +174,18 @@ uint64_t helper_fmin_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2)
> {
> float32 frs1 = check_nanbox_s(rs1);
> float32 frs2 = check_nanbox_s(rs2);
> - return nanbox_s(float32_minnum(frs1, frs2, &env->fp_status));
> + return nanbox_s(env->priv_ver < PRIV_VERSION_1_11_0 ?
> + float32_minnum(frs1, frs2, &env->fp_status) :
> + float32_minimum_number(frs1, frs2, &env->fp_status));
> }
>
> uint64_t helper_fmax_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2)
> {
> float32 frs1 = check_nanbox_s(rs1);
> float32 frs2 = check_nanbox_s(rs2);
> - return nanbox_s(float32_maxnum(frs1, frs2, &env->fp_status));
> + return nanbox_s(env->priv_ver < PRIV_VERSION_1_11_0 ?
> + float32_maxnum(frs1, frs2, &env->fp_status) :
> + float32_maximum_number(frs1, frs2, &env->fp_status));
> }
>
> uint64_t helper_fsqrt_s(CPURISCVState *env, uint64_t rs1)
> @@ -283,12 +287,16 @@ uint64_t helper_fdiv_d(CPURISCVState *env, uint64_t frs1, uint64_t frs2)
>
> uint64_t helper_fmin_d(CPURISCVState *env, uint64_t frs1, uint64_t frs2)
> {
> - return float64_minnum(frs1, frs2, &env->fp_status);
> + return env->priv_ver < PRIV_VERSION_1_11_0 ?
> + float64_minnum(frs1, frs2, &env->fp_status) :
> + float64_minimum_number(frs1, frs2, &env->fp_status);
> }
>
> uint64_t helper_fmax_d(CPURISCVState *env, uint64_t frs1, uint64_t frs2)
> {
> - return float64_maxnum(frs1, frs2, &env->fp_status);
> + return env->priv_ver < PRIV_VERSION_1_11_0 ?
> + float64_maxnum(frs1, frs2, &env->fp_status) :
> + float64_maximum_number(frs1, frs2, &env->fp_status);
> }
>
> uint64_t helper_fcvt_s_d(CPURISCVState *env, uint64_t rs1)
> --
> 2.25.1
>
>
prev parent reply other threads:[~2021-10-20 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 8:54 [PATCH v4 0/2] add APIs to handle alternative sNaN propagation for fmax/fmin frank.chang
2021-10-16 8:54 ` [PATCH v4 1/2] softfloat: " frank.chang
2021-10-16 17:59 ` Richard Henderson
2021-10-16 8:54 ` [PATCH v4 2/2] target/riscv: change the api for RVF/RVD fmin/fmax frank.chang
2021-10-20 2:56 ` Frank Chang
2021-10-20 23:24 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNwyuqFNrJJCun4_1tAOW6Jyq2tfSFDabBoVg6TW7PMAg@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=chihmin.chao@sifive.com \
--cc=frank.chang@sifive.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).