From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair@alistair23.me>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size
Date: Mon, 25 May 2020 15:12:03 -0700 [thread overview]
Message-ID: <CAKmqyKP+7p2Kmti_Ds68ja=gLgY96tKjMhN8ACgDfaFv+XROgA@mail.gmail.com> (raw)
In-Reply-To: <20200525111001.8147-1-f4bug@amsat.org>
On Mon, May 25, 2020 at 4:10 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The ADC region size is 256B, split as:
> - [0x00 - 0x4f] defined
> - [0x50 - 0xff] reserved
>
> All registers are 32-bit (thus when the datasheet mentions the
> last defined register is 0x4c, it means its address range is
> 0x4c .. 0x4f.
>
> This model implementation is also 32-bit. Set MemoryRegionOps
> 'impl' fields.
>
> See:
> 'RM0033 Reference manual Rev 8', Table 10.13.18 "ADC register map".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> v2: Commit staged changes... (MemoryRegionOps::impl)
> ---
> hw/adc/stm32f2xx_adc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/adc/stm32f2xx_adc.c b/hw/adc/stm32f2xx_adc.c
> index 4f9d485ecf..01a0b14e69 100644
> --- a/hw/adc/stm32f2xx_adc.c
> +++ b/hw/adc/stm32f2xx_adc.c
> @@ -246,6 +246,8 @@ static const MemoryRegionOps stm32f2xx_adc_ops = {
> .read = stm32f2xx_adc_read,
> .write = stm32f2xx_adc_write,
> .endianness = DEVICE_NATIVE_ENDIAN,
> + .impl.min_access_size = 4,
> + .impl.max_access_size = 4,
> };
>
> static const VMStateDescription vmstate_stm32f2xx_adc = {
> @@ -278,7 +280,7 @@ static void stm32f2xx_adc_init(Object *obj)
> sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq);
>
> memory_region_init_io(&s->mmio, obj, &stm32f2xx_adc_ops, s,
> - TYPE_STM32F2XX_ADC, 0xFF);
> + TYPE_STM32F2XX_ADC, 0x100);
> sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
> }
>
> --
> 2.21.3
>
>
prev parent reply other threads:[~2020-05-25 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 11:10 [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size Philippe Mathieu-Daudé
2020-05-25 22:12 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKP+7p2Kmti_Ds68ja=gLgY96tKjMhN8ACgDfaFv+XROgA@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).