* [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size
@ 2020-05-25 11:10 Philippe Mathieu-Daudé
2020-05-25 22:12 ` Alistair Francis
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-25 11:10 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Peter Maydell, Alistair Francis,
Philippe Mathieu-Daudé,
qemu-arm
The ADC region size is 256B, split as:
- [0x00 - 0x4f] defined
- [0x50 - 0xff] reserved
All registers are 32-bit (thus when the datasheet mentions the
last defined register is 0x4c, it means its address range is
0x4c .. 0x4f.
This model implementation is also 32-bit. Set MemoryRegionOps
'impl' fields.
See:
'RM0033 Reference manual Rev 8', Table 10.13.18 "ADC register map".
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: Commit staged changes... (MemoryRegionOps::impl)
---
hw/adc/stm32f2xx_adc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/adc/stm32f2xx_adc.c b/hw/adc/stm32f2xx_adc.c
index 4f9d485ecf..01a0b14e69 100644
--- a/hw/adc/stm32f2xx_adc.c
+++ b/hw/adc/stm32f2xx_adc.c
@@ -246,6 +246,8 @@ static const MemoryRegionOps stm32f2xx_adc_ops = {
.read = stm32f2xx_adc_read,
.write = stm32f2xx_adc_write,
.endianness = DEVICE_NATIVE_ENDIAN,
+ .impl.min_access_size = 4,
+ .impl.max_access_size = 4,
};
static const VMStateDescription vmstate_stm32f2xx_adc = {
@@ -278,7 +280,7 @@ static void stm32f2xx_adc_init(Object *obj)
sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq);
memory_region_init_io(&s->mmio, obj, &stm32f2xx_adc_ops, s,
- TYPE_STM32F2XX_ADC, 0xFF);
+ TYPE_STM32F2XX_ADC, 0x100);
sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
}
--
2.21.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size
2020-05-25 11:10 [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size Philippe Mathieu-Daudé
@ 2020-05-25 22:12 ` Alistair Francis
0 siblings, 0 replies; 2+ messages in thread
From: Alistair Francis @ 2020-05-25 22:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Peter Maydell, Alistair Francis,
qemu-devel@nongnu.org Developers, qemu-arm
On Mon, May 25, 2020 at 4:10 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The ADC region size is 256B, split as:
> - [0x00 - 0x4f] defined
> - [0x50 - 0xff] reserved
>
> All registers are 32-bit (thus when the datasheet mentions the
> last defined register is 0x4c, it means its address range is
> 0x4c .. 0x4f.
>
> This model implementation is also 32-bit. Set MemoryRegionOps
> 'impl' fields.
>
> See:
> 'RM0033 Reference manual Rev 8', Table 10.13.18 "ADC register map".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> v2: Commit staged changes... (MemoryRegionOps::impl)
> ---
> hw/adc/stm32f2xx_adc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/adc/stm32f2xx_adc.c b/hw/adc/stm32f2xx_adc.c
> index 4f9d485ecf..01a0b14e69 100644
> --- a/hw/adc/stm32f2xx_adc.c
> +++ b/hw/adc/stm32f2xx_adc.c
> @@ -246,6 +246,8 @@ static const MemoryRegionOps stm32f2xx_adc_ops = {
> .read = stm32f2xx_adc_read,
> .write = stm32f2xx_adc_write,
> .endianness = DEVICE_NATIVE_ENDIAN,
> + .impl.min_access_size = 4,
> + .impl.max_access_size = 4,
> };
>
> static const VMStateDescription vmstate_stm32f2xx_adc = {
> @@ -278,7 +280,7 @@ static void stm32f2xx_adc_init(Object *obj)
> sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq);
>
> memory_region_init_io(&s->mmio, obj, &stm32f2xx_adc_ops, s,
> - TYPE_STM32F2XX_ADC, 0xFF);
> + TYPE_STM32F2XX_ADC, 0x100);
> sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio);
> }
>
> --
> 2.21.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-25 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 11:10 [PATCH v2] hw/adc/stm32f2xx_adc: Correct memory region size and access size Philippe Mathieu-Daudé
2020-05-25 22:12 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).