From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: sw <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/5] meson: mingw installation fixes & nsis conversion
Date: Tue, 25 Aug 2020 20:49:35 +0400 [thread overview]
Message-ID: <CAMxuvazbx51vcNSQfaGXhhuF-zrk6ixwhTMn2Bbfu0axQk5rww@mail.gmail.com> (raw)
In-Reply-To: <CABgObfbW5NMu4-NxiTNYF1NxiXt9pgyueJwv+vqdyQ5gySd+bQ@mail.gmail.com>
Hi
On Tue, Aug 25, 2020 at 8:38 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Whenever we fix these bugs I would rather avoid adding duplicates between options and config-host.mak, so that we can sooner or later get rid of config-host.mak.
This is not adding things to config-host.mak.
> For the same reason, I think all options should have a sensible default so that in the end it will be possible to do "meson setup". Do you think it's possible to extend the series in this direction?
The options I added also have default values.
I think trying to remove (or just move) variables would be a separate
goal from this series. It's already not completely trivial to get the
conversion working without regression, as you probably know :) better
not to mix goals imho.
>
> Paolo
>
> Il mar 25 ago 2020, 17:04 <marcandre.lureau@redhat.com> ha scritto:
>>
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Hi,
>>
>> The following patches fix installation path when cross-compiling Windows
>> version, and move the NSIS build rule to meson.
>>
>> Marc-André Lureau (5):
>> meson: pass confsuffix option
>> meson: use meson datadir instead of qemu_datadir
>> meson: add docdir option and pass pre-prefix qemu_docdir
>> meson: use meson mandir instead of qemu_mandir
>> meson: add NSIS building
>>
>> Makefile | 56 -----------------------------
>> configure | 2 ++
>> contrib/vhost-user-gpu/meson.build | 2 +-
>> docs/meson.build | 4 +--
>> meson.build | 32 +++++++++++++++--
>> meson_options.txt | 2 ++
>> pc-bios/descriptors/meson.build | 2 +-
>> pc-bios/keymaps/meson.build | 6 ++--
>> pc-bios/meson.build | 2 +-
>> scripts/nsis.sh | 58 ++++++++++++++++++++++++++++++
>> tools/virtiofsd/meson.build | 2 +-
>> trace/meson.build | 2 +-
>> 12 files changed, 101 insertions(+), 69 deletions(-)
>> create mode 100755 scripts/nsis.sh
>>
>> --
>> 2.26.2
>>
>>
next prev parent reply other threads:[~2020-08-25 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:04 [PATCH 0/5] meson: mingw installation fixes & nsis conversion marcandre.lureau
2020-08-25 15:04 ` [PATCH 1/5] meson: pass confsuffix option marcandre.lureau
2020-08-25 15:04 ` [PATCH 2/5] meson: use meson datadir instead of qemu_datadir marcandre.lureau
2020-08-25 15:04 ` [PATCH 3/5] meson: add docdir option and pass pre-prefix qemu_docdir marcandre.lureau
2020-08-25 15:04 ` [PATCH 4/5] meson: use meson mandir instead of qemu_mandir marcandre.lureau
2020-08-25 15:04 ` [PATCH 5/5] meson: add NSIS building marcandre.lureau
2020-08-25 15:11 ` Daniel P. Berrangé
2020-08-25 16:03 ` Peter Maydell
2020-08-25 16:07 ` Daniel P. Berrangé
2020-08-25 16:11 ` Peter Maydell
2020-08-25 16:38 ` [PATCH 0/5] meson: mingw installation fixes & nsis conversion Paolo Bonzini
2020-08-25 16:49 ` Marc-André Lureau [this message]
2020-08-25 18:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvazbx51vcNSQfaGXhhuF-zrk6ixwhTMn2Bbfu0axQk5rww@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).