From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, sw@weilnetz.de
Subject: Re: [PATCH 5/5] meson: add NSIS building
Date: Tue, 25 Aug 2020 16:11:56 +0100 [thread overview]
Message-ID: <20200825151156.GW107278@redhat.com> (raw)
In-Reply-To: <20200825150409.346957-6-marcandre.lureau@redhat.com>
On Tue, Aug 25, 2020 at 07:04:09PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Makefile | 56 -----------------------------------------------
> meson.build | 24 ++++++++++++++++++++
> scripts/nsis.sh | 58 +++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 82 insertions(+), 56 deletions(-)
> create mode 100755 scripts/nsis.sh
I feel like one of the bug improvements of Meson over a traditional
configure+make type approach is that we get much improved platform
portability by default in the build system, largely for free from
Meson and in turn Python.
With this in mind, I think that as a general goal, we should strive
to eliminate any and all use of shell in the build system, standardizing
on Python for any helper programs we need to run from Meson.
This is a verbose way of saying I think you should create a
nsis.py, not nsis.sh, to avoid the inherant portability problems of
shell that hit us over and over and over again.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-08-25 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:04 [PATCH 0/5] meson: mingw installation fixes & nsis conversion marcandre.lureau
2020-08-25 15:04 ` [PATCH 1/5] meson: pass confsuffix option marcandre.lureau
2020-08-25 15:04 ` [PATCH 2/5] meson: use meson datadir instead of qemu_datadir marcandre.lureau
2020-08-25 15:04 ` [PATCH 3/5] meson: add docdir option and pass pre-prefix qemu_docdir marcandre.lureau
2020-08-25 15:04 ` [PATCH 4/5] meson: use meson mandir instead of qemu_mandir marcandre.lureau
2020-08-25 15:04 ` [PATCH 5/5] meson: add NSIS building marcandre.lureau
2020-08-25 15:11 ` Daniel P. Berrangé [this message]
2020-08-25 16:03 ` Peter Maydell
2020-08-25 16:07 ` Daniel P. Berrangé
2020-08-25 16:11 ` Peter Maydell
2020-08-25 16:38 ` [PATCH 0/5] meson: mingw installation fixes & nsis conversion Paolo Bonzini
2020-08-25 16:49 ` Marc-André Lureau
2020-08-25 18:14 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825151156.GW107278@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).