Re: [PATCH 14/14] bsd-user/signal: Create a dummy signal queueing function

From: Warner Losh <imp@bsdimp.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Kyle Evans <kevans@freebsd.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 14/14] bsd-user/signal: Create a dummy signal queueing function
Date: Sat, 25 Sep 2021 21:06:49 -0600	[thread overview]
Message-ID: <CANCZdfosi+ROGvyV34A4HYUnAyj7c1Mef=mrdCmRnPYRS0Gnxg@mail.gmail.com> (raw)
In-Reply-To: <CANCZdfo-YTGs3gLi1T+BKa5a1EhQ1ZpfhbR_x27n0uOKt3xE5A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2368 bytes --]

On Sat, Sep 25, 2021 at 8:53 AM Warner Losh <imp@bsdimp.com> wrote:

>
>
> On Sat, Sep 25, 2021, 4:50 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
>
>> On 9/22/21 08:14, Warner Losh wrote:
>> > Create dummy signal queueing function so we can start to integrate other
>> > architectures (at the cost of signals remaining broken) to tame the
>> > dependency graph a bit and to bring in signals in a more controlled
>> > fashion.
>> >
>> > Signed-off-by: Warner Losh <imp@bsdimp.com>
>> > ---
>> >   bsd-user/qemu.h   | 1 +
>> >   bsd-user/signal.c | 8 ++++++++
>> >   2 files changed, 9 insertions(+)
>> >
>> > diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
>> > index 5a2fd87e44..85d1f8fd2a 100644
>> > --- a/bsd-user/qemu.h
>> > +++ b/bsd-user/qemu.h
>> > @@ -209,6 +209,7 @@ void process_pending_signals(CPUArchState *cpu_env);
>> >   void signal_init(void);
>> >   long do_sigreturn(CPUArchState *env);
>> >   long do_rt_sigreturn(CPUArchState *env);
>> > +int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info);
>> >   abi_long do_sigaltstack(abi_ulong uss_addr, abi_ulong uoss_addr,
>> abi_ulong sp);
>> >
>> >   /* mmap.c */
>> > diff --git a/bsd-user/signal.c b/bsd-user/signal.c
>> > index ad6d935569..4e7f618944 100644
>> > --- a/bsd-user/signal.c
>> > +++ b/bsd-user/signal.c
>> > @@ -19,6 +19,14 @@
>> >   #include "qemu/osdep.h"
>> >
>> >   #include "qemu.h"
>> > +/*
>> > + * Queue a signal so that it will be send to the virtual CPU as soon as
>> > + * possible.
>> > + */
>> > +int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info)
>> > +{
>> > +    return 1;
>>
>> Shouldn't we abort() here or at least call qemu_log_mask(LOG_UNIMP)?
>>
>
> Sure. This code is just a placeholder for the moment so that I can prepare
> the full signal.c later, but still be able to submit my next 3 patch series
> which add aarch64, arm and riscv64. It can be anything you'd like without
> generating conflicts.
>
> When I spin the next version I'll have at least an abort here.
>

I'll add the log_unimp stuff too. In debugging something else, I've learned
how to use qemu_log and will convert a few things as well (though I'm not
yet sure the sequencing of those upstream).

Warner

> Warner
>
> > +}
>> >
>> >   void signal_init(void)
>> >   {
>> >
>>
>

[-- Attachment #2: Type: text/html, Size: 3818 bytes --]