qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Kyle Evans <kevans@freebsd.org>, Michael Tokarev <mjt@tls.msk.ru>,
	Laurent Vivier <laurent@vivier.eu>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Philippe Mathieu-Daude <f4bug@amsat.org>
Subject: Re: [PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c
Date: Fri, 5 Nov 2021 11:08:45 -0600	[thread overview]
Message-ID: <CANCZdfqg-svHj-bUVSquxNRsnyvMK=_zoJMpT6WirNkxOoNtNA@mail.gmail.com> (raw)
In-Reply-To: <fd711f1c-380a-80f2-2382-ef5aaf3b697e@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Fri, Nov 5, 2021 at 10:25 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 11/4/21 11:18 PM, Warner Losh wrote:
> > Move the current inline functions into sigal.c. This will increate the
> > flexibility of implementation in the future.
> >
> > Signed-off-by: Warner Losh<imp@bsdimp.com>
> > ---
> >   bsd-user/x86_64/signal.c             | 56 +++++++++++++++++++++++++++-
> >   bsd-user/x86_64/target_arch_signal.h | 43 ++++-----------------
> >   2 files changed, 63 insertions(+), 36 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> > +abi_long set_sigtramp_args(CPUX86State *env, int sig,
> > +                           struct target_sigframe *frame,
> > +                           abi_ulong frame_addr,
> > +                           struct target_sigaction *ka);
> > +abi_long get_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int
> flags);
> > +abi_long set_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int
> srflag);
> > +abi_long get_ucontext_sigreturn(CPUX86State *regs, abi_ulong target_sf,
> > +                                abi_ulong *target_uc);
>
> with of course the same comment as for i386.
>

of course... :)

Warner

[-- Attachment #2: Type: text/html, Size: 1886 bytes --]

  reply	other threads:[~2021-11-05 17:13 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05  3:18 [PATCH v4 00/36] bsd-user: arm (32-bit) support Warner Losh
2021-11-05  3:18 ` [PATCH v4 01/36] bsd-user/mips*: Remove Warner Losh
2021-11-05 15:52   ` Richard Henderson
2021-11-05 15:53     ` Kyle Evans
2021-11-05 16:01     ` Warner Losh
2021-11-05  3:18 ` [PATCH v4 02/36] bsd-user/freebsd: Create common target_os_ucontext.h file Warner Losh
2021-11-05 16:01   ` Richard Henderson
2021-11-05  3:18 ` [PATCH v4 03/36] bsd-user: create a per-arch signal.c file Warner Losh
2021-11-05 16:05   ` Richard Henderson
2021-11-05  3:18 ` [PATCH v4 04/36] bsd-user/i386/target_arch_signal.h: Remove target_sigcontext Warner Losh
2021-11-05  3:18 ` [PATCH v4 05/36] bsd-user/i386/target_arch_signal.h: use new target_os_ucontext.h Warner Losh
2021-11-05  3:18 ` [PATCH v4 06/36] bsd-user/i386/target_arch_signal.h: Update mcontext_t to match FreeBSD Warner Losh
2021-11-05 16:15   ` Richard Henderson
2021-11-05  3:18 ` [PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c Warner Losh
2021-11-05 16:21   ` Richard Henderson
2021-11-05 16:45     ` Warner Losh
2021-11-05 16:55       ` Warner Losh
2021-11-05  3:18 ` [PATCH v4 08/36] bsd-user/x86_64/target_arch_signal.h: Remove target_sigcontext Warner Losh
2021-11-05  3:18 ` [PATCH v4 09/36] bsd-user/x86_64/target_arch_signal.h: use new target_os_ucontext.h Warner Losh
2021-11-05  3:18 ` [PATCH v4 10/36] bsd-user/x86_64/target_arch_signal.h: Fill in mcontext_t Warner Losh
2021-11-05 16:23   ` Richard Henderson
2021-11-05  3:18 ` [PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c Warner Losh
2021-11-05 16:25   ` Richard Henderson
2021-11-05 17:08     ` Warner Losh [this message]
2021-11-05  3:18 ` [PATCH v4 12/36] bsd-user/arm/target_arch_sysarch.h: Use consistent include guards Warner Losh
2021-11-05  3:18 ` [PATCH v4 13/36] bsd-user/arm/target_syscall.h: Add copyright and update name Warner Losh
2021-11-05  3:18 ` [PATCH v4 14/36] bsd-user/arm/target_arch_cpu.c: Target specific TLS routines Warner Losh
2021-11-05  3:18 ` [PATCH v4 15/36] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions Warner Losh
2021-11-05  3:18 ` [PATCH v4 16/36] bsd-user/arm/target_arch_cpu.h: Implement target_cpu_clone_regs Warner Losh
2021-11-05  3:18 ` [PATCH v4 17/36] bsd-user/arm/target_arch_cpu.h: Dummy target_cpu_loop implementation Warner Losh
2021-11-05  3:18 ` [PATCH v4 18/36] bsd-user/arm/target_arch_cpu.h: Implement trivial EXCP exceptions Warner Losh
2021-11-05  3:19 ` [PATCH v4 19/36] bsd-user/arm/target_arch_cpu.h: Implement data abort exceptions Warner Losh
2021-11-05  3:19 ` [PATCH v4 20/36] bsd-user/arm/target_arch_cpu.h: Implement system call dispatch Warner Losh
2021-11-05  3:19 ` [PATCH v4 21/36] bsd-user/arm/target_arch_reg.h: Implement core dump register copying Warner Losh
2021-11-05  3:19 ` [PATCH v4 22/36] bsd-user/arm/target_arch_vmparam.h: Parameters for arm address space Warner Losh
2021-11-05  3:19 ` [PATCH v4 23/36] bsd-user/arm/target_arch_sigtramp.h: Signal Trampoline for arm Warner Losh
2021-11-05  3:19 ` [PATCH v4 24/36] bsd-user/arm/target_arch_thread.h: Routines to create and switch to a thread Warner Losh
2021-11-05  3:19 ` [PATCH v4 25/36] bsd-user/arm/target_arch_elf.h: arm defines for ELF Warner Losh
2021-11-05  3:19 ` [PATCH v4 26/36] bsd-user/arm/target_arch_elf.h: arm get hwcap Warner Losh
2021-11-05  3:19 ` [PATCH v4 27/36] bsd-user/arm/target_arch_elf.h: arm get_hwcap2 impl Warner Losh
2021-11-05  3:19 ` [PATCH v4 28/36] bsd-user/arm/target_arch_signal.h: arm specific signal registers and stack Warner Losh
2021-11-05  3:19 ` [PATCH v4 29/36] bsd-user/arm/target_arch_signal.h: arm machine context and trapframe for signals Warner Losh
2021-11-05 16:31   ` Richard Henderson
2021-11-05  3:19 ` [PATCH v4 30/36] bsd-user/arm/target_arch_signal.h: Define size of *context_t Warner Losh
2021-11-05 16:31   ` Richard Henderson
2021-11-05  3:19 ` [PATCH v4 31/36] bsd-user/arm/target_arch_signal.c: arm set_sigtramp_args Warner Losh
2021-11-05  3:19 ` [PATCH v4 32/36] bsd-user/arm/target_arch_signal.c: arm get_mcontext Warner Losh
2021-11-05 16:36   ` Richard Henderson
2021-11-05  3:19 ` [PATCH v4 33/36] bsd-user/arm/target_arch_signal.c: arm set_mcontext Warner Losh
2021-11-05 16:44   ` Richard Henderson
2021-11-05 17:41     ` Warner Losh
2021-11-05  3:19 ` [PATCH v4 34/36] bsd-user/arm/target_arch_signal.c: arm get_ucontext_sigreturn Warner Losh
2021-11-05  3:19 ` [PATCH v4 35/36] bsd-user/freebsd/target_os_ucontext.h: Require TARGET_*CONTEXT_SIZE Warner Losh
2021-11-05 16:45   ` Richard Henderson
2021-11-05  3:19 ` [PATCH v4 36/36] bsd-user: add arm target build Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANCZdfqg-svHj-bUVSquxNRsnyvMK=_zoJMpT6WirNkxOoNtNA@mail.gmail.com' \
    --to=imp@bsdimp.com \
    --cc=f4bug@amsat.org \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).