qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Bin Meng <bmeng.cn@gmail.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2] linux-user: Mark cpu_loop() with noreturn attribute
Date: Mon, 8 Nov 2021 09:25:46 -0700	[thread overview]
Message-ID: <CANCZdfrPyk_XO4soB1JURQTWZ5xMMW1kO6_TA4SuEK+jBsgbrA@mail.gmail.com> (raw)
In-Reply-To: <39681686-e208-3c75-c0a5-ffda2482311f@amsat.org>

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Mon, Nov 8, 2021 at 12:37 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:

> On 11/7/21 01:39, Warner Losh wrote:
> >
> >
> > On Sat, Nov 6, 2021, 5:39 AM Philippe Mathieu-Daudé <f4bug@amsat.org
> > <mailto:f4bug@amsat.org>> wrote:
> >
> >     cpu_loop() never exits, so mark it with QEMU_NORETURN.
> >
> >     Reviewed-by: Richard Henderson <richard.henderson@linaro.org
> >     <mailto:richard.henderson@linaro.org>>
> >     Reviewed-By: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
> >     Reviewed-by: Bin Meng <bmeng.cn@gmail.com <mailto:bmeng.cn@gmail.com
> >>
> >     Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org
> >     <mailto:f4bug@amsat.org>>
> >     ---
> >     v2:
> >     - rebased
> >     - restricted to linux-user
> >
> >     Supersedes: <20210905000429.1097336-1-f4bug@amsat.org
> >     <mailto:20210905000429.1097336-1-f4bug@amsat.org>>
> >
> >
> > Reviewed-by: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
> >
> > bsd-user likely needs similar treatment, no?
>
> IIUC this thread, not yet (I didn't want to get into your refactor):
>
> https://lore.kernel.org/qemu-devel/CAFEAcA-f=n6XHp5Cj7=tH8NWO1GLA50i34=5GyaHrZELyr0bjw@mail.gmail.com/


I'll add it to my TODO items. I hope to get a small collection of those in
this month before the release after I land the arm bits.

Warner

[-- Attachment #2: Type: text/html, Size: 2946 bytes --]

  reply	other threads:[~2021-11-08 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-06 11:39 [PATCH v2] linux-user: Mark cpu_loop() with noreturn attribute Philippe Mathieu-Daudé
2021-11-07  0:39 ` Warner Losh
2021-11-08  7:37   ` Philippe Mathieu-Daudé
2021-11-08 16:25     ` Warner Losh [this message]
2021-12-15 10:55 ` Philippe Mathieu-Daudé
2021-12-19 16:07   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANCZdfrPyk_XO4soB1JURQTWZ5xMMW1kO6_TA4SuEK+jBsgbrA@mail.gmail.com \
    --to=imp@bsdimp.com \
    --cc=bmeng.cn@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).