From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Yang Zhong <yang.zhong@intel.com>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device
Date: Wed, 31 Jul 2019 17:59:01 +0200 [thread overview]
Message-ID: <CAP+75-Vrr5JcNd1tFhossrNDNEaJV4U4a+iyyDH2rgE5P6tV9g@mail.gmail.com> (raw)
In-Reply-To: <18d71b10-6be2-b76e-54d6-76c0395ca700@redhat.com>
On Wed, Jul 31, 2019 at 5:55 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
> On 7/31/19 1:50 PM, Thomas Huth wrote:
> > On 31/07/2019 13.47, Philippe Mathieu-Daudé wrote:
> >> On 7/31/19 9:56 AM, Thomas Huth wrote:
> >>> The device is only used by some few boards. Let's use a proper Kconfig
> >>> switch so that we only compile this code if we really need it.
> >>
> >> I'd prefer having the UnimpDevice user-creatable and always present as a
> >> core device...
> >
> > Why? This is a sysbus device that needs to be wired up in code, so I
> > don't see a reason for making this user-creatable right now.
>
> Right now no.
>
> > Anyway, that's a different subject, so this should not be part of this
> > patch.
>
> Fair enough.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Err, you missed MUSCA and MPS2.
next prev parent reply other threads:[~2019-07-31 16:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:56 [Qemu-devel] [PATCH for-4.2 v2 0/8] Kconfig switches Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 1/8] hw/Kconfig: Move the generic XLNX_ZYNQMP to the root hw/Kconfig Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 2/8] hw/intc: Only build the xlnx-iomod-intc device for the MicroBlaze PMU Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 3/8] hw/dma: Do not build the xlnx_dpdma device for the MicroBlaze machines Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 4/8] hw/core: Add a config switch for the "register" device Thomas Huth
2019-07-31 11:44 ` Philippe Mathieu-Daudé
2019-07-31 12:33 ` Paolo Bonzini
2019-08-05 17:04 ` Alistair Francis
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 5/8] hw/core: Add a config switch for the "or-irq" device Thomas Huth
2019-07-31 15:50 ` Philippe Mathieu-Daudé
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 6/8] hw/core: Add a config switch for the "split-irq" device Thomas Huth
2019-07-31 15:53 ` Philippe Mathieu-Daudé
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device Thomas Huth
2019-07-31 11:47 ` Philippe Mathieu-Daudé
2019-07-31 11:50 ` Thomas Huth
2019-07-31 15:55 ` Philippe Mathieu-Daudé
2019-07-31 15:59 ` Philippe Mathieu-Daudé [this message]
2019-08-01 8:08 ` Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 8/8] hw/core: Add a config switch for the generic loader device Thomas Huth
2019-07-31 15:54 ` Philippe Mathieu-Daudé
2019-07-31 12:34 ` [Qemu-devel] [PATCH for-4.2 v2 0/8] Kconfig switches Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP+75-Vrr5JcNd1tFhossrNDNEaJV4U4a+iyyDH2rgE5P6tV9g@mail.gmail.com \
--to=philmd@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).