From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Yang Zhong <yang.zhong@intel.com>,
qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm@nongnu.org,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device
Date: Wed, 31 Jul 2019 13:47:47 +0200 [thread overview]
Message-ID: <f2399005-cead-a147-37a5-600fda7eaea5@redhat.com> (raw)
In-Reply-To: <20190731075652.17053-8-thuth@redhat.com>
On 7/31/19 9:56 AM, Thomas Huth wrote:
> The device is only used by some few boards. Let's use a proper Kconfig
> switch so that we only compile this code if we really need it.
I'd prefer having the UnimpDevice user-creatable and always present as a
core device...
Maybe this can be solved by using 'default y':
config UNIMP
bool
default y
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/arm/Kconfig | 9 +++++++++
> hw/microblaze/Kconfig | 1 +
> hw/misc/Kconfig | 3 +++
> hw/misc/Makefile.objs | 2 +-
> hw/sparc64/Kconfig | 1 +
> 5 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 6e24c73b54..ab9e592d74 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -217,6 +217,7 @@ config STELLARIS
> select SSI_SD
> select STELLARIS_INPUT
> select STELLARIS_ENET # ethernet
> + select UNIMP
>
> config STRONGARM
> bool
> @@ -283,6 +284,7 @@ config ALLWINNER_A10
> select ALLWINNER_A10_PIC
> select ALLWINNER_EMAC
> select SERIAL
> + select UNIMP
>
> config RASPI
> bool
> @@ -320,6 +322,7 @@ config XLNX_VERSAL
> select PL011
> select CADENCE
> select VIRTIO_MMIO
> + select UNIMP
>
> config FSL_IMX25
> bool
> @@ -355,6 +358,7 @@ config ASPEED_SOC
> select SSI_M25P80
> select TMP105
> select TMP421
> + select UNIMP
>
> config MPS2
> bool
> @@ -378,6 +382,7 @@ config FSL_IMX7
> select IMX_I2C
> select PCI_EXPRESS_DESIGNWARE
> select SDHCI
> + select UNIMP
>
> config ARM_SMMUV3
> bool
> @@ -389,6 +394,7 @@ config FSL_IMX6UL
> select IMX_FEC
> select IMX_I2C
> select SDHCI
> + select UNIMP
>
> config MICROBIT
> bool
> @@ -398,6 +404,7 @@ config NRF51_SOC
> bool
> select I2C
> select ARM_V7M
> + select UNIMP
>
> config EMCRAFT_SF2
> bool
> @@ -410,6 +417,7 @@ config MSF2
> select PTIMER
> select SERIAL
> select SSI
> + select UNIMP
>
> config ZAURUS
> bool
> @@ -448,6 +456,7 @@ config ARMSSE
> select TZ_MPC
> select TZ_MSC
> select TZ_PPC
> + select UNIMP
>
> config ARMSSE_CPUID
> bool
> diff --git a/hw/microblaze/Kconfig b/hw/microblaze/Kconfig
> index c4dc120973..e2697ced9c 100644
> --- a/hw/microblaze/Kconfig
> +++ b/hw/microblaze/Kconfig
> @@ -4,6 +4,7 @@ config PETALOGIX_S3ADSP1800
> select XILINX
> select XILINX_AXI
> select XILINX_ETHLITE
> + select UNIMP
>
> config PETALOGIX_ML605
> bool
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> index 385e1b0cec..51754bb47c 100644
> --- a/hw/misc/Kconfig
> +++ b/hw/misc/Kconfig
> @@ -117,4 +117,7 @@ config AUX
> bool
> select I2C
>
> +config UNIMP
> + bool
> +
> source macio/Kconfig
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index e9aab519a1..e4aad707fb 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
> common-obj-$(CONFIG_EDU) += edu.o
> common-obj-$(CONFIG_PCA9552) += pca9552.o
>
> -common-obj-y += unimp.o
> +common-obj-$(CONFIG_UNIMP) += unimp.o
> common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>
> # ARM devices
> diff --git a/hw/sparc64/Kconfig b/hw/sparc64/Kconfig
> index d4d76a89be..f9f8b0f73a 100644
> --- a/hw/sparc64/Kconfig
> +++ b/hw/sparc64/Kconfig
> @@ -17,3 +17,4 @@ config NIAGARA
> bool
> select EMPTY_SLOT
> select SUN4V_RTC
> + select UNIMP
>
next prev parent reply other threads:[~2019-07-31 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:56 [Qemu-devel] [PATCH for-4.2 v2 0/8] Kconfig switches Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 1/8] hw/Kconfig: Move the generic XLNX_ZYNQMP to the root hw/Kconfig Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 2/8] hw/intc: Only build the xlnx-iomod-intc device for the MicroBlaze PMU Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 3/8] hw/dma: Do not build the xlnx_dpdma device for the MicroBlaze machines Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 4/8] hw/core: Add a config switch for the "register" device Thomas Huth
2019-07-31 11:44 ` Philippe Mathieu-Daudé
2019-07-31 12:33 ` Paolo Bonzini
2019-08-05 17:04 ` Alistair Francis
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 5/8] hw/core: Add a config switch for the "or-irq" device Thomas Huth
2019-07-31 15:50 ` Philippe Mathieu-Daudé
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 6/8] hw/core: Add a config switch for the "split-irq" device Thomas Huth
2019-07-31 15:53 ` Philippe Mathieu-Daudé
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device Thomas Huth
2019-07-31 11:47 ` Philippe Mathieu-Daudé [this message]
2019-07-31 11:50 ` Thomas Huth
2019-07-31 15:55 ` Philippe Mathieu-Daudé
2019-07-31 15:59 ` Philippe Mathieu-Daudé
2019-08-01 8:08 ` Thomas Huth
2019-07-31 7:56 ` [Qemu-devel] [PATCH v2 8/8] hw/core: Add a config switch for the generic loader device Thomas Huth
2019-07-31 15:54 ` Philippe Mathieu-Daudé
2019-07-31 12:34 ` [Qemu-devel] [PATCH for-4.2 v2 0/8] Kconfig switches Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2399005-cead-a147-37a5-600fda7eaea5@redhat.com \
--to=philmd@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).