From: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>
To: Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "farosas@linux.ibm.com" <farosas@linux.ibm.com>,
Lucas Mateus Martins Araujo e Castro
<lucas.araujo@eldorado.org.br>,
Luis Fernando Fujita Pires <luis.pires@eldorado.org.br>,
Fernando Eckhardt Valle <fernando.valle@eldorado.org.br>,
Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>,
"david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
Subject: RE: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c
Date: Tue, 13 Apr 2021 16:35:28 +0000 [thread overview]
Message-ID: <CP2PR80MB449944BBB61F3858D3F566DFC74F9@CP2PR80MB4499.lamprd80.prod.outlook.com> (raw)
In-Reply-To: <f580510c-0468-f1bd-5d3a-dc52043e5c1a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]
> > +/* gdbstub.c */
> > +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc);
> > +gchar *ppc_gdb_arch_name(CPUState *cs);
>
> These should probably go into internal.h and not cpu.h.
> These do not need to be exposed outside of target/ppc/.
Makes sense, I can do that. Is such a small change worth a v3, or do I fix this as I send the disable-tcg patch series?
> > +#include "exec/helper-proto.h"
>
> Not ideal, but ok temporarily.
yeah, this is only here until we figure out how to deal with the vscr stuff.
> > + gdb_get_reg32(buf, helper_mfvscr(env));
> ...
> > + helper_mtvscr(env, ldl_p(mem_buf));
>
> These should be modeled on e.g. store_fpscr, where there's a non-"helper"
> function to be called, which is then called by the "helper" function.
>
> Obviously, splitting that out should be a separate patch.
We already expected to fix this in the disable-tcg patch series, but this reference does help (:
However, checking now, store_fpscr is defined in fpu_helper.c, which is mostly TCG stuff. Any
idea where we could move the store_* functions to have them compile in the !tcg build?
My best guess is to do it in cpu.c, as the other files compiled with the same options are cpu-models.c and
gdbstub.c.
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO<http://clickemailmkt.eldorado.org.br/ls/click?upn=UPoxpeIcHnAcbUZyo7TTaswyiVb1TXP3jEbQqiiJKKGsxOn8hBEs5ZsMLQfXkKuKXZ7MVDg0ij9eG8HV4TXI75dBzDiNGLxQ8Xx5PzCVNt6TpGrzBbU-2Biu0o69X5ce-2FW-2FOk1uUipuK0fZnWXJEgbRw-3D-3DJY4T_wWk-2BG6VvNBoa1YzxYjhCdFS9IfANIaBzDSklR1NyyrKOI1wj0P-2BdBFcuO4FnHcsA1MyHu0ly1Yt3oDMp7KKdJPM68iKuI2jiRH5v4B0d8wf3chU3qy5n5iXWnW1QjSaNFHOgELzxaP-2FnesTeBgJ5dFkjH4f279sVQpOtyjw5xAqj34M6pgNRAxVvuXif4IWDcVzXg1FzfYlEfkKzr9vvpA3Hg8kitwMtlU3zwbQUBCgL30fQoJPcRPMGKyOY8RmoAlXNqTJYDYIvqmfnI7KLUvw6vKB5R-2B5q1FJRAzX7H-2BmF0NnDET6jMLuIqtCcVIch>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer<https://www.eldorado.org.br/disclaimer.html>
________________________________
[-- Attachment #2: Type: text/html, Size: 6707 bytes --]
prev parent reply other threads:[~2021-04-13 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 14:54 [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c Bruno Larsen (billionai)
2021-04-13 15:53 ` Richard Henderson
2021-04-13 16:35 ` Bruno Piazera Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CP2PR80MB449944BBB61F3858D3F566DFC74F9@CP2PR80MB4499.lamprd80.prod.outlook.com \
--to=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).