From: Richard Henderson <richard.henderson@linaro.org>
To: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>,
qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, lucas.araujo@eldorado.org.br,
luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br,
matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c
Date: Tue, 13 Apr 2021 08:53:15 -0700 [thread overview]
Message-ID: <f580510c-0468-f1bd-5d3a-dc52043e5c1a@linaro.org> (raw)
In-Reply-To: <20210413145427.41749-1-bruno.larsen@eldorado.org.br>
On 4/13/21 7:54 AM, Bruno Larsen (billionai) wrote:
> +/* gdbstub.c */
> +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc);
> +gchar *ppc_gdb_arch_name(CPUState *cs);
These should probably go into internal.h and not cpu.h.
These do not need to be exposed outside of target/ppc/.
> +#include "exec/helper-proto.h"
Not ideal, but ok temporarily.
> + gdb_get_reg32(buf, helper_mfvscr(env));
...
> + helper_mtvscr(env, ldl_p(mem_buf));
These should be modeled on e.g. store_fpscr, where there's a non-"helper"
function to be called, which is then called by the "helper" function.
Obviously, splitting that out should be a separate patch.
r~
next prev parent reply other threads:[~2021-04-13 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 14:54 [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c Bruno Larsen (billionai)
2021-04-13 15:53 ` Richard Henderson [this message]
2021-04-13 16:35 ` Bruno Piazera Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f580510c-0468-f1bd-5d3a-dc52043e5c1a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).