* Fixed unknown audio format with SDL2
@ 2020-01-16 18:27 KJ Liew
0 siblings, 0 replies; only message in thread
From: KJ Liew @ 2020-01-16 18:27 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
SDL2 (version >=2.0) prefers float32 audio format over integer audio format. QEMU sdlaudio.c does not handle any kind of AUDIO_F32 formats, but SDL_OpenAudio(req, obt) will return float32 audio format in obt and QEMU prints error about unknown format 33056 (0x8120).
The following simple patch fix the error by forcing SDL2 internal audio format conversion.
diff -ru ../orig/qemu-4.2.0/audio/sdlaudio.c ../qemu-4.2.0/audio/sdlaudio.c
--- ../orig/qemu-4.2.0/audio/sdlaudio.c 2019-12-12 10:20:47.000000000 -0800
+++ ../qemu-4.2.0/audio/sdlaudio.c 2020-01-15 15:56:25.059841600 -0800
@@ -147,10 +147,11 @@
}
#endif
- status = SDL_OpenAudio (req, obt);
+ status = SDL_OpenAudio (req, NULL);
if (status) {
sdl_logerr ("SDL_OpenAudio failed\n");
}
+ memcpy(obt, req, sizeof(SDL_AudioSpec));
#ifndef _WIN32
err = pthread_sigmask (SIG_SETMASK, &old, NULL);
[-- Attachment #2: Type: text/html, Size: 2578 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-16 18:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 18:27 Fixed unknown audio format with SDL2 KJ Liew
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).