From: <lichun@ruijie.com.cn>
To: <marcandre.lureau@redhat.com>, <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, 706701795@qq.com
Subject: Re: Re: [PATCH v2] chardev/tcp: fix error message double free error
Date: Sun, 28 Jun 2020 02:19:43 +0000 [thread overview]
Message-ID: <EEB2AE3E67807845A92E2350C6F5E02E0131DC4D34@FZEX3.ruijie.com.cn> (raw)
In-Reply-To: CAMxuvay1DnoogVOCxffYe4aA7sX8vZi6CoEa_j2kjWN22n3xAQ@mail.gmail.com
>Hi
>
>On Thu, Jun 25, 2020 at 10:47 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> lichun <lichun@ruijie.com.cn> writes:
>>
>> > Signed-off-by: lichun <lichun@ruijie.com.cn>
>> > ---
>> > chardev/char-socket.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/chardev/char-socket.c b/chardev/char-socket.c
>> > index afebeec5c3..569d54c144 100644
>> > --- a/chardev/char-socket.c
>> > +++ b/chardev/char-socket.c
>> > @@ -142,6 +142,8 @@ static void check_report_connect_error(Chardev *chr,
>> > "Unable to connect character device %s: ",
>> > chr->label);
>> > s->connect_err_reported = true;
>> > + } else {
>> > + error_free(err);
>> > }
>> > qemu_chr_socket_restart_timer(chr);
>> > }
>> > @@ -1086,7 +1088,6 @@ static void qemu_chr_socket_connected(QIOTask *task, void *opaque)
>> > if (qio_task_propagate_error(task, &err)) {
>> > tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);
>> > check_report_connect_error(chr, err);
>> > - error_free(err);
>> > goto cleanup;
>> > }
>>
>> Since my "Error handling fixes & cleanups" series fixes similar errors.
>> I'm happy to merge this patch along with it. Up to Marc-André.
>
>That would be great, thanks!
Thank you!
>
next prev parent reply other threads:[~2020-06-28 2:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 21:30 [PATCH v2] chardev/tcp: fix error message double free error lichun
2020-06-25 6:47 ` Markus Armbruster
2020-06-25 9:25 ` Marc-André Lureau
2020-06-28 2:19 ` lichun [this message]
2020-07-01 7:06 ` Markus Armbruster
2020-07-01 13:09 ` Paolo Bonzini
2020-07-01 15:12 ` lichun
2020-07-01 15:14 ` Paolo Bonzini
2020-07-02 4:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EEB2AE3E67807845A92E2350C6F5E02E0131DC4D34@FZEX3.ruijie.com.cn \
--to=lichun@ruijie.com.cn \
--cc=706701795@qq.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).