From: "Zhang, Chen" <chen.zhang@intel.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
qemu-dev <qemu-devel@nongnu.org>
Subject: RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector
Date: Wed, 10 Nov 2021 02:31:23 +0000 [thread overview]
Message-ID: <MWHPR11MB003109ADF1EF0F29E5A163289B939@MWHPR11MB0031.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB0031DA3889B2E94DDF5948229B929@MWHPR11MB0031.namprd11.prod.outlook.com>
> > > > > >
> > > > > > If we can do that, isn't it much more simpler to make
> > > > > > vnet_hdr_support by default?
> > > > >
> > > > > Yes, For compatibility filters and COLO still work with the
> > > > > original
> > > > "vnet_hdr_support".
> > > > > For new users, they can enable the new "auto_vnet_hdr" to avoid
> > > > > some
> > > > issues.
> > > >
> > > > Question still, so we have
> > > >
> > > > 1) enable vnet_hdr_support by default
> > > > 2) add auto_vnet_hdr and enable it by default
> > > >
> > > > Using 1) seems much more simpler and can solve this issue. If we
> > > > depends on the default behaviour, it should be almost the same. If
> > > > we want to teach the mgmt, both should work. Any other advantages
> > > > of
> > 2)?
> > >
> > > Using 1) we can't ensure user configure parts of module by itself.
> > (vnet_hdr_support = off).
> > > In this case, filter data already wrong and the filters can't report
> > > any
> > transfer error here.
> >
> > So I think the point is we can't ensure the user configure parts of
> > module in any case even if auto_vnet_hdr is introduced. E.g user can
> > choose to disable it manually. That's why I think it should not differ
> > too much from making vnet_hdr_support enabled by default.
>
Rethink about it. Using 1) make things much more simpler except the user config it manually.
I will follow your comments make V6 to 1).
Thanks
Chen
>
next prev parent reply other threads:[~2021-11-10 2:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 9:05 [PATCH V5 0/3] net/filter: Optimize filters vnet_hdr support Zhang Chen
2021-10-28 9:05 ` [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector Zhang Chen
2021-10-29 3:11 ` Jason Wang
2021-10-29 8:08 ` Zhang, Chen
2021-11-01 3:46 ` Jason Wang
2021-11-01 7:15 ` Zhang, Chen
2021-11-04 5:37 ` Zhang, Chen
2021-11-05 3:16 ` Jason Wang
2021-11-05 3:27 ` Zhang, Chen
2021-11-05 4:03 ` Jason Wang
2021-11-05 5:29 ` Zhang, Chen
2021-11-05 6:10 ` Markus Armbruster
2021-11-05 8:30 ` Jason Wang
2021-11-05 8:43 ` Zhang, Chen
2021-11-08 2:41 ` Jason Wang
2021-11-08 2:50 ` Zhang, Chen
2021-11-09 6:42 ` Jason Wang
2021-11-09 7:20 ` Zhang, Chen
2021-11-09 7:26 ` Jason Wang
2021-11-09 7:31 ` Zhang, Chen
2021-11-09 7:42 ` Jason Wang
2021-11-09 7:47 ` Zhang, Chen
2021-11-10 2:31 ` Zhang, Chen [this message]
2021-10-28 9:05 ` [PATCH V5 2/3] net/filter: Optimize transfer protocol for filter-rewriter Zhang Chen
2021-10-28 9:05 ` [PATCH V5 3/3] net/colo-compare.c: Optimize transfer protocol for colo-compare Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB003109ADF1EF0F29E5A163289B939@MWHPR11MB0031.namprd11.prod.outlook.com \
--to=chen.zhang@intel.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).