From: "Zhang, Chen" <chen.zhang@intel.com>
To: Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-dev <qemu-devel@nongnu.org>, Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector
Date: Thu, 4 Nov 2021 05:37:59 +0000 [thread overview]
Message-ID: <MWHPR11MB0031B626425E7815EB78A9E49B8D9@MWHPR11MB0031.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB00315CFF0E7854146B5C9AE69B8A9@MWHPR11MB0031.namprd11.prod.outlook.com>
> > > >
> > > >
> > > > I wonder if we need to introduce new parameter, e.g force_vnet_hdr
> > > > here, then we can always send vnet_hdr when it is enabled.
> > > >
> > > > Otherwise the "vnet_hdr_support" seems meaningless.
> > >
> > > Yes, Current "vnet_hdr_support" default enabled, and vnet_hdr_len
> > already forced from attached nf->netdev.
> > > Maybe we can introduce a new parameter "force_no_vnet_hdr" here to
> > make the vnet_hdr_len always keep 0.
> > > If you think OK, I will update it in next version.
> >
> > Let me explain, if I was not wrong:
> >
> > "vnet_hdr_support" means whether or not to send vnet header length. If
> > vnet_hdr_support=false, we won't send the vnet header. This looks the
> > same as you "force_no_vent_hdr" above.
>
> Yes, It was. But this series changed it.
> Current "vnet_hdr_support" can't decide whether send vnet header length,
> we always send it even 0.
> It will avoid sender/receiver transfer protocol parse issues:
> When sender data with the vnet header length, but receiver can't enable the
> "vnet_hdr_support".
> Filters will auto setup vnet_hdr_len as local nf->netdev and found the issue
> when get different vnet_hdr_len from other filters.
>
> >
> > And my "force_vnet_hdr" seems duplicated with vnet_hdr_support=true.
> > So it looks to me we can leave the mirror code as is and just change
> > the compare? (depends on the mgmt to set a correct vnet_hdr_support)
>
> OK, I will keep the filter-mirror/filter-redirector/filter-rewriter same as this
> version.
> For the colo-compare module, It will get primary node's filter data's
> vnet_hdr_len as the local value, And compare with secondary node's,
> because it is not attached any nf->netdev.
> So, it looks compare module's "vnet_hdr_support" been auto configuration
> from the filter transport protocol.
> If the "force_vnet_hdr" means hard code a compare's local vnet_hdr_len
> rather than come from input filter's data?
>
> Thanks
> Chen
>
Hi Jason/Markus,
Rethink about it, How about keep the original "vnet_hdr_support" function,
And add a new optional parameter "auto_vnet_hdr" for filters/compare?
Thanks
Chen
> >
> > Thanks
> >
> > >
> > > Thanks
> > > Chen
> > >
> > > >
> > > > Thanks
> > > >
> > > >
next prev parent reply other threads:[~2021-11-04 5:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 9:05 [PATCH V5 0/3] net/filter: Optimize filters vnet_hdr support Zhang Chen
2021-10-28 9:05 ` [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector Zhang Chen
2021-10-29 3:11 ` Jason Wang
2021-10-29 8:08 ` Zhang, Chen
2021-11-01 3:46 ` Jason Wang
2021-11-01 7:15 ` Zhang, Chen
2021-11-04 5:37 ` Zhang, Chen [this message]
2021-11-05 3:16 ` Jason Wang
2021-11-05 3:27 ` Zhang, Chen
2021-11-05 4:03 ` Jason Wang
2021-11-05 5:29 ` Zhang, Chen
2021-11-05 6:10 ` Markus Armbruster
2021-11-05 8:30 ` Jason Wang
2021-11-05 8:43 ` Zhang, Chen
2021-11-08 2:41 ` Jason Wang
2021-11-08 2:50 ` Zhang, Chen
2021-11-09 6:42 ` Jason Wang
2021-11-09 7:20 ` Zhang, Chen
2021-11-09 7:26 ` Jason Wang
2021-11-09 7:31 ` Zhang, Chen
2021-11-09 7:42 ` Jason Wang
2021-11-09 7:47 ` Zhang, Chen
2021-11-10 2:31 ` Zhang, Chen
2021-10-28 9:05 ` [PATCH V5 2/3] net/filter: Optimize transfer protocol for filter-rewriter Zhang Chen
2021-10-28 9:05 ` [PATCH V5 3/3] net/colo-compare.c: Optimize transfer protocol for colo-compare Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB0031B626425E7815EB78A9E49B8D9@MWHPR11MB0031.namprd11.prod.outlook.com \
--to=chen.zhang@intel.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).