From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
John Johnson <john.g.johnson@oracle.com>,
Thomas Huth <thuth@redhat.com>, Jag Raman <jag.raman@oracle.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] multiprocess: move feature to meson_options.txt
Date: Mon, 1 Mar 2021 11:24:11 +0000 [thread overview]
Message-ID: <YDzO23tOmZGNZxMt@stefanha-x1.localdomain> (raw)
In-Reply-To: <a9cf5d49-f30c-0b21-4c76-de454e1c9583@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Fri, Feb 26, 2021 at 09:50:59AM +0100, Philippe Mathieu-Daudé wrote:
> On 2/26/21 8:48 AM, Paolo Bonzini wrote:
> > On 26/02/21 00:16, Philippe Mathieu-Daudé wrote:
> >>> I personally don’t have any preference for the name.
> >> Great.
> >>
> >> So with the summary/description updated as:
> >>
> >> summary_info += {'Multiprocess QEMU (vfio-user device backends)':
> >> multiprocess_allowed}
> >>
> >> option('multiprocess', type: 'feature', value: 'auto',
> >> description: 'Multiprocess QEMU (vfio-user device backends)
> >> support')
> >>
> >> Reviewed-by: Philippe Mathieu-Daudé<philmd@redhat.com>
> >>
> >
> > It's not yet vfio-user. For now I can put "out of process device
> > emulation";
>
> OK.
>
> > however, if the protocol is going to change, I wonder if it
> > should be disabled by default.
>
> Sounds safer indeed. We need to add --enable-multiprocess in CI to
> keep testing the feature.
Package maintainers tend to disable optional features explicitly, while
developers and CIs may not notice new features that are disabled by
default.
In the interest of preventing bitrot and catching failures early (before
CI!), I suggest leaving it enabled for maximum build coverage.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-01 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 12:23 [PATCH] multiprocess: move feature to meson_options.txt Paolo Bonzini
2021-02-25 10:38 ` Philippe Mathieu-Daudé
2021-02-25 12:15 ` Paolo Bonzini
2021-02-25 16:35 ` Stefan Hajnoczi
2021-02-25 17:50 ` Jag Raman
2021-02-25 23:16 ` Philippe Mathieu-Daudé
2021-02-26 7:48 ` Paolo Bonzini
2021-02-26 8:50 ` Philippe Mathieu-Daudé
2021-03-01 11:24 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDzO23tOmZGNZxMt@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).