qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v3 4/8] meson: move qxl trace events to separate file
Date: Mon, 22 Mar 2021 11:43:13 +0000	[thread overview]
Message-ID: <YFiC0agIU3Qi4/bV@redhat.com> (raw)
In-Reply-To: <20210121125028.3247190-5-kraxel@redhat.com>

On Thu, Jan 21, 2021 at 01:50:24PM +0100, Gerd Hoffmann wrote:
> Move qxl trace events to separate trace-events-qxl file.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/qxl-render.c     |  1 +
>  hw/display/qxl.c            |  1 +
>  hw/display/meson.build      |  5 +++
>  hw/display/trace-events     | 67 -------------------------------------
>  hw/display/trace-events-qxl | 66 ++++++++++++++++++++++++++++++++++++
>  5 files changed, 73 insertions(+), 67 deletions(-)
>  create mode 100644 hw/display/trace-events-qxl
> 
> diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
> index 3ce2e57b8feb..cc4862e26eb6 100644
> --- a/hw/display/qxl-render.c
> +++ b/hw/display/qxl-render.c
> @@ -23,6 +23,7 @@
>  #include "qxl.h"
>  #include "sysemu/runstate.h"
>  #include "trace.h"
> +#include "trace/trace-hw_display_qxl.h"

I'm not a fan of this, as it feels like we're setting
up a completely different naming convention from the
one that already exists.

The previous "trace.h" header is relative to the source
directory. ie, "trace.h" is pulling in "hw/display/trace.h".

IMHO, we should be generating 'trace-qxl.h', alongside
the existing trace.h, so we can use a bare "trace-qxl.h"
include that refers to "hw/display/trace-qxl.h".

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2021-03-22 11:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 12:50 [PATCH v3 0/8] [RfC] fix tracing for modules Gerd Hoffmann
2021-01-21 12:50 ` [PATCH v3 1/8] meson: add trace_events_config[] Gerd Hoffmann
2021-01-27 14:48   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 2/8] meson: move up hw subdir (specifically before trace subdir) Gerd Hoffmann
2021-01-27 14:49   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 3/8] meson: add module_trace & module_trace_src Gerd Hoffmann
2021-01-27 15:03   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 4/8] meson: move qxl trace events to separate file Gerd Hoffmann
2021-01-27 15:33   ` Stefan Hajnoczi
2021-03-22 11:43   ` Daniel P. Berrangé [this message]
2021-01-21 12:50 ` [PATCH v3 5/8] trace: iter init tweaks Gerd Hoffmann
2021-02-03 16:13   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 6/8] trace: add trace_event_iter_init_group Gerd Hoffmann
2021-02-03 16:16   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 7/8] trace/simple: pass iter to st_write_event_mapping Gerd Hoffmann
2021-02-03 16:17   ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 8/8] trace/simple: add st_init_group Gerd Hoffmann
2021-02-03 16:22   ` Stefan Hajnoczi
2021-02-03 16:32 ` [PATCH v3 0/8] [RfC] fix tracing for modules Stefan Hajnoczi
2021-02-22 15:13   ` Gerd Hoffmann
2021-03-22 11:36     ` Stefan Hajnoczi
2021-03-22 11:46       ` Daniel P. Berrangé
2021-03-29 16:32         ` Stefan Hajnoczi
2021-03-22 12:03     ` Daniel P. Berrangé
2021-03-26 12:47       ` Gerd Hoffmann
2021-03-29  9:23         ` Daniel P. Berrangé
2021-03-29  9:48           ` Gerd Hoffmann
2021-03-29 10:02             ` Daniel P. Berrangé
2021-03-31 10:55               ` Gerd Hoffmann
2021-04-09  9:10               ` Gerd Hoffmann
2021-04-09 13:12       ` Gerd Hoffmann
2021-04-09 13:17         ` Daniel P. Berrangé
2021-04-12 13:07           ` Gerd Hoffmann
2021-04-15 13:10             ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFiC0agIU3Qi4/bV@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).