From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/8] [RfC] fix tracing for modules
Date: Fri, 9 Apr 2021 11:10:25 +0200 [thread overview]
Message-ID: <20210409091025.sht464kryv22cf3h@sirius.home.kraxel.org> (raw)
In-Reply-To: <YGGlo0C/JqlyQLMV@redhat.com>
Hi,
> > semantic error: unresolved function pid: identifier 'pid' at /home/kraxel/qemu-install/share/systemtap/tapset/qemu-system-x86_64-log.stp:5451:41
> > source: printf("%d@%d qxl_soft_reset %d\n", pid(), gettimeofday_ns(), qid)
> Hmm, strange, makes me think we have a bug causing it to not pull in
> global functions.
Yep. qemu-trace-stap sets SYSTEMTAP_TAPSET to
/home/kraxel/qemu-install/share/systemtap/tapset. Which makes stap use
that exclusively and ignore /usr/share/systemtap/tapset. Which in turn
makes pid() disappear because that apparently is defined somewhere in
those tapsets.
IOW: It's broken for any $prefix != "/usr".
Using stap -I /home/kraxel/qemu-install/share/systemtap/tapset seems to
work fine, I guess qemu-trace-stap should use that instead ...
take care,
Gerd
next prev parent reply other threads:[~2021-04-09 9:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 12:50 [PATCH v3 0/8] [RfC] fix tracing for modules Gerd Hoffmann
2021-01-21 12:50 ` [PATCH v3 1/8] meson: add trace_events_config[] Gerd Hoffmann
2021-01-27 14:48 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 2/8] meson: move up hw subdir (specifically before trace subdir) Gerd Hoffmann
2021-01-27 14:49 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 3/8] meson: add module_trace & module_trace_src Gerd Hoffmann
2021-01-27 15:03 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 4/8] meson: move qxl trace events to separate file Gerd Hoffmann
2021-01-27 15:33 ` Stefan Hajnoczi
2021-03-22 11:43 ` Daniel P. Berrangé
2021-01-21 12:50 ` [PATCH v3 5/8] trace: iter init tweaks Gerd Hoffmann
2021-02-03 16:13 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 6/8] trace: add trace_event_iter_init_group Gerd Hoffmann
2021-02-03 16:16 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 7/8] trace/simple: pass iter to st_write_event_mapping Gerd Hoffmann
2021-02-03 16:17 ` Stefan Hajnoczi
2021-01-21 12:50 ` [PATCH v3 8/8] trace/simple: add st_init_group Gerd Hoffmann
2021-02-03 16:22 ` Stefan Hajnoczi
2021-02-03 16:32 ` [PATCH v3 0/8] [RfC] fix tracing for modules Stefan Hajnoczi
2021-02-22 15:13 ` Gerd Hoffmann
2021-03-22 11:36 ` Stefan Hajnoczi
2021-03-22 11:46 ` Daniel P. Berrangé
2021-03-29 16:32 ` Stefan Hajnoczi
2021-03-22 12:03 ` Daniel P. Berrangé
2021-03-26 12:47 ` Gerd Hoffmann
2021-03-29 9:23 ` Daniel P. Berrangé
2021-03-29 9:48 ` Gerd Hoffmann
2021-03-29 10:02 ` Daniel P. Berrangé
2021-03-31 10:55 ` Gerd Hoffmann
2021-04-09 9:10 ` Gerd Hoffmann [this message]
2021-04-09 13:12 ` Gerd Hoffmann
2021-04-09 13:17 ` Daniel P. Berrangé
2021-04-12 13:07 ` Gerd Hoffmann
2021-04-15 13:10 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409091025.sht464kryv22cf3h@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).