qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Reinoud Zandijk <reinoud@NetBSD.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, Kamil Rytarowski <kamil@NetBSD.org>,
	Reinoud Zandijk <reinoud@NetBSD.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Ryo ONODERA <ryoon@netbsd.org>
Subject: Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support
Date: Wed, 7 Apr 2021 15:50:20 +0000	[thread overview]
Message-ID: <YG3UvN1vRzh1fdDT@gorilla.13thmonkey.org> (raw)
In-Reply-To: <604abe90-5eda-bbbd-fd5a-5fb9c5c4cf9e@linaro.org>

On Fri, Apr 02, 2021 at 02:51:41PM -0700, Richard Henderson wrote:
> On 4/2/21 1:25 PM, Reinoud Zandijk wrote:
> > +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true:
> > +  declare_dependency(link_args: ['-lnvmm'])
> > +)
> 
> You shouldn't be playing with link flags directly.
> 
> In patch 1, you found the nvmm library, and assigned it to the variable
> 'nvmm'.  You should just add the library as a dependency and let meson
> figure out what to do.
> 
> So I think this should just be
> 
> i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: nvmm)

Thanks for the patch :) I will incorporate it!

Reinoud



  reply	other threads:[~2021-04-07 15:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02 20:25 [PATCH v7 0/4] Implements the NetBSD Virtual Machine Monitor accelerator Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 1/4] Add NVMM accelerator: configure and build logic Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support Reinoud Zandijk
2021-04-02 21:51   ` Richard Henderson
2021-04-07 15:50     ` Reinoud Zandijk [this message]
2021-04-02 20:25 ` [PATCH v7 3/4] Add NVMM accelerator: acceleration enlightenments Reinoud Zandijk
2021-04-02 20:25 ` [PATCH v7 4/4] Add NVMM Accelerator: add maintainers for NetBSD/NVMM Reinoud Zandijk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG3UvN1vRzh1fdDT@gorilla.13thmonkey.org \
    --to=reinoud@netbsd.org \
    --cc=ehabkost@redhat.com \
    --cc=kamil@NetBSD.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ryoon@netbsd.org \
    --subject='Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).