From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, Markus Armbruster <armbru@redhat.com>,
peterx@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked
Date: Tue, 20 Apr 2021 10:25:12 +0100 [thread overview]
Message-ID: <YH6d+LUPKqstoLHP@work-vm> (raw)
In-Reply-To: <YH6Q+mnnzkx8lloR@redhat.com>
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote:
> > Result @blocked is true when and only when result @blocked-reasons is
> > present. It's always non-empty when present. @blocked is redundant.
> > It was introduced in commit 3af8554bd0 "migration: Add blocker
> > information", and has not been released. This gives us a chance to
> > fix the interface with minimal fuss.
> >
> > Unfortunately, we're already too close to the release to risk dropping
> > it. Deprecate it instead.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> > This is alternative to "[PATCH v2] migration: Drop redundant
> > query-migrate result @blocked".
> >
> > qapi/migration.json | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Yes,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Peter: Do you want to pick that up directly ?
Dave
>
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-04-20 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 5:19 [PATCH] migration: Deprecate redundant query-migrate result @blocked Markus Armbruster
2021-04-20 8:29 ` Daniel P. Berrangé
2021-04-20 9:25 ` Dr. David Alan Gilbert [this message]
2021-04-20 11:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH6d+LUPKqstoLHP@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).