From: Klaus Jensen <its@irrelevant.dk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org,
Gollu Appalanaidu <anaidu.gollu@samsung.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
stefanha@redhat.com, kbusch@kernel.org, mreitz@redhat.com
Subject: Re: [PATCH v2] hw/block/nvme: align with existing style
Date: Thu, 15 Apr 2021 19:18:50 +0200 [thread overview]
Message-ID: <YHh1evjljdZesw5I@apples.localdomain> (raw)
In-Reply-To: <a1ce0889-c80c-2d59-e65a-3eed8bfdd3e9@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On Apr 15 15:13, Philippe Mathieu-Daudé wrote:
>On 4/15/21 2:00 PM, Gollu Appalanaidu wrote:
>> Make uniform hexadecimal numbers format.
>>
>> Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>> ---
>> -v2: Address review comments (Klaus)
>> use lower case hexa format for the code and in comments
>> use the same format as used in Spec. ("FFFFFFFFh")
>
>^ This comment is relevant to the commit message.
>
>Also it would be nice if the subsystem could describe somewhere
>what is its style. Not sure where... The file header is probably
>the simplest place.
>
>Something like:
>
>"While QEMU coding style prefers lowercase hexadecimal in constants,
>the NVMe subsystem use the format from the NVMe specifications in
>the comments: no '0x' prefix, uppercase, 'h' hexadecimal suffix."
>
+1 for that suggestion.
>> hw/block/nvme-ns.c | 2 +-
>> hw/block/nvme.c | 40 ++++++++++++++++++++--------------------
>> include/block/nvme.h | 10 +++++-----
>> 3 files changed, 26 insertions(+), 26 deletions(-)
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-15 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210415120417epcas5p31ddb152cbe94fa5bebe386de5e33f69e@epcas5p3.samsung.com>
2021-04-15 12:00 ` [PATCH v2] hw/block/nvme: align with existing style Gollu Appalanaidu
2021-04-15 13:13 ` Philippe Mathieu-Daudé
2021-04-15 17:18 ` Klaus Jensen [this message]
2021-04-15 18:30 ` Gollu Appalanaidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHh1evjljdZesw5I@apples.localdomain \
--to=its@irrelevant.dk \
--cc=anaidu.gollu@samsung.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).