Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN

From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	"open list:Linux io_uring" <qemu-block@nongnu.org>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Julia Suvorova <jusual@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefano Garzarella <sgarzare@redhat.com>
Subject: Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN
Date: Thu, 29 Jul 2021 17:15:53 +0100	[thread overview]
Message-ID: <YQLUOVXgDjRuAZLQ@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210729091029.65369-1-f.ebner@proxmox.com>

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Thu, Jul 29, 2021 at 11:10:29AM +0200, Fabian Ebner wrote:
> Linux SCSI can throw spurious -EAGAIN in some corner cases in its
> completion path, which will end up being the result in the completed
> io_uring request.
> 
> Resubmitting such requests should allow block jobs to complete, even
> if such spurious errors are encountered.
> 
> Co-authored-by: Stefan Hajnoczi <stefanha@gmail.com>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * Focus on what's relevant for the patch itself in the commit
>       message.
>     * Add Stefan's comment.
>     * Add Stefano's R-b tag (I hope that's fine, since there was no
>       change code-wise).
> 
>  block/io_uring.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]