From: Klaus Jensen <its@irrelevant.dk>
To: Naveen Nagar <naveen.n1@samsung.com>
Cc: fam@euphon.net, kwolf@redhat.com, anuj.singh@samsung.com,
p.kalghatgi@samsung.com, qemu-block@nongnu.org,
k.jensen@samsung.com, anaidu.gollu@samsung.com,
d.palani@samsung.com, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, kbusch@kernel.org, prakash.v@samsung.com,
raphel.david@samsung.com, jg123.choi@samsung.com
Subject: Re: [RFC PATCH v2] hw/nvme:Adding Support for namespace management
Date: Thu, 23 Sep 2021 22:33:18 +0200 [thread overview]
Message-ID: <YUzkjsOkMHZhgtPZ@apples.localdomain> (raw)
In-Reply-To: <1629378597-30480-1-git-send-email-naveen.n1@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]
On Aug 19 18:39, Naveen Nagar wrote:
> From: Naveen <naveen.n1@samsung.com>
>
> This patch supports namespace management : create and delete operations.
>
> Since v1:
> - Modified and moved nvme_ns_identify_common in ns.c file
> - Added check for CSI field in NS management
> - Indentation fix in namespace create
>
> This patch has been tested with the following command and size of image
> file for unallocated namespaces is taken as 0GB. ns_create will look into
> the list of unallocated namespaces and it will initialize the same and
> return the nsid of the same. A new mandatory field has been added called
> tnvmcap and we have ensured that the total capacity of namespace created
> does not exceed tnvmcap
>
> -device nvme-subsys,id=subsys0,tnvmcap=8
> -device nvme,serial=foo,id=nvme0,subsys=subsys0
> -device nvme,serial=bar,id=nvme1,subsys=subsys0
> -drive id=ns1,file=ns1.img,if=none
> -device nvme-ns,drive=ns1,bus=nvme0,nsid=1,zoned=false,shared=true
> -drive id=ns2,file=ns2.img,if=none
> -device nvme-ns,drive=ns2,bus=nvme0,nsid=2,zoned=false,shared=true
> -drive id=ns3,file=ns3.img,if=none
> -device nvme-ns,drive=ns3,bus=nvme0,nsid=3,zoned=false,shared=true
> -drive id=ns4,file=ns4.img,if=none
> -device nvme-ns,drive=ns4,bus=nvme0,nsid=4,zoned=false,shared=true
>
> Please review and suggest if any changes are required.
>
> Signed-off-by: Naveen Nagar <naveen.n1@samsung.com>
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
>
So, I think this is a fine approach.
However, I think we should let it simmer until we know if my -object
refactoring will be accepted as a way forward. In that case, I'd like to
only add it there and likely as a new namespace "type" (i.e.
x-nvme-ns-unallocated) that will be replaced with a dynamically created
object depending on CSI.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-23 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210819135248epcas5p1fcc9f399f16a5336e6af004170a0eea4@epcas5p1.samsung.com>
2021-08-19 13:09 ` [RFC PATCH v2] hw/nvme:Adding Support for namespace management Naveen Nagar
2021-08-19 14:32 ` Klaus Jensen
2021-09-23 20:33 ` Klaus Jensen [this message]
2021-10-28 12:43 ` Lukasz Maniak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUzkjsOkMHZhgtPZ@apples.localdomain \
--to=its@irrelevant.dk \
--cc=anaidu.gollu@samsung.com \
--cc=anuj.singh@samsung.com \
--cc=d.palani@samsung.com \
--cc=fam@euphon.net \
--cc=jg123.choi@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=naveen.n1@samsung.com \
--cc=p.kalghatgi@samsung.com \
--cc=prakash.v@samsung.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphel.david@samsung.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).