* [PATCH v3 0/2] virtio-iommu: Name Tweaks
@ 2021-10-13 19:17 Eric Auger
2021-10-13 19:17 ` [PATCH v3 1/2] virtio-iommu: Remove the non transitional name Eric Auger
2021-10-13 19:17 ` [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name Eric Auger
0 siblings, 2 replies; 5+ messages in thread
From: Eric Auger @ 2021-10-13 19:17 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, qemu-arm, qemu-devel, mst, cohuck,
peter.maydell
Cc: jean-philippe, abologna
This small series removes the non transitional name, drop the base_name
and change the generic_name into "virtio-iommu-pci".
History:
v2 -> v3:
- fixed duplicate in commit msg
- added Connie's R-b
v1 -> v2:
- drop the base_name and change the generic_name into "virtio-iommu-pci"
(Connie)
Eric Auger (2):
virtio-iommu: Remove the non transitional name
virtio-iommu: Drop base_name and change generic_name
hw/virtio/virtio-iommu-pci.c | 4 +---
include/hw/virtio/virtio-iommu.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] virtio-iommu: Remove the non transitional name
2021-10-13 19:17 [PATCH v3 0/2] virtio-iommu: Name Tweaks Eric Auger
@ 2021-10-13 19:17 ` Eric Auger
2021-10-14 8:24 ` Jean-Philippe Brucker
2021-10-13 19:17 ` [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name Eric Auger
1 sibling, 1 reply; 5+ messages in thread
From: Eric Auger @ 2021-10-13 19:17 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, qemu-arm, qemu-devel, mst, cohuck,
peter.maydell
Cc: jean-philippe, abologna
Remove the non transitional name for virtio iommu. Like other
devices introduced after 1.0 spec, the virtio-iommu does
not need it.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reported-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
hw/virtio/virtio-iommu-pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
index 770c286be7..86fa4e6c28 100644
--- a/hw/virtio/virtio-iommu-pci.c
+++ b/hw/virtio/virtio-iommu-pci.c
@@ -100,7 +100,6 @@ static void virtio_iommu_pci_instance_init(Object *obj)
static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = {
.base_name = TYPE_VIRTIO_IOMMU_PCI,
.generic_name = "virtio-iommu-pci",
- .non_transitional_name = "virtio-iommu-pci-non-transitional",
.instance_size = sizeof(VirtIOIOMMUPCI),
.instance_init = virtio_iommu_pci_instance_init,
.class_init = virtio_iommu_pci_class_init,
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name
2021-10-13 19:17 [PATCH v3 0/2] virtio-iommu: Name Tweaks Eric Auger
2021-10-13 19:17 ` [PATCH v3 1/2] virtio-iommu: Remove the non transitional name Eric Auger
@ 2021-10-13 19:17 ` Eric Auger
2021-10-14 8:24 ` Jean-Philippe Brucker
1 sibling, 1 reply; 5+ messages in thread
From: Eric Auger @ 2021-10-13 19:17 UTC (permalink / raw)
To: eric.auger.pro, eric.auger, qemu-arm, qemu-devel, mst, cohuck,
peter.maydell
Cc: jean-philippe, abologna
Drop base_name and turn generic_name into
"virtio-iommu-pci". This is more in line with
other modern-only devices.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Suggested-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
hw/virtio/virtio-iommu-pci.c | 3 +--
include/hw/virtio/virtio-iommu.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
index 86fa4e6c28..a160ae6b41 100644
--- a/hw/virtio/virtio-iommu-pci.c
+++ b/hw/virtio/virtio-iommu-pci.c
@@ -98,8 +98,7 @@ static void virtio_iommu_pci_instance_init(Object *obj)
}
static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = {
- .base_name = TYPE_VIRTIO_IOMMU_PCI,
- .generic_name = "virtio-iommu-pci",
+ .generic_name = TYPE_VIRTIO_IOMMU_PCI,
.instance_size = sizeof(VirtIOIOMMUPCI),
.instance_init = virtio_iommu_pci_instance_init,
.class_init = virtio_iommu_pci_class_init,
diff --git a/include/hw/virtio/virtio-iommu.h b/include/hw/virtio/virtio-iommu.h
index 273e35c04b..e2339e5b72 100644
--- a/include/hw/virtio/virtio-iommu.h
+++ b/include/hw/virtio/virtio-iommu.h
@@ -26,7 +26,7 @@
#include "qom/object.h"
#define TYPE_VIRTIO_IOMMU "virtio-iommu-device"
-#define TYPE_VIRTIO_IOMMU_PCI "virtio-iommu-device-base"
+#define TYPE_VIRTIO_IOMMU_PCI "virtio-iommu-pci"
OBJECT_DECLARE_SIMPLE_TYPE(VirtIOIOMMU, VIRTIO_IOMMU)
#define TYPE_VIRTIO_IOMMU_MEMORY_REGION "virtio-iommu-memory-region"
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name
2021-10-13 19:17 ` [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name Eric Auger
@ 2021-10-14 8:24 ` Jean-Philippe Brucker
0 siblings, 0 replies; 5+ messages in thread
From: Jean-Philippe Brucker @ 2021-10-14 8:24 UTC (permalink / raw)
To: Eric Auger
Cc: peter.maydell, mst, cohuck, qemu-devel, abologna, qemu-arm,
eric.auger.pro
On Wed, Oct 13, 2021 at 03:17:55PM -0400, Eric Auger wrote:
> Drop base_name and turn generic_name into
> "virtio-iommu-pci". This is more in line with
> other modern-only devices.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> hw/virtio/virtio-iommu-pci.c | 3 +--
> include/hw/virtio/virtio-iommu.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 86fa4e6c28..a160ae6b41 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -98,8 +98,7 @@ static void virtio_iommu_pci_instance_init(Object *obj)
> }
>
> static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = {
> - .base_name = TYPE_VIRTIO_IOMMU_PCI,
> - .generic_name = "virtio-iommu-pci",
> + .generic_name = TYPE_VIRTIO_IOMMU_PCI,
> .instance_size = sizeof(VirtIOIOMMUPCI),
> .instance_init = virtio_iommu_pci_instance_init,
> .class_init = virtio_iommu_pci_class_init,
> diff --git a/include/hw/virtio/virtio-iommu.h b/include/hw/virtio/virtio-iommu.h
> index 273e35c04b..e2339e5b72 100644
> --- a/include/hw/virtio/virtio-iommu.h
> +++ b/include/hw/virtio/virtio-iommu.h
> @@ -26,7 +26,7 @@
> #include "qom/object.h"
>
> #define TYPE_VIRTIO_IOMMU "virtio-iommu-device"
> -#define TYPE_VIRTIO_IOMMU_PCI "virtio-iommu-device-base"
> +#define TYPE_VIRTIO_IOMMU_PCI "virtio-iommu-pci"
> OBJECT_DECLARE_SIMPLE_TYPE(VirtIOIOMMU, VIRTIO_IOMMU)
>
> #define TYPE_VIRTIO_IOMMU_MEMORY_REGION "virtio-iommu-memory-region"
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] virtio-iommu: Remove the non transitional name
2021-10-13 19:17 ` [PATCH v3 1/2] virtio-iommu: Remove the non transitional name Eric Auger
@ 2021-10-14 8:24 ` Jean-Philippe Brucker
0 siblings, 0 replies; 5+ messages in thread
From: Jean-Philippe Brucker @ 2021-10-14 8:24 UTC (permalink / raw)
To: Eric Auger
Cc: peter.maydell, mst, cohuck, qemu-devel, abologna, qemu-arm,
eric.auger.pro
On Wed, Oct 13, 2021 at 03:17:54PM -0400, Eric Auger wrote:
> Remove the non transitional name for virtio iommu. Like other
> devices introduced after 1.0 spec, the virtio-iommu does
> not need it.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Reported-by: Andrea Bolognani <abologna@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> hw/virtio/virtio-iommu-pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 770c286be7..86fa4e6c28 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -100,7 +100,6 @@ static void virtio_iommu_pci_instance_init(Object *obj)
> static const VirtioPCIDeviceTypeInfo virtio_iommu_pci_info = {
> .base_name = TYPE_VIRTIO_IOMMU_PCI,
> .generic_name = "virtio-iommu-pci",
> - .non_transitional_name = "virtio-iommu-pci-non-transitional",
> .instance_size = sizeof(VirtIOIOMMUPCI),
> .instance_init = virtio_iommu_pci_instance_init,
> .class_init = virtio_iommu_pci_class_init,
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-14 8:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13 19:17 [PATCH v3 0/2] virtio-iommu: Name Tweaks Eric Auger
2021-10-13 19:17 ` [PATCH v3 1/2] virtio-iommu: Remove the non transitional name Eric Auger
2021-10-14 8:24 ` Jean-Philippe Brucker
2021-10-13 19:17 ` [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name Eric Auger
2021-10-14 8:24 ` Jean-Philippe Brucker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).