* [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in
@ 2022-04-27 12:33 Thomas Huth
2022-04-27 13:38 ` Anthony PERARD via
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2022-04-27 12:33 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Stefano Stabellini, Paul Durrant, qemu-trivial, kraxel,
Anthony Perard, xen-devel
The 'xenfb' parameter for the '-vga' command line option is currently
always enabled unconditionally (since the xenfb is not a proper QOM
device that could be tested via its class name). That means it also
shows up if Xen is not enabled at all, e.g. like this:
$ ./qemu-system-sparc -vga help
none no graphic card
xenfb Xen paravirtualized framebuffer
tcx TCX framebuffer (default)
cg3 CG3 framebuffer
Let's avoid this situation by fencing the parameter with the
CONFIG_XEN_BACKEND switch.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
softmmu/vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 06a0e342fe..e26421b815 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -934,10 +934,12 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
.name = "CG3 framebuffer",
.class_names = { "cgthree" },
},
+#ifdef CONFIG_XEN_BACKEND
[VGA_XENFB] = {
.opt_name = "xenfb",
.name = "Xen paravirtualized framebuffer",
},
+#endif
};
static bool vga_interface_available(VGAInterfaceType t)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in
2022-04-27 12:33 [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in Thomas Huth
@ 2022-04-27 13:38 ` Anthony PERARD via
0 siblings, 0 replies; 2+ messages in thread
From: Anthony PERARD via @ 2022-04-27 13:38 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Paolo Bonzini, kraxel, qemu-trivial, xen-devel,
Stefano Stabellini, Paul Durrant
On Wed, Apr 27, 2022 at 02:33:16PM +0200, Thomas Huth wrote:
> The 'xenfb' parameter for the '-vga' command line option is currently
> always enabled unconditionally (since the xenfb is not a proper QOM
> device that could be tested via its class name). That means it also
> shows up if Xen is not enabled at all, e.g. like this:
>
> $ ./qemu-system-sparc -vga help
> none no graphic card
> xenfb Xen paravirtualized framebuffer
> tcx TCX framebuffer (default)
> cg3 CG3 framebuffer
>
> Let's avoid this situation by fencing the parameter with the
> CONFIG_XEN_BACKEND switch.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-27 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 12:33 [PATCH] softmmu/vl: Fence 'xenfb' if Xen support is not compiled in Thomas Huth
2022-04-27 13:38 ` Anthony PERARD via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).