From: Andrea Bolognani <abologna@redhat.com>
To: Sergio Lopez <slp@redhat.com>, mst@redhat.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)
Date: Tue, 30 Jul 2019 12:25:30 +0200 [thread overview]
Message-ID: <a43acc8541c7ae811d65eb4d08e1a08333781282.camel@redhat.com> (raw)
In-Reply-To: <20190729125755.45008-1-slp@redhat.com>
On Mon, 2019-07-29 at 14:57 +0200, Sergio Lopez wrote:
[...]
> /* virtio-mmio device */
>
> static Property virtio_mmio_properties[] = {
> DEFINE_PROP_BOOL("format_transport_address", VirtIOMMIOProxy,
> format_transport_address, true),
> + DEFINE_PROP_BOOL("modern", VirtIOMMIOProxy, modern, false),
> DEFINE_PROP_END_OF_LIST(),
> };
Not a QEMU developer so forgive me if I say something silly, but IIUC
you'd be able to opt into the new feature by using eg.
-device virtio-net-device,modern=on
However, virtio-pci devices already have a mechanism to control the
VirtIO protocol version, where you use
-device virtio-net-pci,disable-modern=no,disable-legacy=yes
to get a VirtIO 1.x-only device and
-device virtio-net-pci,disable-modern=no,disable-legacy=no
for a transitional device.
Can you please make sure virtio-mmio uses the existing interface
instead of introducing a new one?
--
Andrea Bolognani / Red Hat / Virtualization
next prev parent reply other threads:[~2019-07-30 10:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:57 [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1) Sergio Lopez
2019-07-29 13:10 ` no-reply
2019-07-30 7:06 ` Stefan Hajnoczi
2019-07-30 8:34 ` Michael S. Tsirkin
2019-07-31 12:22 ` Sergio Lopez
2019-07-31 19:34 ` Michael S. Tsirkin
2019-07-31 21:22 ` Eduardo Habkost
2019-07-30 10:25 ` Andrea Bolognani [this message]
2019-07-30 11:35 ` Cornelia Huck
2019-07-30 12:17 ` Andrea Bolognani
2019-07-30 13:14 ` Cornelia Huck
2019-07-30 20:02 ` Michael S. Tsirkin
2019-07-30 20:18 ` Michael S. Tsirkin
2019-07-31 11:04 ` Sergio Lopez
2019-07-31 13:55 ` Cornelia Huck
2019-07-31 19:06 ` Michael S. Tsirkin
2019-08-01 8:18 ` Cornelia Huck
2019-07-31 11:02 ` Sergio Lopez
2019-08-01 12:17 ` Michael S. Tsirkin
2019-07-30 16:06 ` Laszlo Ersek
2019-07-31 23:58 ` Paolo Bonzini
2019-08-01 19:45 ` Michael S. Tsirkin
2019-08-02 9:24 ` Paolo Bonzini
2019-08-02 0:26 ` Laszlo Ersek
2019-08-02 9:20 ` Peter Maydell
2019-08-02 22:33 ` Laszlo Ersek
2019-08-01 8:37 ` Sergio Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43acc8541c7ae811d65eb4d08e1a08333781282.camel@redhat.com \
--to=abologna@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).