* [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid()
@ 2021-03-25 14:27 Zenghui Yu
2021-03-25 14:59 ` Auger Eric
2021-03-26 13:54 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Zenghui Yu @ 2021-03-25 14:27 UTC (permalink / raw)
To: qemu-devel, qemu-arm, eric.auger, peter.maydell
Cc: Zenghui Yu, wanghaibin.wang
They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement
translate callback") but never actually used. Drop them.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
hw/arm/smmuv3-internal.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
index b6f7e53b7c..3dac5766ca 100644
--- a/hw/arm/smmuv3-internal.h
+++ b/hw/arm/smmuv3-internal.h
@@ -595,13 +595,6 @@ static inline int pa_range(STE *ste)
#define CD_A(x) extract32((x)->word[1], 14, 1)
#define CD_AARCH64(x) extract32((x)->word[1], 9 , 1)
-#define CDM_VALID(x) ((x)->word[0] & 0x1)
-
-static inline int is_cd_valid(SMMUv3State *s, STE *ste, CD *cd)
-{
- return CD_VALID(cd);
-}
-
/**
* tg2granule - Decodes the CD translation granule size field according
* to the ttbr in use
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid()
2021-03-25 14:27 [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid() Zenghui Yu
@ 2021-03-25 14:59 ` Auger Eric
2021-03-26 13:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2021-03-25 14:59 UTC (permalink / raw)
To: Zenghui Yu, qemu-devel, qemu-arm, peter.maydell; +Cc: wanghaibin.wang
Hi Zenghui,
On 3/25/21 3:27 PM, Zenghui Yu wrote:
> They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement
> translate callback") but never actually used. Drop them.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> hw/arm/smmuv3-internal.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
> index b6f7e53b7c..3dac5766ca 100644
> --- a/hw/arm/smmuv3-internal.h
> +++ b/hw/arm/smmuv3-internal.h
> @@ -595,13 +595,6 @@ static inline int pa_range(STE *ste)
> #define CD_A(x) extract32((x)->word[1], 14, 1)
> #define CD_AARCH64(x) extract32((x)->word[1], 9 , 1)
>
> -#define CDM_VALID(x) ((x)->word[0] & 0x1)
> -
> -static inline int is_cd_valid(SMMUv3State *s, STE *ste, CD *cd)
> -{
> - return CD_VALID(cd);
> -}
> -
> /**
> * tg2granule - Decodes the CD translation granule size field according
> * to the ttbr in use
>
Acked-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid()
2021-03-25 14:27 [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid() Zenghui Yu
2021-03-25 14:59 ` Auger Eric
@ 2021-03-26 13:54 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2021-03-26 13:54 UTC (permalink / raw)
To: Zenghui Yu; +Cc: Eric Auger, qemu-arm, QEMU Developers, wanghaibin.wang
On Thu, 25 Mar 2021 at 14:27, Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> They were introduced in commit 9bde7f0674fe ("hw/arm/smmuv3: Implement
> translate callback") but never actually used. Drop them.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 14:27 [PATCH] hw/arm/smmuv3: Drop unused CDM_VALID() and is_cd_valid() Zenghui Yu
2021-03-25 14:59 ` Auger Eric
2021-03-26 13:54 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).