From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: "make check-acceptance" takes way too long
Date: Fri, 30 Jul 2021 17:41:12 +0200 [thread overview]
Message-ID: <a79d07ea-31a8-2a9d-37ec-317a61091c32@amsat.org> (raw)
In-Reply-To: <CAFEAcA9cMZoj18gq7Ksv5PRoU1wRmXvW_e9UE73C_MEB7wTroQ@mail.gmail.com>
On 7/30/21 5:12 PM, Peter Maydell wrote:
> "make check-acceptance" takes way way too long. I just did a run
> on an arm-and-aarch64-targets-only debug build and it took over
> half an hour, and this despite it skipping or cancelling 26 out
> of 58 tests!
>
> I think that ~10 minutes runtime is reasonable. 30 is not;
> ideally no individual test would take more than a minute or so.
>
> Output saying where the time went. The first two tests take
> more than 10 minutes *each*. I think a good start would be to find
> a way of testing what they're testing that is less heavyweight.
IIRC the KVM forum BoF, we suggested a test shouldn't take more than
60sec. But then it was borderline for some tests so we talked about
allowing 90-120sec, and more should be discussed and documented.
However it was never documented / enforced.
This seems to match my memory:
$ git grep 'timeout =' tests/acceptance/
tests/acceptance/avocado_qemu/__init__.py:440: timeout = 900
tests/acceptance/boot_linux_console.py:99: timeout = 90
tests/acceptance/boot_xen.py:26: timeout = 90
tests/acceptance/linux_initrd.py:27: timeout = 300
tests/acceptance/linux_ssh_mips_malta.py:26: timeout = 150 # Not for
'configure --enable-debug --enable-debug-tcg'
tests/acceptance/machine_arm_canona1100.py:18: timeout = 90
tests/acceptance/machine_arm_integratorcp.py:34: timeout = 90
tests/acceptance/machine_arm_n8x0.py:20: timeout = 90
tests/acceptance/machine_avr6.py:25: timeout = 5
tests/acceptance/machine_m68k_nextcube.py:30: timeout = 15
tests/acceptance/machine_microblaze.py:14: timeout = 90
tests/acceptance/machine_mips_fuloong2e.py:18: timeout = 60
tests/acceptance/machine_mips_loongson3v.py:18: timeout = 60
tests/acceptance/machine_mips_malta.py:38: timeout = 30
tests/acceptance/machine_ppc.py:14: timeout = 90
tests/acceptance/machine_rx_gdbsim.py:22: timeout = 30
tests/acceptance/machine_s390_ccw_virtio.py:24: timeout = 120
tests/acceptance/machine_sparc64_sun4u.py:20: timeout = 90
tests/acceptance/machine_sparc_leon3.py:15: timeout = 60
tests/acceptance/migration.py:27: timeout = 10
tests/acceptance/ppc_prep_40p.py:18: timeout = 60
tests/acceptance/replay_kernel.py:34: timeout = 120
tests/acceptance/replay_kernel.py:357: timeout = 180
tests/acceptance/reverse_debugging.py:33: timeout = 10
tests/acceptance/tcg_plugins.py:24: timeout = 120
>
> (01/58) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2:
> PASS (629.74 s)
> (02/58) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3:
> PASS (628.75 s)
> (03/58) tests/acceptance/boot_linux.py:BootLinuxAarch64.test_virt_kvm:
> CANCEL: kvm accelerator does not seem to be available (1.18 s)
We could restrict these to one of the projects runners (x86 probably)
with something like:
@skipUnless(os.getenv('X86_64_RUNNER_AVAILABLE'), '...')
> (15/58) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi:
> PASS (4.86 s)
> (16/58) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_initrd:
> PASS (39.85 s)
> (17/58) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_sd:
> PASS (53.57 s)
> (18/58) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_bionic_20_08:
> SKIP: storage limited
> (19/58) tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_arm_orangepi_uboot_netbsd9:
> SKIP: storage limited
I've been thinking about restricting them to my sdmmc-tree, but if
I don't send pull-req I won't test or catch other introducing
regressions. They respect the 60sec limit.
We could restrict some jobs to maintainers fork namespace, track
mainstream master branch and either run the pipelines when /master
is updated or regularly
(https://docs.gitlab.com/ee/ci/pipelines/schedules.html)
but them if the maintainer becomes busy / idle / inactive we
similarly won't catch regressions in mainstream.
Anyway Daniel already studied the problem and send a RFC but we
ignored it:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg761087.html
Maybe worth continuing the discussion there?
next prev parent reply other threads:[~2021-07-30 15:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:12 "make check-acceptance" takes way too long Peter Maydell
2021-07-30 15:41 ` Philippe Mathieu-Daudé [this message]
2021-07-30 15:42 ` Peter Maydell
2021-07-30 22:04 ` Cleber Rosa
2021-07-31 6:39 ` Thomas Huth
2021-07-31 17:58 ` Cleber Rosa
2021-07-31 18:41 ` Alex Bennée
2021-07-31 20:32 ` Peter Maydell
2021-08-02 22:55 ` Cleber Rosa
2021-08-02 8:38 ` Daniel P. Berrangé
2021-08-02 12:47 ` Alex Bennée
2021-08-02 12:59 ` Daniel P. Berrangé
2021-08-02 12:55 ` Alex Bennée
2021-08-02 13:00 ` Peter Maydell
2021-08-02 13:04 ` Daniel P. Berrangé
2021-08-02 13:25 ` Thomas Huth
2021-08-02 13:00 ` Daniel P. Berrangé
2021-08-02 13:27 ` Thomas Huth
2021-08-02 13:43 ` Gerd Hoffmann
2022-01-20 15:13 ` Peter Maydell
2022-01-20 15:35 ` Philippe Mathieu-Daudé via
2022-01-21 7:56 ` Thomas Huth
2022-01-21 10:50 ` Markus Armbruster
2022-01-21 11:33 ` Peter Maydell
2022-01-21 12:23 ` Alex Bennée
2022-01-21 12:41 ` Thomas Huth
2022-01-21 15:21 ` Daniel P. Berrangé
2022-01-25 9:20 ` Gerd Hoffmann
2022-02-01 6:31 ` Stefano Brivio
2022-02-01 7:49 ` Gerd Hoffmann
2022-02-01 9:06 ` Daniel P. Berrangé
2022-02-01 10:27 ` Stefano Brivio
2022-02-01 11:17 ` Alex Bennée
2022-02-01 16:01 ` Cleber Rosa
2022-02-01 16:19 ` Daniel P. Berrangé
2022-02-01 17:47 ` Cleber Rosa
2022-02-01 18:03 ` Alex Bennée
2022-02-01 19:04 ` Cleber Rosa
2022-02-01 18:35 ` Stefano Brivio
2022-02-01 17:59 ` Cédric Le Goater
2022-02-01 11:06 ` Kashyap Chamarthy
2022-02-01 15:54 ` Cleber Rosa
2022-02-01 5:29 ` Cleber Rosa
2022-02-01 17:01 ` Daniel P. Berrangé
2022-02-01 17:59 ` Cleber Rosa
2022-02-15 18:14 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79d07ea-31a8-2a9d-37ec-317a61091c32@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).